From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23897C43334 for ; Mon, 20 Jun 2022 05:55:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 254556B0071; Mon, 20 Jun 2022 01:55:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 204846B0073; Mon, 20 Jun 2022 01:55:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F4166B0074; Mon, 20 Jun 2022 01:55:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0032D6B0071 for ; Mon, 20 Jun 2022 01:55:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C4F1A3397D for ; Mon, 20 Jun 2022 05:55:46 +0000 (UTC) X-FDA: 79597552692.06.D8F6468 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 0CBC71C001F for ; Mon, 20 Jun 2022 05:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OK5Lmq26Sjt+WwRVBGAaabVhvu5RcuOZ2N2C2m7lIww=; b=Uq4BRyYARS/afjWOVHN6grwCpy m72lpKaCKoybAL51mCxsT1Kp3sDmm2CoSesqrUbFzv5NytHehq9cXl6f0ynNXSDxsJnHcch1m2Ebe 8dl/9X+0BnJSw5qRQBuXbEJ/hzJhNoMQDZN/DNW+1gjtkdwvwJxF6PSK5PYaiOhDAaJghBxCQM2cB cT09Ft064qBSblGoTeN9WIpbyB+OxY5UAzIJJl9+rCXJwKFqn8iT9hiorm219NhN3FsLtu5WD+un+ 4apUZcWQF1vo6UHX15U4qWqDLXRvaKnewqob+F8GlNmW87uwzfFvHOb/cv7mShHm1JEpwkEvg+zI1 W96EPvoQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3ANw-00GM3L-9x; Mon, 20 Jun 2022 05:55:40 +0000 Date: Sun, 19 Jun 2022 22:55:40 -0700 From: Christoph Hellwig To: Anshuman Khandual Cc: kernel test robot , linux-mm@kvack.org, kbuild-all@lists.01.org, hch@infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH V3 1/2] mm/mmap: Restrict generic protection_map[] array visibility Message-ID: References: <20220616040924.1022607-2-anshuman.khandual@arm.com> <202206162004.ak9KTfMD-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655704546; a=rsa-sha256; cv=none; b=IuMsyK+o0wdOIE/XJFhJJuRSETA09L8kjjxOms1h6EfSYaw7REe/V25MQM2361qt7MqgFV ulC5XKOiOT/W4+O0Z2IAIKzoHpemDHN20PH4fr/RIgejf6LiSaNl/VMSbpolsj02YTPKnv vRpBfT0HN52Cddcu7Ob/nUILtEyP8RM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Uq4BRyYA; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655704546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OK5Lmq26Sjt+WwRVBGAaabVhvu5RcuOZ2N2C2m7lIww=; b=Sjh1fzv72OhJH03ori3TvKoRp7670p7ARZcUlHPX1vKpBWIVH6ZQXORQExM1V50ZdpXYWG dIfTrm1qcOF6BbUIfv7BofksPxQU4wEy4giNzK01rYeZeENrjKRoA3gr2k92rAQZgeyd9Y D+eUVac9cnGmpRYWGn/Ke+T8S1vh81g= X-Rspamd-Server: rspam01 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Uq4BRyYA; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: bdstrt8hizdtj6tx6zzm8c7z71tstjix X-Rspamd-Queue-Id: 0CBC71C001F X-HE-Tag: 1655704545-167917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 10:15:31AM +0530, Anshuman Khandual wrote: > +extern pgprot_t protection_map[16]; externs in .c files are never a good idea. I'd rather add a helper function toadd pgprot_encrypted to protection_map to pgprot.c.