From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31118C433EF for ; Mon, 20 Jun 2022 09:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A95B68E0007; Mon, 20 Jun 2022 05:30:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45BB8E0005; Mon, 20 Jun 2022 05:30:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90CD58E0007; Mon, 20 Jun 2022 05:30:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F1418E0005 for ; Mon, 20 Jun 2022 05:30:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4CA19603CD for ; Mon, 20 Jun 2022 09:30:31 +0000 (UTC) X-FDA: 79598093862.16.F4DAA18 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 887431600A9 for ; Mon, 20 Jun 2022 09:30:29 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id 23so3643355pgc.8 for ; Mon, 20 Jun 2022 02:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=y8J3adRTFx0+l7qiCljpvacMAoRZTzljC86NoPhyp7A6KhE8XkrV0+sskJHqS20FLL BpONFh3dOC9GLQOJpXXVYb0yPcVg5Gq0zOBXmwGZpzuIQeH4cuYfKlz7Stserhxa/EB1 Jh2U1u9GHn/IzcxV+n7J2gpdqOrQzsQ3hKW9/gHb3u12mXOWLugUUHVGqmT37GFO0HZq ILx3qoOZf8pv74pLSxVLMSRM9BccxcafW/yTft1bKmZLSGv67wBXpVY37Ly1DGv9kyQd 2LDbYhY9L+lr15OjynwD3yrR+X9k1POcN5WAd3KtVluZftfpe6xUuF9i80PrI3roS9Gt pJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=E/PF+5v4LLetA1S7vqVpX6RFmLiTts86n2qu7X3vThyJExmg/5uGY87WjFTjdVP0kE zG7hNPW1ee4KIvGHKstkQNtXzf7pbiLGVqKhAwchMEOIee/GL+/AdV1O8M3Ok/1DLRi0 /aV04BmeYk+ZODvWQduVIQKkLu+oRD1ULFbqlj4tX20aElb5K2rMCU+mKcc///1N9/DX 9ka27BQ2cLuCZGLMWuu0M++W1XN0S68HvVTqEJcsNZo3pgGNtcSv16Q4k1UHWEpYXftY O586FtkglH5vs0BrzUQrKS+0HT1T0XjZ3/w3g3adlJCr8TvM6y6A1EpC1DsRdBRAtczt FqVQ== X-Gm-Message-State: AJIora/8Pmw4dGmTYzr8iGyECZstDt3gU/30uq1GjtVpi73UW6o9/qvd tO3uDfmC0POThTMrN2aUNkGQ0w== X-Google-Smtp-Source: AGRyM1uulP868BsU4RImI3GLFupf/7hbGC6YsildM6h9Yesz0p+isYSxP8T101LoHoX+tkcdZKP5xw== X-Received: by 2002:a65:4501:0:b0:3fc:4895:283b with SMTP id n1-20020a654501000000b003fc4895283bmr21219274pgq.231.1655717428290; Mon, 20 Jun 2022 02:30:28 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id y188-20020a62cec5000000b00525286c7847sm990754pfg.216.2022.06.20.02.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 02:30:27 -0700 (PDT) Date: Mon, 20 Jun 2022 17:30:23 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] mm/swap: remove swap_cache_info statistics Message-ID: References: <20220608144031.829-1-linmiaohe@huawei.com> <20220608144031.829-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608144031.829-4-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655717431; a=rsa-sha256; cv=none; b=MZN6j958ewzGZf/rOAwPa9AeoAOpBVYvZfuQkH2LJ2sXXWdiQGAM5n7tKeB+SS9yHOMwjv td0zR+Z+JeZFUPPGoBUN6CcH6RMfvj303O7B9hzblGS0Ga0Ov/AgN6ypPDv/peXo2alH83 yz9rMwB+KelaoODsfm7kruYk7NkLjS8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y8J3adRT; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655717431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=s5Vbf/p7/cE6vBIL+x12ykFnoiS8SuQBb1sArkcrZGLIlyTEO9uvvDzw4RkuRtWoC1hXLd G2XmMzAmySpu+JizHCgWbKZGzOopaD8AtBL81KHu6+nJuEo4iPLrnwSOawi14+XGoCXGtU tuSu85LJgPIhHj2nhqra7JMcA5fOin0= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y8J3adRT; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: cmgxi6su5s6epuu7prq7hmge58n7ekzt X-Rspamd-Queue-Id: 887431600A9 X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1655717429-321120 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 08, 2022 at 10:40:31PM +0800, Miaohe Lin wrote: > swap_cache_info are not statistics that could be easily used to tune system > performance because they are not easily accessile. Also they can't provide > really useful info when OOM occurs. Remove these statistics can also help > mitigate unneeded global swap_cache_info cacheline contention. > > Suggested-by: David Hildenbrand > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song Thanks.