From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15A2C43334 for ; Thu, 30 Jun 2022 23:02:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 080088E0002; Thu, 30 Jun 2022 19:02:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02FB28E0001; Thu, 30 Jun 2022 19:02:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E13488E0002; Thu, 30 Jun 2022 19:02:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D18D08E0001 for ; Thu, 30 Jun 2022 19:02:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9CF1C612DD for ; Thu, 30 Jun 2022 23:02:01 +0000 (UTC) X-FDA: 79636426842.19.25DE979 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf20.hostedemail.com (Postfix) with ESMTP id D25AE1C0044 for ; Thu, 30 Jun 2022 23:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xsduXeYpmYNCgboOcGK4VNY+9k6YY2Ixlo9C8vms2e4=; b=ZBDESSTIfrnnm6hKzRVvdIl1ix dgLjjyV2Nev4pj2vRYyc37c1fFexZ8efPNcLd8D/PdBGnz2Huf9bqusubprgoi542GG2N9qNNcQXR Q9InCgdUpoFWAycJM2KnJglPOdozkhIp1OWQopjZhI3GXZ4p8wmyS8BkAczlaeQUJqI752n2AwXsq dy3lnx4msooiYUCGZo/xRLYj4VnHvAUyEhcmEmV3EXaSf+HGC+CgF5QDRaD7riKXh1BP06GeNa2VC kYMxRf3z7vA9VJ1ZW7Lt5YOT8nD2OwL7g3+0VQFTHgoiu7+1Hh+Sy5V/jgrFa7dbpOhtdeHEXAj5a HLLJLuGA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1o739z-006ijm-JP; Thu, 30 Jun 2022 23:01:19 +0000 Date: Fri, 1 Jul 2022 00:01:19 +0100 From: Al Viro To: Khalid Aziz Cc: akpm@linux-foundation.org, willy@infradead.org, aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com, ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz, keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com, linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com, pcc@google.com, rppt@kernel.org, sieberf@amazon.com, sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de, yzaikin@google.com Subject: Re: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information file Message-ID: References: <34e2eabbef5916c784dc16856ce25b3967f9b405.1656531090.git.khalid.aziz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34e2eabbef5916c784dc16856ce25b3967f9b405.1656531090.git.khalid.aziz@oracle.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656630120; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xsduXeYpmYNCgboOcGK4VNY+9k6YY2Ixlo9C8vms2e4=; b=g7520ih/KO8m4ZpyvG34EVwFhuaIYStQ/9NDSfsPMCGRVDZS1TQaFa8ePDcM7dJBdPSjfv fvWjYkrvc/uF1PpcDJsn+6eL+se/jyRfk+WhQNyMI1evk2yu3CNZ+IWyw/vk7tnrWPERFe QhPkNUFmNok939FWWkpBD+JSaNf2dfo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656630120; a=rsa-sha256; cv=none; b=ByMmnJq4X6vG5I7ERb7IVthU/swPdxG2JrW6RfEfKG8D21pE2rAfIF6PpTeMNluiYvioUV VRPeO924ddE6JO6Y9hqy20aw53pQULOotjudNdHN5OVRlxif60w6Kp/AeMyfK/iV/0eYiU EWc1WQXIKMliK4h5heq1vwrirPhdsRk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ZBDESSTI; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf20.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk X-Stat-Signature: efar9wpwbgjiwxqtozgepxd68p5hneup X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=ZBDESSTI; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf20.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D25AE1C0044 X-HE-Tag: 1656630120-873552 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote: > +static void > +mshare_evict_inode(struct inode *inode) > +{ > + clear_inode(inode); > +} Again, what for? And while we are at it, shouldn't you evict the pages when inode gets freed and ->i_data along with it? IOW, aren't you missing truncate_inode_pages_final(&inode->i_data); That, or just leave ->evict_inode NULL...