From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF693C43334 for ; Thu, 30 Jun 2022 22:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AEB78E0002; Thu, 30 Jun 2022 18:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 537C28E0001; Thu, 30 Jun 2022 18:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D8018E0002; Thu, 30 Jun 2022 18:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 282308E0001 for ; Thu, 30 Jun 2022 18:58:25 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E87B935A8E for ; Thu, 30 Jun 2022 22:58:24 +0000 (UTC) X-FDA: 79636417728.21.AF57A3A Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 706C54003B for ; Thu, 30 Jun 2022 22:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S/+biBIIU9UdjIcwTOYXd9h3c56AURDSMTACq4UFluM=; b=j44wui+KQxn1Lo77Lh20kh2iO3 XKEMwDRB4LpYKiYLtWM95ySbFIGAlT47iRtsZseqjZ0p/jHiYmTRwq5yupaTuY6nj8XAh2JSAMeqf NsYQkC63fru/VKsfQyViDzMfjfZJlg54Wjeb6vstPiwl7NCj8Wi0SqwvwcszyUISNF8ruDEmQW7Nd R6oea9ASJ30e29WXtaMehgRrcB90wDWm/m14ZBmh1d7vN+mbEAXr3+pX2dxrNs+UMe2IaItBmAcBZ 39ThDuTAHgOfrUSbP4cVLkkiro6cPsZF2rxXzEgW+Crhax84ZIrghkbU7UJ9T/cgB0Ijpgbaj9/iq /yrRKw0w==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1o736R-006if9-Gt; Thu, 30 Jun 2022 22:57:39 +0000 Date: Thu, 30 Jun 2022 23:57:39 +0100 From: Al Viro To: Khalid Aziz Cc: akpm@linux-foundation.org, willy@infradead.org, aneesh.kumar@linux.ibm.com, arnd@arndb.de, 21cnbao@gmail.com, corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com, ebiederm@xmission.com, hagen@jauu.net, jack@suse.cz, keescook@chromium.org, kirill@shutemov.name, kucharsk@gmail.com, linkinjeon@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, longpeng2@huawei.com, luto@kernel.org, markhemm@googlemail.com, pcc@google.com, rppt@kernel.org, sieberf@amazon.com, sjpark@amazon.de, surenb@google.com, tst@schoebel-theuer.de, yzaikin@google.com Subject: Re: [PATCH v2 1/9] mm: Add msharefs filesystem Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656629904; a=rsa-sha256; cv=none; b=BgcaF8lyz9XkYkYNEJppPbypdls/I16kaCEvCvK6Sce4c+OJv9alIJsKc1E75+bbmYCSMo Q77O4qSWdH8Rrre88LdGSmkmP5rBAmBFkW8MdQseau6tcgCSwqiCrSwU+OpBKWh+FJy4fx +0aIfovr1ORUUjpoV8m5WIIXuKU+r/Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=j44wui+K; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf07.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656629904; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/+biBIIU9UdjIcwTOYXd9h3c56AURDSMTACq4UFluM=; b=pEtlvXZy1h99vZq4RptxOjilDkVPDNB4/1JOJTePcD4wF9Nrcq+PWYniVrFFdkWLvgxeom hMflm04jHFtGh+ezruvrnmki7ABiLh0xsHdxcDT2ZlT3HcppQ+6f6W3gb990G99ir6Qd3o GwLtXT9oSiikLqoNSEWdWexApaYza4Y= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 706C54003B Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=j44wui+K; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf07.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk X-Rspam-User: X-Stat-Signature: jpq56z5k9j5pfhukzkgtg5ihu1icq8xs X-HE-Tag: 1656629904-909097 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 29, 2022 at 04:53:52PM -0600, Khalid Aziz wrote: > +static int > +msharefs_d_hash(const struct dentry *dentry, struct qstr *qstr) > +{ > + unsigned long hash = init_name_hash(dentry); > + const unsigned char *s = qstr->name; > + unsigned int len = qstr->len; > + > + while (len--) > + hash = partial_name_hash(*s++, hash); > + qstr->hash = end_name_hash(hash); > + return 0; > +} What do you need that for and how is it different from letting it use full_name_hash() (which is what it will do if you leave dentry_operations->d_hash equal to NULL)?