From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42936CCA473 for ; Thu, 30 Jun 2022 21:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58CD88E0002; Thu, 30 Jun 2022 17:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53CE68E0001; Thu, 30 Jun 2022 17:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DDB48E0002; Thu, 30 Jun 2022 17:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A6658E0001 for ; Thu, 30 Jun 2022 17:27:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id DFE326017D for ; Thu, 30 Jun 2022 21:27:36 +0000 (UTC) X-FDA: 79636188912.10.9454F03 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 5B3ED1C0043 for ; Thu, 30 Jun 2022 21:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656624455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wd1ki83p3SXylkpu3EgQoI69vBxY8no6C/MZWnJcErg=; b=VlxOTAqLEPo1xuRDRR/dg76LNpWP1wXxflag94wdkZnxhepasM08EGh9RkPXmCUmmH8DwA D73bYKIuC2T13oll1YtrpbzyQBBv/0j99r/UoCHu+JT4uHnTVZi0fyKnM7zcgSWRleGrJm 4+3DJX6FOXvIjJ0NLGFZON7ol1og6i4= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-497-e9sJNWozN4O87c2GHTqR6Q-1; Thu, 30 Jun 2022 17:27:34 -0400 X-MC-Unique: e9sJNWozN4O87c2GHTqR6Q-1 Received: by mail-io1-f71.google.com with SMTP id p16-20020a5d8b90000000b006750eb6b95dso207054iol.11 for ; Thu, 30 Jun 2022 14:27:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Wd1ki83p3SXylkpu3EgQoI69vBxY8no6C/MZWnJcErg=; b=OjJPO4tiHvSAC7YwbexGNfDDvVQ9Mjk712JLruFbnjv35LKHswJa8k4KyQmjV+J9Cj Izrwr5Hz6GoBELaQhSbZwaTKVg4oSvT+shgOJdmV/ER9e+D2cb1qI87CHK6II1sqEA7P 8FoDkIr1qctRk1/P4iSzIfZrT3pcEbt8Etf+E0dFneL53ebLd0UCV/Rtu6scHlpL6iCo 67D0oEjpmr62BFpWolOH4+sm39m2/7GWBXPJR2vEJ7bC+TCylzvkRXJJzO/jlJqY4aEX 34rdkcL5ZwVYC1M6RhU+BnZoGwNA151SnnCRXm2ayAJrojEvu8yzAs3P90ywbg8p6e1q AMOQ== X-Gm-Message-State: AJIora9me19aKle0Hp76+FnMvwG6IOb2S/uYNTc+mqLUk5SFmsKdmwbe wFBHdRsdfO9EpK4xaDYzfzpHfN4nX5REV/Bh8RDQJak3f4SG7dD5/OE8SwlFAvrYPHxbyQMnUky PILTe6aoNzDQ= X-Received: by 2002:a6b:fb05:0:b0:657:655e:a287 with SMTP id h5-20020a6bfb05000000b00657655ea287mr5835543iog.211.1656624453803; Thu, 30 Jun 2022 14:27:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t78+bU25q9esv1lcWaU4zBR2o8PbPeqMIreeppu9DzAo0eFqpPx7c+rMK82ivDZlWfZZexEQ== X-Received: by 2002:a6b:fb05:0:b0:657:655e:a287 with SMTP id h5-20020a6bfb05000000b00657655ea287mr5835526iog.211.1656624453577; Thu, 30 Jun 2022 14:27:33 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id e98-20020a02866b000000b00331598832besm9005563jai.25.2022.06.30.14.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 14:27:32 -0700 (PDT) Date: Thu, 30 Jun 2022 17:27:30 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-2-peterx@redhat.com> <16c181d3-09ef-ace4-c910-0a13fc245e48@nvidia.com> <177284f9-416d-c142-a826-e9a497751fca@nvidia.com> <17f9eae0-01bb-4793-201e-16ee267c07f2@nvidia.com> <0183984a-c95f-c92e-629e-775071b5cd23@nvidia.com> MIME-Version: 1.0 In-Reply-To: <0183984a-c95f-c92e-629e-775071b5cd23@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VlxOTAqL; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656624456; a=rsa-sha256; cv=none; b=lflKijY855gB71yVhg1s10OrOO1woQTo19OMEfOv4YqvMuIaJus4ciiW/ncZONgZB2LeA3 E7+2IpZ/kwVh9pqtsCRiZOKzzMr2oA8QA98pZrNP0FVyx5FeD3fN7xobr9TAjZw0n4/Oee ToGsyU/GZ/aqlC+CPpA9/XvgyCdemSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656624456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wd1ki83p3SXylkpu3EgQoI69vBxY8no6C/MZWnJcErg=; b=oFlQSdCtSFJ3QCS62BLOsKDX4sctg0YwaGTNqopKyeN45R88EQm2fcQ7y+fdgZwinnJTtC PG5g67PAxWd/GIAMh8m2IaT9PpeBFtNQ4JBGWBJ2ZmPN29XOog5/WF66tdX2PARABQNZgH 7j9TW03dxorU7mWfjOUlYqWTUuKI2zY= X-Stat-Signature: 831iojuhjdetmc7qjbd37d1jskr64k8w X-Rspamd-Queue-Id: 5B3ED1C0043 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VlxOTAqL; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf18.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1656624456-777260 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 30, 2022 at 12:01:53PM -0700, John Hubbard wrote: > On 6/30/22 06:49, Peter Xu wrote: > > Looks good to me, I'd tune a bit to make it less ambiguous on a few places: > > > > /* > > * FAULT_FLAG_INTERRUPTIBLE is opt-in. GUP callers must set > > * FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE. > > * That's because some callers may not be prepared to > > * handle early exits caused by non-fatal signals. > > */ > > > > Would that be okay to you? > > > > Yes, looks good. With that change, please feel free to add: > > Reviewed-by: John Hubbard Will do, thanks! -- Peter Xu