From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F0FC433EF for ; Thu, 30 Jun 2022 14:11:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A38C8E0002; Thu, 30 Jun 2022 10:11:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 253148E0001; Thu, 30 Jun 2022 10:11:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11AF38E0002; Thu, 30 Jun 2022 10:11:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0458D8E0001 for ; Thu, 30 Jun 2022 10:11:50 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D538034782 for ; Thu, 30 Jun 2022 14:11:49 +0000 (UTC) X-FDA: 79635090738.15.C5A1FF8 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf20.hostedemail.com (Postfix) with ESMTP id 60AFB1C0045 for ; Thu, 30 Jun 2022 14:11:49 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25UDni2S005113; Thu, 30 Jun 2022 14:11:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=Tp7jYxvH9F3lEn6rbNK23sm6RwbyTdBNIoz0/QMJry4=; b=bGkZ2O+QyWmfCHmZlsHgyebNM2OmZJ+AGIJk3AozhMPTNhdTeJfOOnFjimU1lqjphKBD /4SekLwVGmuwd7bq5QnyiyCsmjUVKFrxgyT33TpENhb0iTfFZ639eBU563W28dzEp0g1 7FXtzpv2N2KyQPg3vW+LGSXtRzIUHrws+a2I/x7riNue7A9jLB6Kb6FvfVBtBcld1Uin H9nALb/X47DOrN0qFVUapiOZWl47+7m3V1rneNz1aQuZuSTeUsP1Ev797rpapT3iBxRV pP4cambcejMQEAJJTdecHuXht3O/vKMU5v7JPPqNjONHff3Qa+nxv2qXTJJY9RVry+pU 9w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3h1d2c8pfa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 14:11:40 +0000 Received: from m0098416.ppops.net (m0098416.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25UDuGse002063; Thu, 30 Jun 2022 14:11:40 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3h1d2c8pek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 14:11:39 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25UE5KxM019086; Thu, 30 Jun 2022 14:11:38 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 3gwsmj89p7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jun 2022 14:11:37 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25UEBh1A31064528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Jun 2022 14:11:43 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B388B4C040; Thu, 30 Jun 2022 14:11:35 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 257FE4C044; Thu, 30 Jun 2022 14:11:35 +0000 (GMT) Received: from linux.ibm.com (unknown [9.145.154.93]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 30 Jun 2022 14:11:34 +0000 (GMT) Date: Thu, 30 Jun 2022 17:11:33 +0300 From: Mike Rapoport To: Baolin Wang Cc: akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function Message-ID: References: <9c527d4d2eb1f457306e575ce16c6acdd8141e02.1656586863.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c527d4d2eb1f457306e575ce16c6acdd8141e02.1656586863.git.baolin.wang@linux.alibaba.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: IJcKMiwvx-klPrQlNZdImYF_NifllsmN X-Proofpoint-ORIG-GUID: Zjqkfhimnf5lBHUt1IcmY8HZOXNVIApf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-30_09,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206300056 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656598309; a=rsa-sha256; cv=none; b=Urp+g68evrWTOZL+elSAmh91ZPDGBt4MUDgV5u++ccvELdMjo5AeeP9QlWJamGa+9HfFIO AiWY5nLXZku6a1QG3NPqd9NisNf3Pt25JDMpLT7VUqBfJ74cKu28q354ZwhAprKZXjBM0g +zpl0S4BZYwOPKAPGgdbyHaT7BKdUP4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=bGkZ2O+Q; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656598309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tp7jYxvH9F3lEn6rbNK23sm6RwbyTdBNIoz0/QMJry4=; b=Btdhx64HqOvT0X4wu6lrWCP4eRSlMvGOFeya6PXsC3VinHvMhr0MOyZPCMb2l8KnNvjV94 OW3Lr0Nh3AlbDdVkPYWw2LxhhO8cKs2AoAVDK4azDo17wOEFOb+3HCuMDXPWu5y5AkS4wB paFcAuHRzDoldS7gN9IxOqk0eSUmQMQ= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 60AFB1C0045 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=bGkZ2O+Q; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf20.hostedemail.com: domain of rppt@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=rppt@linux.ibm.com X-Rspam-User: X-Stat-Signature: we35jnfnuwusf55bes3fnhbrk7ok7kdn X-HE-Tag: 1656598309-765210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 30, 2022 at 07:11:14PM +0800, Baolin Wang wrote: > Factor out the pagetable pages account into new helper functions to avoid > duplicated code. Meanwhile these helper functions also will be used to > account pagetable pages which do not need split pagetale lock. > > Meanwhile convert to use mod_lruvec_page_state() in case of non-order-0 > page table allocation. These are *very* rare. I think only parisc may have non-order-0 pmd and pud tables. With that, I'd suggest making use of compound_nr() build time opt-in. > Signed-off-by: Baolin Wang > --- > include/linux/mm.h | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a2270e3..3be6d2c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2353,20 +2353,30 @@ static inline void pgtable_init(void) > pgtable_cache_init(); > } > > +static inline void pgtable_page_inc(struct page *page) > +{ > + __SetPageTable(page); > + mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page)); > +} > + > +static inline void pgtable_page_dec(struct page *page) > +{ > + __ClearPageTable(page); > + mod_lruvec_page_state(page, NR_PAGETABLE, -compound_nr(page)); > +} > + > static inline bool pgtable_pte_page_ctor(struct page *page) > { > if (!ptlock_init(page)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + pgtable_page_inc(page); > return true; > } > > static inline void pgtable_pte_page_dtor(struct page *page) > { > ptlock_free(page); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + pgtable_page_dec(page); > } > > #define pte_offset_map_lock(mm, pmd, address, ptlp) \ > @@ -2452,16 +2462,14 @@ static inline bool pgtable_pmd_page_ctor(struct page *page) > { > if (!pmd_ptlock_init(page)) > return false; > - __SetPageTable(page); > - inc_lruvec_page_state(page, NR_PAGETABLE); > + pgtable_page_inc(page); > return true; > } > > static inline void pgtable_pmd_page_dtor(struct page *page) > { > pmd_ptlock_free(page); > - __ClearPageTable(page); > - dec_lruvec_page_state(page, NR_PAGETABLE); > + pgtable_page_dec(page); > } > > /* > -- > 1.8.3.1 > -- Sincerely yours, Mike.