From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE41DC433EF for ; Fri, 17 Jun 2022 15:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24EAF6B0080; Fri, 17 Jun 2022 11:09:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FE626B0081; Fri, 17 Jun 2022 11:09:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 051096B0082; Fri, 17 Jun 2022 11:09:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E8F546B0080 for ; Fri, 17 Jun 2022 11:09:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC62560742 for ; Fri, 17 Jun 2022 15:09:18 +0000 (UTC) X-FDA: 79588061196.27.40A4C3B Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf24.hostedemail.com (Postfix) with ESMTP id D73B118007A for ; Fri, 17 Jun 2022 15:09:17 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25HC6Nr1005235 for ; Fri, 17 Jun 2022 15:09:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=vstNqh7yA1Ht5ASvEbt92QLUqdSvQZpMh03tlJYWbXo=; b=ms8Rq6Es+sg2paN6U3kTZ/9unu4CX4qd9aAmXRtUC9fP9B0+GofZcGS8Ezph4/H8/5lW P+4pPmIHSzemjxMrsRZIbNCKWkCrLhrybMf9vboqVju6n1Ka3B1dpuitB21EREtkwhtH 9C2XtQ7e2XO2NrMqipDEIn23tyEzy7oyJD2IOwCDE8LRLx/S5V8SSNebnTLm6jVAuICS eLLKaeWuNajNMN9OAywckK5CmWCUFeL3FsBmNUTmIGVBDutF72JBxwmqQu9Gc/O3QmnK 8/v++QWDDO0HqFEbWjMs1uJoqFX4SGuKv2V1dw6vfzr7fJzKpHF1hgUYBLTMhjhlOMSW vQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gmjnse3dc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 17 Jun 2022 15:09:16 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25HF0KJY018361 for ; Fri, 17 Jun 2022 15:09:10 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gpr2chwxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 17 Jun 2022 15:09:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDRkd86LG37787e9NRpVR7ZEDq6RecuB2u2p/jmPNJHiVfuXoM62wGPnuMKpkgX8d2cedmoiPoeKdwLvX/MPTdSaXhRdThL0wj2DPVw8aqp6p7x6b6WlGDTeIuBpcZV9t9J2PaEOKNz+esjsQEpPl/owe94tpZ8okKIotf+VIdIieoT3ppu80Ccjun+8bIqdzV306S2jJebKZ67TGRjoP4ctVWk3FcR8avDDQw0ibzzCC5fhY40tejPq+m+JCK3Z0C7WnIAzGvE0hbDxVd2dDkmwJfJ2y0feUqDPCGDrn85SutN1uyodHpV6tC19eHOO+LcaaCmKsKPEbt5ewRgH+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vstNqh7yA1Ht5ASvEbt92QLUqdSvQZpMh03tlJYWbXo=; b=XCtsLiuhCV2y+IAFVEA3iVLcXMXx5hn3mxH4p7L+rX5gKQo3pW47Fp4E5CdVq+RBXAGJMlmxxavCeGW6Tb9Iv5I2PX9vg5AfhRTUem0R/vMSJ6Abqq+RFISn5xb6OUPmS/IVvqE6phO0+DkOk04OElm+AU5T5zm+jQvrOZJgj38CfZ7c5QBXg+av5zfadSiNSpQE2+d3LfcKhZrUK373n01R8n1uHZ0TthfR/SAvE1VEZGSHiV5N9dYPTRhRsHDBeJH5wFUyjPesP7JaF1ZFiBq2sxM46KmzTDKCU1v7n+cyWsTmsyNlN7gaZ08WOJNLQha+HlmMbZUVxUIhA0kIog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vstNqh7yA1Ht5ASvEbt92QLUqdSvQZpMh03tlJYWbXo=; b=GPU/ybsPL/IBAhRxHSb7bg1QexjJYuy9bi3db9bTRD4LrnoDehPjO/aqRXZ+maxFDT/RcuwiA88zGgqP7gH1e8OGqygMfO3rLNVv7fhGw6HA7fv4roV1LwEgO2qGGMg9mjmqF483hIy5tWmP4YujqgX4h6ARWGtqCpz1n1jWXuQ= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DM5PR10MB1452.namprd10.prod.outlook.com (2603:10b6:3:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.15; Fri, 17 Jun 2022 15:09:09 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5332.020; Fri, 17 Jun 2022 15:09:08 +0000 Date: Fri, 17 Jun 2022 18:08:59 +0300 From: Dan Carpenter To: liam.howlett@oracle.com Cc: linux-mm@kvack.org Subject: [bug report] maple_tree: change spanning store to work on larger trees Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: ZR0P278CA0197.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::8) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9095998b-21c8-42c2-0755-08da507353e1 X-MS-TrafficTypeDiagnostic: DM5PR10MB1452:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DmhKgE/xBpmcFcUUiOcaGl9bFE6AroDS8NPPvyGdLDNwx52j+HSPohgFZkx3vsD2/o2a0s+A7iGhYIT/LZP7xIjnUaYUctyfPQPipvcRkcMnpjx+NNa8XsBUC9g4TrjHkIlbAIFjYEbCjZMWnmojzHY+dV+mfLaZfu2Phyme1zsRhoTq2BTxgtlUFHL/GjHYEX0MAL3kLx9XrPXWtSyz7s0VD7YJ4Qf4f/JdqvFfRR33KRCxUl63WrZoWIHL1JQ+N+08xCjpFSncgXpT4QnXF7rKiBWpd0z9apXs8+KWrSAkN0O/8uKJjHHnJReHy5vWYEz/MhFQ3PIxXlKwoTgw9ZiUwYTJmYxue4PUiSkwAYZyR1Hu6/iWJmccmxpNRNXce0LVkL3pYyV0hK2sA/8pJ+IL/skVGeA/vjyGfR/Cj/1Za1pGhqJaYefubb8qI9CLsFS5m/UtlfGiXZN1/fKY6m99cKcIA68mlwxF+6/87AEMYBAAEh7KzaD0QFEASbK3j2Ro7//OHqqV2YeC2eX8m7COqpNGAI7Mu8CZThDsEaFvxBJAdlr+EWY82SudC84RF1iA3BgTxpjg1kFplK2uoJyTkKREOKAwLyFODLUhY/jscPS74e2g7OURwisS1UeexZBmFiw1yPz4ihOTSAogBsz8Lpqn6JgFSpqE6qegZGdEmIagHR3kKtx2sTLzKPX64B/8nnd49mxEwPZFMd0kOrbiFYplI9+5kAxi1D4uYUhUmSujjTk574xFu7WppJ78lUFJpLfdgylchV4LWhHWaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(366004)(498600001)(34206002)(316002)(33716001)(44832011)(8676002)(8936002)(66946007)(4326008)(66476007)(5660300002)(66556008)(6486002)(83380400001)(52116002)(9686003)(6666004)(186003)(26005)(86362001)(38100700002)(2906002)(38350700002)(6506007)(6636002)(6512007)(239114007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rcEQ4T07JufJaidCP1TMGJairRM90Y6XJo0F2O2Wxu8cjf2nVyLV5X+o3m1m?= =?us-ascii?Q?6bxw/t5wwpx1mCQ1KUTZh+j8bI/tupZJHtukgcuHOvLPma6TLYxcha2TXWZi?= =?us-ascii?Q?PJUglA3E7lt+pWiBUJc1QJvQoXmNg5m9ag6J1YmAnh9nPUSKLIErz/0i/YsA?= =?us-ascii?Q?iMt8i0Zs8yLO+GU0OlDCUUAACzA4F1ctnCm4hvezDYO/ibYzGkGu9mb7SbeL?= =?us-ascii?Q?+8x04zgsxQmesob/u00WyP1+vTz2VjNGzWX4kDqzSuUYuM7j3lM+xV5R531Y?= =?us-ascii?Q?bIEIlQJCh/JXnapzoLAyxJtKlYS6Mi9goAQi9BU9Ip/KbgEWaQlx14YM0ENy?= =?us-ascii?Q?t6g3b/eHKm9lhwHlvXQuzfAcL9HQYY0U7LIfZgrp2EOSw+YNFCSOhYmPSVd7?= =?us-ascii?Q?jDqtP6lxmgNCvBpwQ+9pdwTVaHKwYq00YCai5wVo/oBGWRqsbrjaYFI5yCsP?= =?us-ascii?Q?EyjPPP2+BDIKK/hsZ1BNTXKoFbOxHEy/FcDj3lSmFYiwfSC/uj4RViIPcgXD?= =?us-ascii?Q?KFrq3RVWflEb/pGzpps6wAEEgmS1Kvx6YXcJo7KVB5iiVJhOiYCDEMz2AkCA?= =?us-ascii?Q?ZZ8gKPOfLu4Ha0SY4XS5ked3L/k2R0FiRDAPQtpf+hTHgH8f8C2H+21LBfZs?= =?us-ascii?Q?XPn81Cqn+XiSjvtxw8/OajtNRPVoX8g1VzxEEIyDjNMDFsQ0hpW35/yTrRS2?= =?us-ascii?Q?Tdypbjzw45OSd+GbYquZroKa0OeGzGgZk+PuCM5RCrMa5i80NnXxZfAiXE1c?= =?us-ascii?Q?m8mwo0TePAdPWoKcVjd5ucPZE21/JbN39ghOz7BlfoBMMT3Y8Cah9mu0w6yf?= =?us-ascii?Q?OMx1LtNJgNgfPNGbqftJHPYx4ylbIQpDiV/8/aYXqG+c8IztE02moUjhRozN?= =?us-ascii?Q?fuRDxo/XFlh3jWzoLVL1lgwF+tEWvxlafk7Gtrc0r1VkmaczpP6AIdRSX4MN?= =?us-ascii?Q?+beVZI9+4sBEcptCVRzVvccu5THwY9uae9z3ei7dWt5jii8BVhryTxSTFCLT?= =?us-ascii?Q?8Ribury6Y4645D5eMofyCJaXWITeqiGZsU8GgDUfU3++ed5XjrU9erQdIhT7?= =?us-ascii?Q?cNUgDu6xkwt6cv7pEcrhDZx/45UDs4pyRB8yLdFcnGGbT4y0IPelGXw1nJ5e?= =?us-ascii?Q?acMNi6kmQ/9QSIysEJ1dzvwRgqtgyuA0W/UNNaqFuPRd/WBwuCH9yON6mmF1?= =?us-ascii?Q?rLFaw2gDFruKnCALb69dWlV70TJSTvYIlc80NaI+71DogYWeDqQTpgO64eff?= =?us-ascii?Q?9Jn6w0caPhtKrarKWjwbJk9GjaUCPlKip9EWHHvOOdwIp67+VHH7RaHhGALW?= =?us-ascii?Q?/YLGnCyJ1Y/E0z0lNj3HLxS8gnAHpmHLqr/QLpfBmCtKKyCrwdUgQbIXas1U?= =?us-ascii?Q?Ljpv+SlSmU+CY6+UWId7RWFoNrFqNQvNPQ4WtwBSRIRmTxIcHPya2+OI7YDF?= =?us-ascii?Q?PIxaSMZtnq+CsTbQ9BDJ4CupMLb36DKSF81721V3BKTueQqlkdS4woOXL1kw?= =?us-ascii?Q?uh+o9Q9RtshVkyLBrRdYdVMNwzVEADVlURZIxgj4BVHh9ATy1k6KYDWKI5yx?= =?us-ascii?Q?yHWlWNAPpeSv4rrR4PNUN5he84jmCazEJ5hqNiBaC2IXD1XcpLYxbt+SlHIq?= =?us-ascii?Q?qBLQImKv+N8/nt3Z/sVyefx1URYR3TVoKkmr+o5fXUOPvp4eCz6y44mXPG4C?= =?us-ascii?Q?68Uz01LQglKNDoJEtfBMbjiXnA90tq723kuFKnmnmP/yQjG5wHYEXWoGnBTA?= =?us-ascii?Q?GHgWA6gDuu9utKH8r03XAnCWpDXG9nc=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9095998b-21c8-42c2-0755-08da507353e1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 15:09:08.8188 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /lAtWv/5/YnRbHmY/1o+vX/mYA+33azt2jg4XPaBg5eDhvw7IXQ5seGgVcZYkrAnIdBHP2C+0YUT1Vk3gd/ryDJill9Wvzgzd5bQFs635HE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1452 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-17_09:2022-06-17,2022-06-17 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 mlxlogscore=906 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206170065 X-Proofpoint-GUID: JIPpZD7botInsGhUWJv2WDs8vfM8eUKN X-Proofpoint-ORIG-GUID: JIPpZD7botInsGhUWJv2WDs8vfM8eUKN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655478558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=vstNqh7yA1Ht5ASvEbt92QLUqdSvQZpMh03tlJYWbXo=; b=P0bgYE88T/cARTwJ1Px3Xbm+5OEEMxoDUF0EtLrrR+GmfzMYf+c6aiazQCezfusD3oZbs5 zk3GHvbBykF2UZFowZGUcfUONOlFBZU3l4ALSP9rjzIcqcwjLsQj2mjIg3xiHXqrQf9Fnd mkKf5zjdzuEnynKVjhxFTL4Jzl0Em+8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655478558; a=rsa-sha256; cv=pass; b=es+J+wtfrmfBhe0dhExYdqVWK1AnfRFfvDgG5Wj0GZkg5ZcyCZkZ4m9CQi+syRhrYxlVXA b6e4Nhz5sPeuJPID05OZkw7wz17oZ72AUojEa3zfU+s8nTH1KaXmAAATh4SPvAmykcRDnm 5yZFJBzDxEtS4KPZR3VH29vvv39jY00= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=ms8Rq6Es; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="GPU/ybsP"; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf24.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: 4ffiretp3ci5f6juq16x3j1g8r657irj X-Rspamd-Queue-Id: D73B118007A Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=ms8Rq6Es; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="GPU/ybsP"; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf24.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Rspamd-Server: rspam01 X-Rspam-User: X-HE-Tag: 1655478557-582815 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam Howlett, The patch 5b979a0bc9ed: "maple_tree: change spanning store to work on larger trees" from Jun 15, 2022, leads to the following Smatch static checker warning: lib/maple_tree.c:4022 mas_wr_spanning_store() warn: inconsistent indenting lib/maple_tree.c 4009 memset(&b_node, 0, sizeof(struct maple_big_node)); 4010 /* Copy l_mas and store the value in b_node. */ 4011 mas_store_b_node(&l_wr_mas, &b_node, l_wr_mas.node_end); 4012 /* Copy r_mas into b_node. */ 4013 if (r_mas.offset <= r_wr_mas.node_end) 4014 mas_mab_cp(&r_mas, r_mas.offset, r_wr_mas.node_end, 4015 &b_node, b_node.b_end + 1); 4016 /* Stop spanning searches by searching for just index. */ 4017 l_mas.index = l_mas.last = mas->index; 4018 4019 mast.bn = &b_node; 4020 mast.orig_l = &l_mas; 4021 mast.orig_r = &r_mas; --> 4022 if (mte_dead_node(mast.orig_l->node) || 4023 mte_dead_node(mast.orig_r->node)) { 4024 printk("FUCKED. l is %s and r is %s\n", 4025 mte_dead_node(mast.orig_l->node) ? "dead" : "alive", 4026 mte_dead_node(mast.orig_r->node) ? "dead" : "alive"); 4027 printk("Writing %lu-%lu\n", mas->index, mas->last); 4028 } Heh. Looks like debug code escaped. 4029 /* Combine l_mas and r_mas and split them up evenly again. */ 4030 return mas_spanning_rebalance(mas, &mast, height + 1); 4031 } regards, dan carpenter