From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00587C43334 for ; Fri, 17 Jun 2022 10:49:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F9F16B0074; Fri, 17 Jun 2022 06:49:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A9DE6B0075; Fri, 17 Jun 2022 06:49:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34A1E6B0078; Fri, 17 Jun 2022 06:49:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2133C6B0074 for ; Fri, 17 Jun 2022 06:49:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id CDDC88112B for ; Fri, 17 Jun 2022 10:49:23 +0000 (UTC) X-FDA: 79587406206.06.20511B5 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf09.hostedemail.com (Postfix) with ESMTP id C4708140090 for ; Fri, 17 Jun 2022 10:49:22 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id g186so3771235pgc.1 for ; Fri, 17 Jun 2022 03:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=etXBBicoFjC7mauli6ZHZX7BG/ZNUXKeXrOBV6F93AY=; b=phOPovKH8vP2s1pV55Oz4O6ZizKxeZx4XrG7NbWmMDl9mdvr6v9wxQZhD7lVI0R65J f2UXcYlGmvoY3TpDJk3ZRarSzlAsBejReHOfOcduB8QmyyXlvA+cdT3Xon6kWzmWh3eh GN1LYq1wHvw2jIHI9hN//SttSFlIqFcUxDpUSnX4Y+Xs09QKhDChKmczX4+Gv/JCGiXi SWkxGYEIfP3UvGh/YCSPY58I1H6hwg2VnZPkkVVTdY6bYZ8eN087igliOZzPyxDEAEb5 VT2FQ23kpboFQH9J6EjeL1FXu+3hwfygdVZyCETPFgRNTdjYVEVqxLthIvGXW3HJxwxN aB3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=etXBBicoFjC7mauli6ZHZX7BG/ZNUXKeXrOBV6F93AY=; b=DgToaoYm5um6ZtexaXEiXDRFmSX7mpIdVFxIM+1Cc04ugLaQzECinZS3m4cUk2ESTT Igt5+lH0EnMvOh7ZwbOyMpv/DrHp6EeGch+vO+CuvSKGPcYk+kiW+Qt1I6XazPO0Fkdm 9YKMU0xoLA8KymOkeSFbfwupJ2xbmwuNg5A2Cl/3TvKkH9NTxqJLwwNkraqTxSNinLIx /FvqF+X4HB7HjcvYo9IVkUomPYllih1MFv4eSYwm5CxXwsTxHizn/C97Zs0kqHIetKwA eaRAq963Y7rs5eFanfVMj14UeDxZaz7wuXBSM6iZzKllhqcecb2YY1m3no/ur+5Ymabc sGtg== X-Gm-Message-State: AJIora9TexgXAijwKUoemQLmJtnCO0o8pU4DMUKQpApX8WDpV/B1WQml Y+FKlF69DBBaMSB6rH5b5rS7VA== X-Google-Smtp-Source: AGRyM1smMXabT6De0zMLc/jNsYGXK7Hx9fxLhsQtOCEW2kBnOIGxCqF62HXy4/Q2+euV/aN7816x6g== X-Received: by 2002:a65:6254:0:b0:405:559:a90a with SMTP id q20-20020a656254000000b004050559a90amr8407085pgv.480.1655462961483; Fri, 17 Jun 2022 03:49:21 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id az9-20020a170902a58900b00167838b82e0sm3219194plb.205.2022.06.17.03.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 03:49:20 -0700 (PDT) Date: Fri, 17 Jun 2022 18:49:15 +0800 From: Muchun Song To: David Hildenbrand Cc: Oscar Salvador , corbet@lwn.net, akpm@linux-foundation.org, paulmck@kernel.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP Message-ID: References: <20220520025538.21144-1-songmuchun@bytedance.com> <20220520025538.21144-3-songmuchun@bytedance.com> <53024884-0182-df5f-9ca2-00652c64ce36@redhat.com> <24d5ec20-9c9e-93aa-11f4-c4619f51f7d1@redhat.com> <186924ab-651f-71a1-93d2-3500a67dffee@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655462963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=etXBBicoFjC7mauli6ZHZX7BG/ZNUXKeXrOBV6F93AY=; b=DXeSfIJcxegewudN+RUzPf1fy+oeQtbcsxLR3SHLa9jw+mAHkCkcvYmd9IdQMxoEgksCZ1 Riil3gBPi/ySsy0aOUmcjlr25M279f30D4zSSwk3QXzikF5rdcxhZUtJS0QNNatjoqtvXl /8157U+ExjDdGrFii8awVGGkqvZJeP0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655462963; a=rsa-sha256; cv=none; b=BjOKgVx+IlwNJzFC769qpdiawT16SN1Wcz4xWgKdWTNwKFkvQny7K+ZCaWeJvrpx8zt4n8 Bvfaye2tZewztwNQcOkqM1CHeUNLT+nqqQB21PqDn4X0Uh5HFzThGrwTUkbMu3t8B8u+cF Gt4Fv/KqCwASqq+Mkc3zxclcAPqg1EA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=phOPovKH; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf09.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=phOPovKH; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf09.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C4708140090 X-Stat-Signature: mf8ee6xf4c1b19whj1mzzktrdiui3opt X-HE-Tag: 1655462962-630358 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 17, 2022 at 12:14:02PM +0200, David Hildenbrand wrote: > On 17.06.22 11:54, Oscar Salvador wrote: > > On Fri, Jun 17, 2022 at 09:43:33AM +0200, David Hildenbrand wrote: > >> VmemmapSelfHosted, then the function names get nicer. > > > > Definitely. > > > >> > >>> +#endif > >>> + > >>> /* > >>> * On an anonymous page mapped into a user virtual memory area, > >>> * page->mapping points to its anon_vma, not to a struct address_space; > >>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > >>> index 1089ea8a9c98..e2de7ed27e9e 100644 > >>> --- a/mm/hugetlb_vmemmap.c > >>> +++ b/mm/hugetlb_vmemmap.c > >>> @@ -101,6 +101,14 @@ void hugetlb_vmemmap_free(struct hstate *h, struct page *head) > >>> { > >>> unsigned long vmemmap_addr = (unsigned long)head; > >>> unsigned long vmemmap_end, vmemmap_reuse, vmemmap_pages; > >>> + struct mem_section *ms = __pfn_to_section(page_to_pfn(head)); > >>> + struct page *memmap; > >>> + > >>> + memmap = sparse_decode_mem_map(ms->section_mem_map, > >>> + pfn_to_section_nr(page_to_pfn(head))); > >> > >> Why can't we check the head page directly? Either I need more coffee or > >> this can be simplified. > > > > Uhm, maybe I'm the one who needs coffe here but we have something like: > > > > [ hot-plugges section ] > > [memmap pages][normal pages] > > Oh, right, we need the memmap for our hugetlb page (which resides in the > reserved section), but these are not marked. We need the memmap of that > memmap. > > I assume one could directly via the page address. Because we want the > memmap of the memmap. > > vmmemmap_page = virt_to_page(head); > I think this can works, more simple. Thanks. > Not sure, though, if that would work with that function.