From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB1EC433EF for ; Fri, 17 Jun 2022 09:48:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DAF36B0071; Fri, 17 Jun 2022 05:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863996B0073; Fri, 17 Jun 2022 05:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 704676B0074; Fri, 17 Jun 2022 05:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5B5866B0071 for ; Fri, 17 Jun 2022 05:48:41 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1541F21733 for ; Fri, 17 Jun 2022 09:48:41 +0000 (UTC) X-FDA: 79587253242.16.9B50C1F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf31.hostedemail.com (Postfix) with ESMTP id 81EF820042 for ; Fri, 17 Jun 2022 09:48:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C46411F8F0; Fri, 17 Jun 2022 09:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655459318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=xzqEv2yP28ye8lDXCCfLZWDcafj9XrD1X2CCACIO+QbXIj7EvEl1SnHEDaeeompDvdJSt/ CERpE3v22+kMj8Kgs1OU1//4D8i2ZKOUFC+Y3LwivArhMBTrpy6wlMTjRWlWhGHo/GKlgE DskYf0aIrF/TGgnpim38UDjf8MtIl0s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655459318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=65juJAIL7Ubircvln21ZYXzi/26mcJv9KTmM4uVmpChAel/X3rOsLJGBzs1PDnXDZ37oeU AshWbqj5sXIMyBDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 279701348E; Fri, 17 Jun 2022 09:48:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9+bfBvZNrGJJOQAAMHmgww (envelope-from ); Fri, 17 Jun 2022 09:48:38 +0000 Date: Fri, 17 Jun 2022 11:48:36 +0200 From: Oscar Salvador To: Muchun Song Cc: David Hildenbrand , corbet@lwn.net, akpm@linux-foundation.org, paulmck@kernel.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v2 2/2] mm: memory_hotplug: introduce SECTION_CANNOT_OPTIMIZE_VMEMMAP Message-ID: References: <20220520025538.21144-1-songmuchun@bytedance.com> <20220520025538.21144-3-songmuchun@bytedance.com> <53024884-0182-df5f-9ca2-00652c64ce36@redhat.com> <24d5ec20-9c9e-93aa-11f4-c4619f51f7d1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655459320; a=rsa-sha256; cv=none; b=gYlHnJZQ0Qmw6h8gXLm04kItdzvIH6hNwnA5xCi2r3cfCwrPKdb0HxOL05zmsD4LRjlV0M 9cRu3iXghpkLskYbJdvJ0WMP0PTvp0/XNTGnNJh1946Q8lssbWZ6iwozeU59OkWCftdtKM 1tZWysCn6J594NpOKTEFRHRTT1e8lsE= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xzqEv2yP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=65juJAIL; spf=pass (imf31.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655459320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tBRYuZriPXQUXBu/QTN08SlWn7ePBFFTpukjNr+bCwg=; b=oYywQNjlEvBG7XpD8xPBohSep3KuB/VNcfhG3FWVuXz1H3pHE1EJonvfg6bKO+6sTc1LuG 0OoExZa5PaKfJvd0Xc4DfsiPRSUl5MtlumVdF4ZfuxXIZpy1JRu4b1ZARxxYJ12pJ5gSrS X86YznX8lh/WcencvKE7MVWX5kznz+4= X-Stat-Signature: kq7snsz9zar1we5ue618upkwoth4e6i8 X-Rspamd-Queue-Id: 81EF820042 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xzqEv2yP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=65juJAIL; spf=pass (imf31.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655459320-41167 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 17, 2022 at 03:28:10PM +0800, Muchun Song wrote: > I think here needs a loop if it is a 1GB page (spans multiple sections). > Right? Here is an implementation based on another approach. But I think > your implementation is more simpler and efficient. Would you mind me > squash your diff into my patch and with your "Co-developed-by"? Sure, fine by me. -- Oscar Salvador SUSE Labs