From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA74C433EF for ; Fri, 17 Jun 2022 07:50:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4685B6B0071; Fri, 17 Jun 2022 03:50:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 418466B0073; Fri, 17 Jun 2022 03:50:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B81E6B0074; Fri, 17 Jun 2022 03:50:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E0AA6B0071 for ; Fri, 17 Jun 2022 03:50:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EA5C590E for ; Fri, 17 Jun 2022 07:50:03 +0000 (UTC) X-FDA: 79586954286.12.1650C6E Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf19.hostedemail.com (Postfix) with ESMTP id 4AD8D1A008F for ; Fri, 17 Jun 2022 07:50:03 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id o6so3247462plg.2 for ; Fri, 17 Jun 2022 00:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/5JQEnezBo8SAr6g2AvndTomb05vaO1mzGxpKpnfNFw=; b=ZeTtH3DabDO7sw5h2E093njHE2+DJU4emaCoQlZUp7EeNN+4aqMW1wh+gGD4kgX9Mb un4tS4Jz1w73FWDZF9ZIdgVT4CjQfT+O58u4lonCUU4uDdjPPFhd/QhQSUWmU1Cfl/uH ARkOv26uS6Tj6rYl3rJyTDKKXbQWwSvGnysutexvWFVLvrTJdMnQ4544eG97GvJ9CpwH YAg9krnua2PFEENTm+SWJv1BXx7U1o/MnvzD+3uFuTubs401RvZe9elIco/tuXL9jhOh P2uHvQFQ2AHrJbAzOH6EFe0vMgyyXMjYYTFHYRhm9HMU2rqIB8oKHsWHamCQQI5XKdvx XjiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/5JQEnezBo8SAr6g2AvndTomb05vaO1mzGxpKpnfNFw=; b=2I6SORntTcp6hdV+Z/tHzf1XQyyNPLPn+LcHPN5zp3MDPw5TK8iVfcNcd6gR+drLqu LnJQfhE8di/E2YIvesLZhf6AW9ns5ppTCcvp9MhtjFkexghSNRlT/SenXi8JjBDsINmt Zbh9Pwsw/MX3NvgKqsHYmI4mNNUcFgyeRsJz5AHsa+7nC1E5n4jap+M5dmfL/5//Vcim 8ypxdQHJ9hzXUEouJon+aTSLAaglFHePYAd6Im/T88Xk/Y+X+02myx2q3RyMvcmDL+AQ 6HRP3lN7X19enPhlkssXZz+fiyHQEycSRIGOTyWtrLSx/8TFQb4vUd03lrIZcjGGsQOq PClg== X-Gm-Message-State: AJIora8AcnQKfAfEDNW5dnn7QymymMm5aKnRRgruvpHxPpHnvFZmoh5c pd4BKRME2A+wiOsl22q17VZEVBrDwiqAU2Nnx7Q= X-Google-Smtp-Source: AGRyM1ueXFqi+rj4FAeCjjkCGaS9L29wOvXRortQKXhhP6ngSuvIFI1dEyfbPgthDbo+9Iga7OUdBg== X-Received: by 2002:a17:902:c946:b0:163:ed13:7ab1 with SMTP id i6-20020a170902c94600b00163ed137ab1mr8111674pla.36.1655452202297; Fri, 17 Jun 2022 00:50:02 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id 203-20020a6218d4000000b0051ba0ee30cbsm2994752pfy.128.2022.06.17.00.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 00:49:58 -0700 (PDT) Date: Fri, 17 Jun 2022 15:49:55 +0800 From: Muchun Song To: Mike Kravetz Cc: Joao Martins , david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net Subject: Re: [PATCH 3/6] mm: hugetlb_vmemmap: introduce the name HVO Message-ID: References: <20220613063512.17540-1-songmuchun@bytedance.com> <20220613063512.17540-4-songmuchun@bytedance.com> <41e2d762-2c0d-b13b-d6da-6e0e0e858a84@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655452203; a=rsa-sha256; cv=none; b=FhF9QyC7XchQKUc9ouN/yMQjdfEun9WsXfkuJIkwPuWswa2fMhMm058e7oc3L2zuSqGB9Y qOzQu5biP1tXMC96BCknx8f+CiBU8usxNR77eBWSGOOkEXaRRd/R/skGr793TyfqOsLMzs 7f8tv2eLE7MU5mzOSSqMuFhi5rJZLRI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=ZeTtH3Da; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655452203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5JQEnezBo8SAr6g2AvndTomb05vaO1mzGxpKpnfNFw=; b=704A9btfDBuobizlpf5zscjBpfXgsHYCyZIz+MC05YaUtXDJB9dpvsMgCLFvTDmya888C3 iKNL5ZIJSaHTKEhbPnFtJsOSippIo/RSqMgmip9Sa3DywNQileXpYjU9bMIadIJFp2s4iz 343nfDLibcEyGSfA9ntzJWMwoBV+0IA= X-Rspamd-Queue-Id: 4AD8D1A008F X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=ZeTtH3Da; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam06 X-Stat-Signature: jn8ooxyewzgkedxdzj4ysmae47brhrzs X-HE-Tag: 1655452203-943058 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 16, 2022 at 03:27:40PM -0700, Mike Kravetz wrote: > On 06/16/22 11:28, Muchun Song wrote: > > On Wed, Jun 15, 2022 at 03:51:51PM +0100, Joao Martins wrote: > > > On 6/13/22 07:35, Muchun Song wrote: > > > > It it inconvenient to mention the feature of optimizing vmemmap pages associated > > > > with HugeTLB pages when communicating with others since there is no specific or > > > > abbreviated name for it when it is first introduced. Let us give it a name HVO > > > > (HugeTLB Vmemmap Optimization) from now. > > > > > > > > > > Just thought I would throw this suggestion, even though I am probably too late. > > > > > > > Not too late, we are still discussing the name. > > > > > I find the term "vmemmap deduplication" more self-explanatory (at least for me) > > > to refer to your technique ,and similarly s/optimize/dedup. Or vmemmap tail page > > > deduplication (too verbose maybe) because really that's what this optimization is all > > > about. OTOH it would slightly deviate from what maybe established now > > > in hugetlb code. > > > > > > > Well, I have looked up this word "deduplication" which refers to a method of > > eliminating a dataset’s redundant data. At least I agree with you "deduplication" > > is more expressive for my technique. So I am thinking of renaming "HVO" to "HVD ( > > HugeTLB Vmemmap Deduplication)". In this series (patch 6), I have renamed > > hugetlb_vmemmap_alloc/free to hugetlb_vmemmmap_optimize/restore. I am also > > thinking of replacing it to: > > > > hugetlb_vmemmmap_deduplicate vs hugetlb_vmemmmap_duplicate. > > > > Many other places in hugetlb_vmemmap.c use "optimize" word, maybe most of them do > > not need to be changed since "deduplication" is also a __optimization__ technique. > > > > Hi Mike and David: > > > > What your opinion on this? I want to hear some thoughts from you. > > I can understand Joao's preference for deduplication. However, I can > also understand just using the term optimization. IMO, neither is far > superior to the other. It is mostly a matter of personal preference. > > My preference would be to leave it as named in this series unless > someone has a strong preference for changing. > All right. I'll keep the HVO name. Thanks.