From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB4AEC433EF for ; Fri, 17 Jun 2022 07:47:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 048A36B0073; Fri, 17 Jun 2022 03:47:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3A1A6B0074; Fri, 17 Jun 2022 03:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E027C6B0075; Fri, 17 Jun 2022 03:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D21086B0073 for ; Fri, 17 Jun 2022 03:47:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A05CF356E8 for ; Fri, 17 Jun 2022 07:47:39 +0000 (UTC) X-FDA: 79586948238.03.419C0B9 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 20FED1A0092 for ; Fri, 17 Jun 2022 07:47:38 +0000 (UTC) Received: by mail-pg1-f181.google.com with SMTP id f65so3404299pgc.7 for ; Fri, 17 Jun 2022 00:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LQLzsTXkveBN/L9q4zlOw39+Gjac4v+4fXhFTmzIAJ4=; b=GKtwGn0Ry+az6d3fqrob++js5HqraiUoJ6jsuwbYFvf5rljLHYn8wTXzVWydHwvC9m dHx/y4kJrr3y0HynuBudpwG/Z5ZudaXyAqppvGVcI4PVS4tyv+Z/bFQtgP0jz5zmCRyO lSlz2ciLyfuoMl78B5xmJyipuZfJXAff1Fk68ydI6rdeq6XNcDkMFRwXs5vTwxRExQut 4/EJ9fbd3S/1WoZOoXPO6jvZucMnJ4OrmJlRUFSnZci8QOJk7PFHjonx/pgRl9mSYfN+ R7Jj+pqxYrrRGSIraLJaGUgCmHYqTenYSJHuu/iuANmZhSjkrkODwS54IsOUetojvQck JfQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LQLzsTXkveBN/L9q4zlOw39+Gjac4v+4fXhFTmzIAJ4=; b=49BtP/Yu2WJRmI2381nQhICfe3PbasJNINNtP4NRYuVpEnmX4rvqrNqyWvm/q2AY4G uesfVtSY0WzLunPlYZoN+Dp5yjI/7bTlXp9cKELC5vcYRV2Kj8jddbMwPzN70f+gbQlM 9gHk6C0Fl1dkuw/jSOKc4nC/HZ9N0wDDa+CXYEYLq6FFHbCFXBXOBewoG1w24ON5ru3V wS/zdUPhnXyjLI3fxjBE7KxPTPJuRw7dN1Hq+edQ6ck0ZiSg662Q7Lr2NnIfE6HUR0CM YhjPxN7Jk0MUFRp/RL+BrssBZ+2MX8V7J0ii19w4iNQcmZ+Y5VZRttqjrK29b66MyJMK hkXw== X-Gm-Message-State: AJIora8MvKytRKA5Z5QVNIAeRbphoIw/zeJRFEj8u8V4EEHv4HhYUNzi q6+o4PPp9BnmyAL/8Fl5KcRvnz3NgqAB5MzDkd4= X-Google-Smtp-Source: AGRyM1u9qQl6xAeo+YSHod19qRwKsnhSpe1/UjRtqPeP94Tx6IKP5/Ae7fk+SXU4tojdPPenVBHV/g== X-Received: by 2002:a05:6a00:1a91:b0:51c:2fab:7340 with SMTP id e17-20020a056a001a9100b0051c2fab7340mr8725263pfv.74.1655452058081; Fri, 17 Jun 2022 00:47:38 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id a18-20020a056a000c9200b0051c4ecb0e3dsm2934394pfv.193.2022.06.17.00.47.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jun 2022 00:47:37 -0700 (PDT) Date: Fri, 17 Jun 2022 15:47:34 +0800 From: Muchun Song To: Christophe Leroy Cc: "mike.kravetz@oracle.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mm: hugetlb: rework hugetlb cmdline parsing Message-ID: References: <20220616071827.3480-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655452059; a=rsa-sha256; cv=none; b=3a+Ub+xIWAp13vPihOyEv7Yb+N5w3asOB++1W0umKzMoyPS12APp9mVzBr8mgHqyLVpBDY zlL25FBMb7hHiKF+uvAIjKgKsXkiTOB8KCev1ZMyX7+1gEv3A+g3kf/rE/tZHQADb8kCxy lXybfRVbYKaLgx3juXx+KX7tHbl6CYY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GKtwGn0R; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655452059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LQLzsTXkveBN/L9q4zlOw39+Gjac4v+4fXhFTmzIAJ4=; b=h83o962XlBpYNRDpYgcJrJnI0zvF52GeAllajVV0jgO6wlEpi8xn2uyM95wcUsXqh73qf9 Wxa3J1M0lhPM9hsq0qyiCXFIBTMvS3k6yih2k6cUNqbXrMYLUqYlXWSuZ54PkCYWUKRnT1 J72Nd2WYB0CI21YR3eS7tc4eBYoFq3w= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GKtwGn0R; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Stat-Signature: oj6qnx47fhbtkfjrub6xequ7rtsx7bx5 X-Rspamd-Queue-Id: 20FED1A0092 X-Rspamd-Server: rspam08 X-HE-Tag: 1655452058-251129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 16, 2022 at 08:00:58AM +0000, Christophe Leroy wrote: > > > Le 16/06/2022 à 09:18, Muchun Song a écrit : > > I often get lost in the logic interleaved between numerous global > > variables for parsing cmdline. It is not easy to be maintained. > > This patch aims to rework cmdline parsing to simlify the code and > > make the code more readable. > > This patch is quite big. > > Can you explain in the commit description in more details what are the > changes performed by this patch ? > > Otherwise I have absolutely no idea of what to review or what to test. > Sorry for the confusing, I'll rework the commit message in v2. Thanks.