From: Muchun Song <songmuchun@bytedance.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: hugetlb: rework hugetlb cmdline parsing
Date: Fri, 17 Jun 2022 15:47:34 +0800 [thread overview]
Message-ID: <Yqwxlo7HYFv4jHco@FVFYT0MHHV2J.usts.net> (raw)
In-Reply-To: <f175d757-e76c-085d-2001-68ae275475a3@csgroup.eu>
On Thu, Jun 16, 2022 at 08:00:58AM +0000, Christophe Leroy wrote:
>
>
> Le 16/06/2022 à 09:18, Muchun Song a écrit :
> > I often get lost in the logic interleaved between numerous global
> > variables for parsing cmdline. It is not easy to be maintained.
> > This patch aims to rework cmdline parsing to simlify the code and
> > make the code more readable.
>
> This patch is quite big.
>
> Can you explain in the commit description in more details what are the
> changes performed by this patch ?
>
> Otherwise I have absolutely no idea of what to review or what to test.
>
Sorry for the confusing, I'll rework the commit message in v2.
Thanks.
prev parent reply other threads:[~2022-06-17 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 7:18 Muchun Song
2022-06-16 8:00 ` Christophe Leroy
2022-06-17 7:47 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqwxlo7HYFv4jHco@FVFYT0MHHV2J.usts.net \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox