From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820A9C43334 for ; Thu, 16 Jun 2022 17:40:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C06556B0071; Thu, 16 Jun 2022 13:40:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8D4D6B0072; Thu, 16 Jun 2022 13:40:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A553F6B0074; Thu, 16 Jun 2022 13:40:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8FDBF6B0071 for ; Thu, 16 Jun 2022 13:40:57 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5D2D461688 for ; Thu, 16 Jun 2022 17:40:57 +0000 (UTC) X-FDA: 79584814554.29.FB69D86 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 919A6100092 for ; Thu, 16 Jun 2022 17:40:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9A008CE2644; Thu, 16 Jun 2022 17:40:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DC5AC34114; Thu, 16 Jun 2022 17:40:44 +0000 (UTC) Date: Thu, 16 Jun 2022 18:40:40 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: Andrey Ryabinin , Andrey Konovalov , Will Deacon , Peter Collingbourne , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] mm: kasan: Skip unpoisoning of user pages Message-ID: References: <20220610152141.2148929-1-catalin.marinas@arm.com> <20220610152141.2148929-3-catalin.marinas@arm.com> <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75aa779d-785f-6515-51cd-654e8c5d18f5@arm.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655401257; a=rsa-sha256; cv=none; b=OdoCvvsv8VZlHb21MJYHElvCLAf2JO6BKJfjmUtAjjn1u6klEgr4EJ7+AgCfR8KQ08hWql R/CUM7kK7LLvBb9QCgGxBkShgar+AG+PgmuvDwq58UPIR0RrimhT7LTSoF6uKQIk0JhVZn tvVnWkeqaPBNbLwnrTyQ07lIWc+8njc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655401257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YmM7gFlHCeAyh8Bm+tJ46gEZhXOhjtfC7KWDV6SGV7k=; b=Rn4QhrmGd6XDk2Lpiv0WMmyadAqiyd3Q1nXVQZPRmrL2X6Xq905YPRyeBBmLgeDROglQH5 UI/KeD7rdvPPv+ekgTpjatrirKrYqfCLvFzfNZi2iH3NEF1M5ZLKudemV8hX4AmXnSziQI NJCXf8j1cdtOwm+YjadnqTAu3oCNPeQ= X-Stat-Signature: h7nopynpcde45i15rjqkjt75bj8pow49 X-Rspamd-Queue-Id: 919A6100092 Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655401256-210918 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 16, 2022 at 09:42:10AM +0100, Vincenzo Frascino wrote: > On 6/10/22 16:21, Catalin Marinas wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index e008a3df0485..f6ed240870bc 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2397,6 +2397,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order, > > bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) && > > !should_skip_init(gfp_flags); > > bool init_tags = init && (gfp_flags & __GFP_ZEROTAGS); > > + int i; > > > > Nit: Since "i" is not used outside of the for loop context we could use the > contract form "for (int i = 0; ..." which is allowed by C11. Oh yeah, Linux moved to C11 in 5.18. But it looks better to be consistent with the other for loop in this file. > Reviewed-by: Vincenzo Frascino Thanks. -- Catalin