From: Matthew Wilcox <willy@infradead.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-mm@kvack.org, linux-xfs@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
Uladzislau Rezki <urezki@gmail.com>,
Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] usercopy: use unsigned long instead of uintptr_t
Date: Thu, 16 Jun 2022 15:38:02 +0100 [thread overview]
Message-ID: <YqtAShjjo1zC6EgO@casper.infradead.org> (raw)
In-Reply-To: <20220616143617.449094-1-Jason@zx2c4.com>
On Thu, Jun 16, 2022 at 04:36:17PM +0200, Jason A. Donenfeld wrote:
> A recent commit factored out a series of annoying (unsigned long) casts
> into a single variable declaration, but made the pointer type a
> `uintptr_t` rather than the usual `unsigned long`. This patch changes it
> to be the integer type more typically used by the kernel to represent
> addresses.
No. I did this on purpose. uintptr_t is the correct type to represent
a pointer that's being used as an integer. This dinosaur approach of
using unsigned long has to stop.
next prev parent reply other threads:[~2022-06-16 14:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 14:36 Jason A. Donenfeld
2022-06-16 14:38 ` Matthew Wilcox [this message]
2022-06-16 14:51 ` Jason A. Donenfeld
2022-06-16 15:11 ` Jason A. Donenfeld
2022-06-16 15:21 ` Matthew Wilcox
2022-06-16 15:59 ` Linus Torvalds
2022-06-16 16:12 ` Linus Torvalds
2022-06-16 16:44 ` Matthew Wilcox
2022-06-16 16:56 ` Linus Torvalds
2022-06-16 19:14 ` Linus Torvalds
2022-06-16 19:18 ` Linus Torvalds
2022-06-17 9:19 ` David Laight
2022-06-17 7:58 ` Geert Uytterhoeven
2022-06-17 11:05 ` Christophe Leroy
2022-06-17 12:51 ` David Laight
2022-06-16 16:29 ` Kees Cook
2022-06-16 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqtAShjjo1zC6EgO@casper.infradead.org \
--to=willy@infradead.org \
--cc=Jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox