From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FA4C433EF for ; Thu, 16 Jun 2022 06:12:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86A536B0072; Thu, 16 Jun 2022 02:12:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CB376B0073; Thu, 16 Jun 2022 02:12:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 646A66B0074; Thu, 16 Jun 2022 02:12:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 516576B0072 for ; Thu, 16 Jun 2022 02:12:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 25AC6121234 for ; Thu, 16 Jun 2022 06:12:17 +0000 (UTC) X-FDA: 79583079114.17.51DA1FC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 9716518001E for ; Thu, 16 Jun 2022 06:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dapB6H6eFYmTc+OyGbQwY3SFwU4g6u4noQOzoQl1YU0=; b=M5fVvBHC429l5XNlp98Z7FDXFG tbmyU7kv9W6Z47SRggvA9ARSKHXS7uKnYLxpeNnvYx59PCkpBeOetmiTG42BVPuY5ODUJO9uIB/tQ PsdwBIJpiy4nZpJbDP4uy+3t3CJiju4Eb+mz5oaxu1hJiP8xhOBFAG+kxf6zxfM4eips9j73jP0Tc mJKSVYEcWwOcdWDdi8bYuHafFwXEx427S3ce7TOdd20ups9kPrTFC1cHRBx/oMUqyM9ihtg3b4rfm KS+wekOBZKunfjJTr4rZwNNshpsvXN7kKlbU2sBOAvv/it3kYbswxU9OQ+WAXWVc/jhLSWhB6/dvm U1GH+gXg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1ijl-000gwA-4u; Thu, 16 Jun 2022 06:12:13 +0000 Date: Wed, 15 Jun 2022 23:12:13 -0700 From: "hch@infradead.org" To: Christophe Leroy Cc: Anshuman Khandual , "linux-mm@kvack.org" , "hch@infradead.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , kernel test robot , Christoph Hellwig Subject: Re: [PATCH V3 2/2] mm/mmap: Drop generic protection_map[] array Message-ID: References: <20220616040924.1022607-1-anshuman.khandual@arm.com> <20220616040924.1022607-3-anshuman.khandual@arm.com> <7cf922f4-2367-e173-0280-cb498391d9f7@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cf922f4-2367-e173-0280-cb498391d9f7@csgroup.eu> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655359936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dapB6H6eFYmTc+OyGbQwY3SFwU4g6u4noQOzoQl1YU0=; b=YwVopBKsOKzStz4wqCKzz2VjixpuqcMbkDmX19R1HkG7BWxA+Qw3ucHVX4SX4CDXggHE7L 49vmb/vGAWWtKGOW7LBJd6xtDb/M/rGZQ/qHAtwaIB/dyObyfLZiBmC/iSuId0+3eVpudi NANMnTIlbCoCjZQFyNPE+pEteFdBXn0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=M5fVvBHC; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655359936; a=rsa-sha256; cv=none; b=7Fk4VFKlUutryWcbUv2OpYPeVYcuHf8nyzWPo/xEisQIz22srKYmEjf5p0af9wJEU+7T6o ifZsiTy/1xPWtxVJY83QJHYozWwvaeOg6JOJmM6QneSfvghKm7zn9YTkXDnDNYOeICk6GT MfbdxC8xuMxn/P+zBneugz94bK9XABQ= X-Stat-Signature: aof84wq8uzkcjru1d91wkigxf1a65tej X-Rspamd-Queue-Id: 9716518001E X-Rspam-User: X-Rspamd-Server: rspam05 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=M5fVvBHC; dmarc=none; spf=none (imf16.hostedemail.com: domain of BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1655359936-952311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 16, 2022 at 05:45:39AM +0000, Christophe Leroy wrote: > > +/* Note due to the way vm flags are laid out, the bits are XWR */ > > +pgprot_t protection_map[16] = { > > Was const previously, now back to non const ? Maybe due to a conflict > with linux/mm.h ? At least it should be __ro_after_init. Maybe we just need to duplicate vm_get_page_prot in all the architectures and thus avoid making protection_map global in a common header entirely. That certainly seems like the cleaner interface.