From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62BACC433EF for ; Thu, 16 Jun 2022 06:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4A406B0072; Thu, 16 Jun 2022 02:08:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA286B0073; Thu, 16 Jun 2022 02:08:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC1FD6B0074; Thu, 16 Jun 2022 02:08:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABACD6B0072 for ; Thu, 16 Jun 2022 02:08:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 71ED734B23 for ; Thu, 16 Jun 2022 06:08:29 +0000 (UTC) X-FDA: 79583069538.13.915BF85 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 577AEA002C for ; Thu, 16 Jun 2022 06:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9IlCM4qscouDgJZ0O1z3XWz1+iaMBhBno5bdb5wFRH8=; b=M8OgglVh3AX1hsPInRYzOJXos9 SuP6xskoKN4YfAz5d3S2WUsmR+vgytQC6M7HzxKyIraBfBZuYr6kF5e1QnGAE4HdzpfQuMPcp9h36 8BxfiRzAFYRduVUtPF1YLq1LSAc9Wz45p+p0ylZdIN2oA8rSrwVdEXrqIdo4Kt3oPR4ejgmxEosA0 +Iyf57annfxAa5EMyqriqPM22o6xIWyl7xgA4hH6wtXfrBdHow11TS/6Lmn/ZEAaCZHwXjp3dZwsZ WfQNrPeCfELcXAtZhNAQyagR6ogOL/VqYRVCkUhIAmaBy0gWyq1iYiuAObZ4iOWcJDrUeIFPgdI4V RxpNzhRg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1ig2-000gS2-Ji; Thu, 16 Jun 2022 06:08:22 +0000 Date: Wed, 15 Jun 2022 23:08:22 -0700 From: Christoph Hellwig To: Jan Kara Cc: LKML , Christoph Hellwig , Greg Kroah-Hartman , linux-mm@kvack.org, Suzuki K Poulose , Guenter Roeck , Alexandru Elisei Subject: Re: [PATCH] init: Initialize noop_backing_dev_info early Message-ID: References: <20220615214815.6901-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615214815.6901-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655359708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9IlCM4qscouDgJZ0O1z3XWz1+iaMBhBno5bdb5wFRH8=; b=0czE5tY+uKk8g8SNJj1/CgvEbBoM9PfdObOP4jOR6xzfn6MEFmB/2aO2t3GYwn2r3gcVTm +48buV3y0pvk3Vdh2fZ1UxbJOsBsZmBWxAD2mC6Nzg9E7Kzl0DceQ8L+LQwSlpfBS432t+ YvZvuUc8A1TQZJiNKI55jm1qvN6KyWA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=M8OgglVh; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655359708; a=rsa-sha256; cv=none; b=e7+UAmZK4YG4NJy/uYGVA2oYpHjRcH47JTZJUBUtTep7llcNx/xWiGigH66236BowUo2GP hmhmSt6SnjGgwnfXQuk1wZokiHDvq0jYHqeA5lhZf4hMVukNQMpOygIJH8esjEmiJXg/+/ aczJn8JFtjTB0ikaHwn6Zq/Wi9BDids= X-Stat-Signature: 9mdt6qqjreg5fbw9q9w7k5fraithk44d X-Rspamd-Queue-Id: 577AEA002C X-Rspam-User: X-Rspamd-Server: rspam05 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=M8OgglVh; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+c9d26d7972d0db0217a7+6871+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1655359708-422219 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote: > +extern int bdi_init(struct backing_dev_info *bdi); No need for the extern. Otherwise looks good: Reviewed-by: Christoph Hellwig And this remind me that I really want to kill noop_backing_dev_info and just use a NULL bdi for this case eventually..