From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F77C43334 for ; Thu, 16 Jun 2022 03:28:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 804DD6B0072; Wed, 15 Jun 2022 23:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B3986B0073; Wed, 15 Jun 2022 23:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6558B6B0074; Wed, 15 Jun 2022 23:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 57B636B0072 for ; Wed, 15 Jun 2022 23:28:48 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1E7A334088 for ; Thu, 16 Jun 2022 03:28:48 +0000 (UTC) X-FDA: 79582667136.10.0472460 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf31.hostedemail.com (Postfix) with ESMTP id AF5D320014 for ; Thu, 16 Jun 2022 03:28:46 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id 187so341945pfu.9 for ; Wed, 15 Jun 2022 20:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=CRNEs4vWfHi/zqEAbvBSLfQhK7itq93yjJkgH9b856k=; b=bp+qSb4nchxuHn/5omBmyxKVlhzvIagSwgOSKahCBQ5IBwm7MxAjm1Z3AiosRh0UDu Y6RNcPIgWEVd0DCdN91FtMZ5kZRzvOivWSHXIbrEc+RxSEngb2aB7tZ5xlOm8AgwDN3H +UPJFaZZyXo3X+PfRkoD78nJjQbVRIFA4nY6+sgiBmhLjgb6/TTzDevY9H+l9Gnrr2l7 RVlKniKqEOLr8WrSH+1boOd/MhbpTJf42HP/iqGEdNNeS+WUwJ2UBOL5td8sTv0cjBxA ytREFDIhmcBwNz5NayKzvxMaNa8mYtasUvdlgAl9KwFZYsiwWfBgP6N4D1qwz0ve5q4G hahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CRNEs4vWfHi/zqEAbvBSLfQhK7itq93yjJkgH9b856k=; b=CRXuQo5cJlpmV+Kaw/MWLBBzmeCwegDBA3qq0KDTvMP65P2kuA/G+7cCrdfdxySUxX wuNhxXCYSwqb+MmCZPOK7H1qeAJVNRgf/htcdov6tdTnnhkaZuzeADN3du9yrsO03nMP fyNujgz0zKoH81lcKXBD4nIpqp1tL3LHdSI7yfczjn96T21VWnQpOI7sXItGB8D5Q0jg kuoFSpty58a8zB1tNAM4lCD1b4Xkl5Rs3spQT4VifY6FSj0LH5HGWa3wVydh46f7aIAU bwp80LSBeAGRy3/0hvzA2uc2ORxhx2oWa13GtNj4u5IOjWaBJ/YIoJ4CjFaLSR3J+qk6 1Xcw== X-Gm-Message-State: AJIora8nun2uyCynzzaVlMMnWp3KLECmAK9u6sRImdKuxMgbU84+fgFU dpwa7zc/r0hM8UiZhFpNEnhh+A== X-Google-Smtp-Source: AGRyM1tLDwBdxT4hf66b3PKGa+22ZM0MVqNShnGS8pVZt2sGXi0o/yv1HiVpGPQjTxa4sfDPq0FJLQ== X-Received: by 2002:a65:6b8a:0:b0:3fc:4c06:8a8d with SMTP id d10-20020a656b8a000000b003fc4c068a8dmr2661868pgw.83.1655350125598; Wed, 15 Jun 2022 20:28:45 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id n62-20020a622741000000b0050dc7628146sm421598pfn.32.2022.06.15.20.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 20:28:45 -0700 (PDT) Date: Thu, 16 Jun 2022 11:28:40 +0800 From: Muchun Song To: Joao Martins , mike.kravetz@oracle.com, david@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net Subject: Re: [PATCH 3/6] mm: hugetlb_vmemmap: introduce the name HVO Message-ID: References: <20220613063512.17540-1-songmuchun@bytedance.com> <20220613063512.17540-4-songmuchun@bytedance.com> <41e2d762-2c0d-b13b-d6da-6e0e0e858a84@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41e2d762-2c0d-b13b-d6da-6e0e0e858a84@oracle.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655350127; a=rsa-sha256; cv=none; b=1VoElJ3m5eOXdz4NW/Vri0Ytb0/XzL7pHUn7XfFNLUHddqkXW5SGQJ8KEc+x2HN10q85Mz AHxlZouQ84nEAsx9ZsNZwXQfogyPUGHlmVl/TdYaiW32r/IEk+w9P+0onmx4qD9ZZKCixi ScJ5sRRfYsoLOy9SGDDHitSGODrXEmw= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=bp+qSb4n; spf=pass (imf31.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655350127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CRNEs4vWfHi/zqEAbvBSLfQhK7itq93yjJkgH9b856k=; b=nj84v2/+X9yf2KvqMatDyMhL1sfM8dT3grXyp7lxJveu/SOZu/Jv1Hruq0ZNAmO/CJIkpF 40yQPN2Nwv49qPWOcEXFJG/V+nPP2lQ5n89C8Y04HeGGzNBhDO/XZVtVUgwv8IQYX5dlhx aziNlL9xeym17acsS4zYhgBU96IkkA0= X-Stat-Signature: egerfn5co46bor9ae49w5aw7pu96nity X-Rspamd-Queue-Id: AF5D320014 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=bp+qSb4n; spf=pass (imf31.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655350126-557264 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 03:51:51PM +0100, Joao Martins wrote: > On 6/13/22 07:35, Muchun Song wrote: > > It it inconvenient to mention the feature of optimizing vmemmap pages associated > > with HugeTLB pages when communicating with others since there is no specific or > > abbreviated name for it when it is first introduced. Let us give it a name HVO > > (HugeTLB Vmemmap Optimization) from now. > > > > Just thought I would throw this suggestion, even though I am probably too late. > Not too late, we are still discussing the name. > I find the term "vmemmap deduplication" more self-explanatory (at least for me) > to refer to your technique ,and similarly s/optimize/dedup. Or vmemmap tail page > deduplication (too verbose maybe) because really that's what this optimization is all > about. OTOH it would slightly deviate from what maybe established now > in hugetlb code. > Well, I have looked up this word "deduplication" which refers to a method of eliminating a dataset’s redundant data. At least I agree with you "deduplication" is more expressive for my technique. So I am thinking of renaming "HVO" to "HVD ( HugeTLB Vmemmap Deduplication)". In this series (patch 6), I have renamed hugetlb_vmemmap_alloc/free to hugetlb_vmemmmap_optimize/restore. I am also thinking of replacing it to: hugetlb_vmemmmap_deduplicate vs hugetlb_vmemmmap_duplicate. Many other places in hugetlb_vmemmap.c use "optimize" word, maybe most of them do not need to be changed since "deduplication" is also a __optimization__ technique. Hi Mike and David: What your opinion on this? I want to hear some thoughts from you. THanks.