From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDA47C433EF for ; Thu, 16 Jun 2022 00:20:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A376B0074; Wed, 15 Jun 2022 20:20:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 749176B0075; Wed, 15 Jun 2022 20:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EA318D0001; Wed, 15 Jun 2022 20:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 511E46B0074 for ; Wed, 15 Jun 2022 20:20:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24DD534728 for ; Thu, 16 Jun 2022 00:20:23 +0000 (UTC) X-FDA: 79582192326.01.BA979D5 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf20.hostedemail.com (Postfix) with ESMTP id 6F6961C0093 for ; Thu, 16 Jun 2022 00:20:22 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id k12-20020a17090a404c00b001eaabc1fe5dso317162pjg.1 for ; Wed, 15 Jun 2022 17:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SkJoPGJXt4nE3myYQRLsJH7aIpj3qWs/Wi2vTnmnVyk=; b=FloPuQqtwiyreiEB0Vnz4e4crk4w0dEhNOtGAoaJ0KAXOExNkpOfZcLU3OzZZBo9FY ZbZ/qPQ7sCOFnGetw/3kLKDBxLJw8veccTwIW8CB/D/AuFUV6e6o/BNuSH/zXJFwQBZs FWMeRtXfFXAe32Vv04joUz/r25S9A2M22nDK+Cnbwr2MjgY4G4kV0lp3s//C39+qsPEx o6OE5MhLaA8F1zgGPgX+ivtQMtWhTA6nQzalCLROaKQ0Ha1Vw8ZV1si+/M855LY2rcbD EaBwvA2p3NqYoWruBjfTchE1IJSEj/RRf+RyHEigAYsEBN3X6ipSMwZl16fl+fLLjCpN F95g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SkJoPGJXt4nE3myYQRLsJH7aIpj3qWs/Wi2vTnmnVyk=; b=DlMoIjZboN4+5O9mRb7DUIZFIkXajXa9Xav3jdUtF0j2avmfptqUAHPEF+MMcFi5YJ 2uFSiO1NMGu9N2XHSoc5CwO3nVk1Hltlz9xaAtSV//vPxSHJD8M+0MBYZVJc0/rAUTT8 eSq5QMihWoWBtv0qikHpsNSWbNaURPd++xzMvIpq3UwMsa2/W69OhTdcIhSRsUJzeNY+ ikb5qvsB6TJZ1hQhXgDVye/P4lSPvNCD12Yv6SgH6MHuroxKcmsB3znHl8efZ/VkAa10 XB9Cox43i1l/Bg2gFpCVIaYlGeoF+JDuwELPWtwnx+O+v20PP5qP2eMSjWjynsscwG9i Nk1Q== X-Gm-Message-State: AJIora9gwQfLO4zV+E9eK69e6+IJc8ou7cosTuiRIGbB2R1hpDiRw65W Nl68MTz3Yhb1eilZhFxxj/McNP7Jw2Yo+m9A X-Google-Smtp-Source: AGRyM1scTZKWEcSf4G9Ym4l+MAXkk+0KSertyrXy5iHECB05ChW0eNrZNFZpkvGxTCt6onI5rdRwjA== X-Received: by 2002:a17:903:1252:b0:168:d68e:8bd9 with SMTP id u18-20020a170903125200b00168d68e8bd9mr1992368plh.141.1655338821217; Wed, 15 Jun 2022 17:20:21 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id t20-20020a17090a951400b001d903861194sm2413778pjo.30.2022.06.15.17.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 17:20:20 -0700 (PDT) Date: Wed, 15 Jun 2022 17:20:17 -0700 From: Zach O'Keefe To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, linmiaohe@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v4 PATCH 7/7] doc: proc: fix the description to THPeligible Message-ID: References: <20220615172926.546974-1-shy828301@gmail.com> <20220615172926.546974-8-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615172926.546974-8-shy828301@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655338822; a=rsa-sha256; cv=none; b=Hhhx4WzXJeqHf/8KL/YYDCETkvPd082Bp254h+XQS9poxrIMlUvJrlMtE6tTe0urJDjY2u N4dG+B2Q37f92/srRnjSDfeWbRCSwp43xCfKvIMzh8FkRdoBmETbdQQG02bRAFYt7nTIjt 7uiqhlrlmae9FR220G0O8jeQgv9g1is= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FloPuQqt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655338822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SkJoPGJXt4nE3myYQRLsJH7aIpj3qWs/Wi2vTnmnVyk=; b=Ij/ZPVrI8aA2hxGzDuH1XoRZBF5SjjGZPCf9EOwkIiYQ17PmopLDNuraxSnL6CbgIKAIUH atVspBbdCaI9b7tourMAwoziKY9fa95eJynIuywijjNYjJAtK7bTzDiLJQvXbtXY3xzeIb ZFVbnpiRUhJibzBKodA4zRbAgg0rGHg= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6F6961C0093 X-Stat-Signature: 13ppbwyp7y8oy4toq4f7jqfxxik3743x Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=FloPuQqt; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-HE-Tag: 1655338822-881468 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15 Jun 10:29, Yang Shi wrote: > The THPeligible bit shows 1 if and only if the VMA is eligible for > allocating THP and the THP is also PMD mappable. Some misaligned file > VMAs may be eligible for allocating THP but the THP can't be mapped by > PMD. Make this more explictly to avoid ambiguity. > > Signed-off-by: Yang Shi > --- > Documentation/filesystems/proc.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 1bc91fb8c321..a5e41e636a1a 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -514,8 +514,10 @@ replaced by copy-on-write) part of the underlying shmem object out on swap. > "SwapPss" shows proportional swap share of this mapping. Unlike "Swap", this > does not take into account swapped out page of underlying shmem objects. > "Locked" indicates whether the mapping is locked in memory or not. > + > "THPeligible" indicates whether the mapping is eligible for allocating THP > -pages - 1 if true, 0 otherwise. It just shows the current status. > +pages as well as the THP is PMD mappable or not - 1 if true, 0 otherwise. > +It just shows the current status. > > "VmFlags" field deserves a separate description. This member represents the > kernel flags associated with the particular virtual memory area in two letter > -- > 2.26.3 > Thanks for updating this! Reviewed-by: Zach O'Keefe