From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2552CC433EF for ; Wed, 15 Jun 2022 17:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 903046B0071; Wed, 15 Jun 2022 13:51:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B16E6B0072; Wed, 15 Jun 2022 13:51:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752C26B0074; Wed, 15 Jun 2022 13:51:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 668F96B0071 for ; Wed, 15 Jun 2022 13:51:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30371604E5 for ; Wed, 15 Jun 2022 17:51:19 +0000 (UTC) X-FDA: 79581211878.29.1A67007 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id A857A40083 for ; Wed, 15 Jun 2022 17:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655315478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HtMhpUCqpIkD63jrk6cA07RN6K+czflVLeAIk1/ZIZQ=; b=inm//HXgH90REqIX8BEAwl+j5JqRkYNG0O1vuNtkq7OahbFWcjLjr0SbKCiBtGsur0t7KK tz7AenzzdGpqDZ3GjkodeIG5uqTq08R5TKwwvFLwlATddjx57WlKyvLMwFkbCCSPhcdiXm mn51h30UXsFKD+s4Syp1n9ohkTFP3rI= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-135-DhcUdCg-NXSP8T3i-4cEyg-1; Wed, 15 Jun 2022 13:51:17 -0400 X-MC-Unique: DhcUdCg-NXSP8T3i-4cEyg-1 Received: by mail-io1-f69.google.com with SMTP id 199-20020a6b01d0000000b00669bf42cd4cso6454576iob.4 for ; Wed, 15 Jun 2022 10:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HtMhpUCqpIkD63jrk6cA07RN6K+czflVLeAIk1/ZIZQ=; b=mpeAWpKJs7yE7xkxhibXHxPzkG6eoJlsb/E/fU8BI1EZ3AEeRHqt7/AP1h8lOPDCyL mGaQXwlNfo3RF7sN07pEqiwdIPHLE5efM/y4Pe5IyEvTUstKRXTslxILvAAhOMtwm0B9 ZOgINdJFIVYUAzKmtGodgg/Uv7HVGgapJ054ISJiHV4VXbc+iLq02WzMo3Uc2xNf80X1 l6mxWvnv+Krf6UnZzrcujP8bJwf7PAqH8QiqG0qugGnccO8Mm8q7K+ogtr4cNnafup5A zgQAf1RoKZiv8L+cTsCOHrRSB1cCJ/nq0W0O7AkuGptPIqRJvXnawYhTQdDJ7fha4yrF QgjQ== X-Gm-Message-State: AJIora9N0mKaor3jL9kFV/5FxRt1gEGy3DudqC7psI6JVePmQ1bZ4xgA OITGpAUUyLzjNM1znqDVvoqTsALnG6UuBy1XuQLRK1RqUMwY+QpRW9O0OZ3vXDnW3IesHQF7hOG c9mN6F18BpZs= X-Received: by 2002:a05:6638:1301:b0:331:f2f0:a17e with SMTP id r1-20020a056638130100b00331f2f0a17emr459506jad.141.1655315476414; Wed, 15 Jun 2022 10:51:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vCFMxWhltw6eueHtpdeFczNKpggzjX1cqAIUE7MLPanSRiSr5V8MiQQmIzOwGvzB2WzRDkEA== X-Received: by 2002:a05:6638:1301:b0:331:f2f0:a17e with SMTP id r1-20020a056638130100b00331f2f0a17emr459493jad.141.1655315476235; Wed, 15 Jun 2022 10:51:16 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id y24-20020a5d9158000000b00665770bcec5sm7139527ioq.49.2022.06.15.10.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 10:51:15 -0700 (PDT) Date: Wed, 15 Jun 2022 13:51:13 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Michal Hocko , Naoya Horiguchi , James Houghton , Mina Almasry , "Aneesh Kumar K . V" , Anshuman Khandual , Paul Walmsley , Christian Borntraeger , Andrew Morton Subject: Re: [RFC PATCH 1/3] hugetlb: skip to end of PT page mapping when pte not present Message-ID: References: <20220527225849.284839-1-mike.kravetz@oracle.com> <20220527225849.284839-2-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655315478; a=rsa-sha256; cv=none; b=c2qjaZc8zvCMkuC8hocsNpxGrmGciag/AvLaTdvW8C0yPwpDB8+FZmmdrfYX6uJusJdAbF 2xbL7yN8afiggepWrQGbaQy7FCvvG6IcbbHerUplVvOFj0NJDkIAI+DsJlvQMEtnszZmDr 7Bsp49vBfHjWNkmnGx21/k8fupH+sG4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="inm//HXg"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655315478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HtMhpUCqpIkD63jrk6cA07RN6K+czflVLeAIk1/ZIZQ=; b=AHWm2OWraBF5hcOyxqXPsXRdaXubmF1fzaT6YJzwGgUJRq/5Ibl/gcvdbP8Mm87h9xoiRS RgI7nW42q6TyGbhDUbZv8uKAYHRnZjEF6cZy0g8dtJozcT+2cJ7v9xAXeL/V7unvfcwlsX bjAnpBs+H74OVRQKcpb7H9ZwS6mXdLM= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="inm//HXg"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Stat-Signature: ppfkcyirs3c6k1wr8az6xa17g38k6bw5 X-Rspamd-Queue-Id: A857A40083 X-Rspamd-Server: rspam08 X-HE-Tag: 1655315478-552373 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 10:27:25AM -0700, Mike Kravetz wrote: > In many cases, the hugetlb specific page table routines are the same as > the generic routines. But, there are a few exceptions. IMO, it would > be better to first try to cleanup and unify those routines. That would > make changes to the walker routines less invasive and easier to > maintain. I believe is other code that would benefit from such a > cleanup. Unless there are strong objections, I suggest we move forward > with the optimization here and move the cleanup and possible walker > changes to a later series. No objection on my side, thanks Mike for trying to look into it. -- Peter Xu