From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF66ECCA47A for ; Wed, 15 Jun 2022 00:19:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 507D46B0071; Tue, 14 Jun 2022 20:19:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7636B0072; Tue, 14 Jun 2022 20:19:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 357E56B0073; Tue, 14 Jun 2022 20:19:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 201E36B0071 for ; Tue, 14 Jun 2022 20:19:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id F078180B36 for ; Wed, 15 Jun 2022 00:19:57 +0000 (UTC) X-FDA: 79578562434.15.87EB6D8 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 905E81A0098 for ; Wed, 15 Jun 2022 00:19:57 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id hv24-20020a17090ae41800b001e33eebdb5dso2473112pjb.0 for ; Tue, 14 Jun 2022 17:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oMov4wFWvNmWJaOJdvhmv3NfKMweecxQ+mO9ged/+xM=; b=Po/Sow6vk85gTDqn2BkFUfKSFu9i/WK5FbqzzJtopiwGsTUiOPMMWut5wh1VbNTR6+ 8tMtGQN8DxusxWrwcnQmztQFN4R5MWX26AX1DRHspXSYNgOZ4xIvvkewPWD5Kuhx61FE dG3N/rcg4/4kMGvfh7NjfX067b5aZM6QxdS3hnkVwOY86/5659QfOyWsXfPC90WkWl1A X69jBPvalRWxnaTxB4TPLh1wHx1q/BCv+CuaT5udBVOsOHTYnnDMJd24O+tfqGQGIk+F Wk62pr4rcxtHzXRj6lTeRtrQ5Kcpg0jck8+MiMLEmoWehxkvNUt7GZ0ZULSDmxJ5asf6 HSSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oMov4wFWvNmWJaOJdvhmv3NfKMweecxQ+mO9ged/+xM=; b=t69D1MnJje3H97tz7AmSkrpBnwmlEq2PHzpQyTUwCNoS3cAMEkUC/PFGyfh5Kxnvqb h15LzXCYnNQExG8i72Qello+NuEns4O9idTaBe/zWGwLOJZshf3zvN/nMkThnjD22FAm YdfUfilkq7DOWEUgWysr6fNzzaqAjaTxsbzRVOO1C+hXw6z4akrboV6f2gJiybAPtHQn AOEj14o/Fym/ucEvbNPc7CYkNMKCNcbAE/+4ykEV/psIjL7/5Vxo8kX/ax3yTXllgmIH H/arV/J0pjqSCm1R9Q6sY7wP6xZLGJp/PzdKNFmeJiWFpScCNJF679G8h3ApnFsK4ojx k2Ag== X-Gm-Message-State: AJIora/URQ4bdpY3l800GkUnrVMES+HdjO5Gfy0oOXHyawua7ZgBjTj3 zSPg/V0BNl6KzOaOlaY36kVuFw== X-Google-Smtp-Source: AGRyM1v7s+R8tc6lXddRMbpNAieBv3aBiJ0242s3yA/5umhDQ+FLKPKWC0n6kd7x9btBboHypDTo5Q== X-Received: by 2002:a17:903:1104:b0:168:d336:cd1e with SMTP id n4-20020a170903110400b00168d336cd1emr6732257plh.72.1655252396220; Tue, 14 Jun 2022 17:19:56 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id f4-20020a62db04000000b005184fe6cc99sm8195319pfg.29.2022.06.14.17.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 17:19:55 -0700 (PDT) Date: Tue, 14 Jun 2022 17:19:51 -0700 From: Zach O'Keefe To: Miaohe Lin Cc: akpm@linux-foundation.org, aarcange@redhat.com, willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, david@redhat.com, surenb@google.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] mm/khugepaged: remove unneeded return value of khugepaged_add_pte_mapped_thp() Message-ID: References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-7-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220611084731.55155-7-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655252397; a=rsa-sha256; cv=none; b=mH0U8T1H3J3/WZiooNummwuWA1m1ekUZdJGGvrI+/dakjNDVKnoHxoHnv31UZoFWwG/zkQ KSadO3IIZYXvvy+cxMGaO2nA/9C1NIvrFHLvIpLgjuTVvhLeC9gQhRl7kVGbnjhPEb49sz ZWw2OYKYFA85yYHrkZrp/c/S+TS9Xi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655252397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oMov4wFWvNmWJaOJdvhmv3NfKMweecxQ+mO9ged/+xM=; b=uxFdTQ0Nm0JlaE6cioU6OQA86y5yahsXW9KN32bNWTvBQsDrYfpKdgy4pempwgbBZJYb77 6a0xr/0hvVfz0BVtMnWx7Dlji2zR6a3FDzx6/i9Nz9lQAK6zS0JG9NsyGkUAtoYFU0umNJ Jyl2NddsmKekIZXa25EMfKbcdnA5kT4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Po/Sow6v"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zokeefe@google.com Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Po/Sow6v"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 905E81A0098 X-Stat-Signature: 4wwyz8aydaoowcnpoxhajweik9bucmtw X-HE-Tag: 1655252397-74835 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11 Jun 16:47, Miaohe Lin wrote: > The return value of khugepaged_add_pte_mapped_thp() is always 0 and also > ignored. Remove it to clean up the code. > > Signed-off-by: Miaohe Lin > --- > mm/khugepaged.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 142e26e4bdbf..ee0a719c8be9 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1372,7 +1372,7 @@ static void collect_mm_slot(struct mm_slot *mm_slot) > * Notify khugepaged that given addr of the mm is pte-mapped THP. Then > * khugepaged should try to collapse the page table. > */ > -static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > +static void khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > unsigned long addr) Since this is a cleanup, should keep the second param aligned with opening bracket to satisfy checkpatch. Otherwise can add Reviewed-by: Zach O'Keefe > { > struct mm_slot *mm_slot; > @@ -1384,7 +1384,6 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > if (likely(mm_slot && mm_slot->nr_pte_mapped_thp < MAX_PTE_MAPPED_THP)) > mm_slot->pte_mapped_thp[mm_slot->nr_pte_mapped_thp++] = addr; > spin_unlock(&khugepaged_mm_lock); > - return 0; > } > > static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *vma, > -- > 2.23.0 > >