From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C655C433EF for ; Wed, 15 Jun 2022 00:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79E1F6B0071; Tue, 14 Jun 2022 20:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74DAD6B0072; Tue, 14 Jun 2022 20:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EE3B6B0073; Tue, 14 Jun 2022 20:13:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 508166B0071 for ; Tue, 14 Jun 2022 20:13:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 030D134B5D for ; Wed, 15 Jun 2022 00:13:34 +0000 (UTC) X-FDA: 79578546390.16.E545307 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf19.hostedemail.com (Postfix) with ESMTP id AAE611A0098 for ; Wed, 15 Jun 2022 00:13:34 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id a10so9804289pju.3 for ; Tue, 14 Jun 2022 17:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GK+RatNe7O7pymDTcdCOcSL1LPyziJES5KYjngnW3ls=; b=PNsmbrR1clGfoGvo6PaeGg0wLXoEfuHMfpDBzKrPLaLUFvR1kRZQaqNcs/7sbT+01K kdDp0sHcIAvapHzSwqM9jOR1mt8MOwQlcxf5QWfev3PocFcgqmx2n76EnUBJ8uRuB028 cX86nEKuSkyk16OdE4Nuweeip4qNvlavLfxEzTFjlgKXZPVfEv1a/xxaHE5C+Wv8eJUZ MfV0C8FN6NRSgPnQo251cOnktt8FQ/2eosg0wfEfgXwfYELiwOXl7BJsTNdbSFamBjfs biHMhicx9DLRcQmpiTcjGolXSkhz+EFzNL4UXNYubm9gSs+pFC1zLYRQgfDL+iAPirkd 0JmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GK+RatNe7O7pymDTcdCOcSL1LPyziJES5KYjngnW3ls=; b=HH5FZYLXhx0ezqQsIG/IT+VpZ7HNI6cB2EdHWTYIVScejlJR9FNHJA0WesR8gZkiXY ZrJJ2lJbA2KXL9aL9VRMNGRbnzDctlvRHXVjQh02FlufsIU752NUvCgbK2E+88e/v59p WCF8qzKpqoC6Z3Mc/UT1uSfl+r8D5tUz8fTnVrdFETIg94DfK8SJZfd8OXvtr1D4K2CY dS0NM7NyKeV0FRyWKHF9g0HbbUzJRhNaZZksAmBN7/VUQ7jb+P1fzbOdBO8hjAljCMDn hnXcbOgIHQBr7cqwD7MMG9My37D+DZKU+QnOyhjk+2GrnPZRkrQCjiJsQfJj1eIExtEm QUxA== X-Gm-Message-State: AJIora/kq66QAoAWO2OAmXe6Fj6l1dqJGbiVHqHQ38+hK4ZNjz2PtHSo Uwm5p0n82wMNBAp377Oav/GWfw== X-Google-Smtp-Source: ABdhPJxszaGJA28msG+FfNo21WuIAW9xfufswsUUxnO4OB/tFQWMQ/e5Iu4mjDLDJKL+V5vYkLvc1A== X-Received: by 2002:a17:902:8f86:b0:168:9a69:fd4c with SMTP id z6-20020a1709028f8600b001689a69fd4cmr6539782plo.141.1655252013309; Tue, 14 Jun 2022 17:13:33 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id j3-20020a170903024300b001620960f1dfsm7822937plh.198.2022.06.14.17.13.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 17:13:32 -0700 (PDT) Date: Tue, 14 Jun 2022 17:13:28 -0700 From: Zach O'Keefe To: Miaohe Lin Cc: akpm@linux-foundation.org, aarcange@redhat.com, willy@infradead.org, vbabka@suse.cz, dhowells@redhat.com, neilb@suse.de, apopple@nvidia.com, david@redhat.com, surenb@google.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check Message-ID: References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220611084731.55155-2-linmiaohe@huawei.com> ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PNsmbrR1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655252014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GK+RatNe7O7pymDTcdCOcSL1LPyziJES5KYjngnW3ls=; b=OTDIm3gIgkvAo601/K2qKsF3okwT/RflwH9anig4jBGBgRxYwsTzn/6gthNLFc1okNcs19 qwxSAfdIrUDMzS9HQ82M6JqXexNUhZ5O/jTsTEml5FBlyPaQQFi7OxbfNnNGlPT6yhtx67 fOJ120WON+wzdx04qZ7g7jrmnJ2IfFY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655252014; a=rsa-sha256; cv=none; b=RUS6Qgh6tcyiuW7RDfnQ94mSEaQe5PDlS0PFGRnoi9TOypidsol79jdjFnrls2eaYW8ZVr P+V6t3Z/njPhnVzhB2E2o/74JAl+GVQeDyCPPs+LsDAWyw0DWaoTHNy2TkZU2B2lb5igGa lUf5UMuuDv/T/+yJvZ1oWZDKZquboQE= X-Stat-Signature: qrkrhpidrtzu9qckihxy683k9t1esdn8 X-Rspamd-Queue-Id: AAE611A0098 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PNsmbrR1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam10 X-HE-Tag: 1655252014-770557 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11 Jun 16:47, Miaohe Lin wrote: > If we reach here, hugepage_vma_check() has already made sure that hugepage > is enabled for shmem. Remove this duplicated check. > > Signed-off-by: Miaohe Lin > --- > mm/khugepaged.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 476d79360101..73570dfffcec 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2153,8 +2153,6 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, > if (khugepaged_scan.address < hstart) > khugepaged_scan.address = hstart; > VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK); > - if (shmem_file(vma->vm_file) && !shmem_huge_enabled(vma)) > - goto skip; > > while (khugepaged_scan.address < hend) { > int ret; > -- > 2.23.0 > > Thanks for these cleanups, Miaohe. Reviewed-by: Zach O'Keefe