From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFAEC43334 for ; Tue, 14 Jun 2022 16:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DCDD6B0071; Tue, 14 Jun 2022 12:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08DBE6B0072; Tue, 14 Jun 2022 12:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6F616B0073; Tue, 14 Jun 2022 12:50:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D82D86B0071 for ; Tue, 14 Jun 2022 12:50:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AD67D60E21 for ; Tue, 14 Jun 2022 16:50:44 +0000 (UTC) X-FDA: 79577430408.11.54E417A Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf12.hostedemail.com (Postfix) with ESMTP id AF21C400A6 for ; Tue, 14 Jun 2022 16:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655225440; x=1686761440; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=diBqcvD7f9wLYA2SL3XAvPR/G55mENPCpsDt0PlTF+M=; b=nwQKrritNm9/R3YeBJiUGW+1cCOiNn1bTGgoKUxsbSU+ggdPBzlrXxE0 Q2DpnbafYAJ0jxI6MCka2fhweHB2O/O1ZsK7oBSKntyI8eKaJECwBeMbH HCaFAEB2ofg79ui/hw5HJqaMcWbQ8/wCotfvAVywl0bWn6+wsHQ31O+9Q mCeM3BX/My+5jJbMjTiqUVLPDT5Cypoj7riQbXsSK9mwlRJ4N/l8/99k0 HvRDLYTTH0O/ruQ3G0oAXwl43u0f7y9/UUbr4+tmueudn5gB1orSxt1SN JwKXaAr1L042nZM20DU5CbgzZ1zEdCJk3H570pEbOQ7NuEus3eSh8oKIp w==; X-IronPort-AV: E=McAfee;i="6400,9594,10378"; a="342638832" X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="342638832" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 09:50:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,300,1647327600"; d="scan'208";a="712543320" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 09:50:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1o19kL-000cbD-73; Tue, 14 Jun 2022 19:50:29 +0300 Date: Tue, 14 Jun 2022 19:50:28 +0300 From: Andy Shevchenko To: Yury Norov Cc: wang.yi59@zte.com.cn, Andrew Morton , linux-mm , linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn, wang.liang82@zte.com.cn, Liu.Jianjun3@zte.com.cn Subject: Re: [PATCH] bitmap: fix a unproper remap when mpol_rebind_nodemask() Message-ID: References: <202206141145339651323@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655225444; a=rsa-sha256; cv=none; b=SHFeXpyp9uGj717FLbHfFby5HRVCEQDNDrRPFuJtQQFeNZl18JS3e+TncNCrvscP0KvG45 tcmRn85mLLei9fUbYBnerUNCXU36iYiCaqeqMzNDurKvcd94un0+LEK7AW/n6bws+iIq9b 8CNCWXXCwL6ZHGdN+OJQY1ogZjTu5w4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nwQKrrit; spf=none (imf12.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655225444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=koFtYCobfnBiqq5CIKkno0UBtfADsb4OCPCbxyJtres=; b=JAc2caKSSPKJoVuWCEI9AElEylds5ul5pEsd9pu7WmZtIdBJfOxT/cROrQlSZPN6lHfPIA 9j8BqqXt1z8zZFpq3ProuSLBG+EwSklV3HfWmoFi9et9pIcNPNBJ7ZK43YjPb2deW98W8l ANFAOxsEDbsIAckPnotpH4X8l2P/XTE= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: AF21C400A6 X-Stat-Signature: pz9do8woay6g5jcwwuyseckxg1hg1upj Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=nwQKrrit; spf=none (imf12.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1655225440-594293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 14, 2022 at 09:40:08AM -0700, Yury Norov wrote: > On Mon, Jun 13, 2022 at 8:45 PM wrote: > > > On Mon, Jun 13, 2022 at 4:31 AM Yi Wang wrote: ... > > > Anyways, as per name, bitmap_remap() is intended to change bit > > > positions, and it doesn't look wrong if it does so. Haven't read the discussion in full, but saw the function here and my 2 cents are the following: 1) if we don't have tests for bitmap_remap() / bitmap_bitremap(), we should; 2) these functions are used at least in one GPIO driver, so it would be nice to not touch them if they are not broken (see 1 above). -- With Best Regards, Andy Shevchenko