From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07122C433EF for ; Tue, 14 Jun 2022 07:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92F738D0223; Tue, 14 Jun 2022 03:23:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B8556B00ED; Tue, 14 Jun 2022 03:23:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731498D0223; Tue, 14 Jun 2022 03:23:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5F5ED6B00E9 for ; Tue, 14 Jun 2022 03:23:59 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 35704357F6 for ; Tue, 14 Jun 2022 07:23:59 +0000 (UTC) X-FDA: 79576002198.20.3CA23ED Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf31.hostedemail.com (Postfix) with ESMTP id DEC41200AE for ; Tue, 14 Jun 2022 07:23:58 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id h7so5960616ila.10 for ; Tue, 14 Jun 2022 00:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WgsPByWFwvmxTN6GW/uMi6kC/eCqUxKkzQvH+8GjA0Q=; b=NpIAuWM0RbO9xoxmZjSOjTmrkmHw9aJ0t4AZ/Wbpsg6xH7ArIvcbtmqUcBM5cUbKHH 5xqRXIZ27/l9KZtdtnpcqsycUrnqML4JuLEVmW6jeC73ec1QkNGGkqtwAt07d27DVnpX 0MvW5YY5H66m65onie1kxC12c+WNiv9Y7+mZUBkFFCgg2cqzs5dKfw4Kjs43vqnFJpI3 pWOAgAG0h61eBIpprpOLGscaRiEgzhbIeiTYzm/S+llD55TjkYAiJGOzt1OmwCNPzoCJ bpnCWmI05A8hdqBzIhwhLALelmCucxBQt4yDdO3Z1DjHHolziDMEzep2UbwmCO7kzO5D ToxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WgsPByWFwvmxTN6GW/uMi6kC/eCqUxKkzQvH+8GjA0Q=; b=r5w+baqWTRTiO1nyWE98Ura5QDbadPzo82bztNIfllBqhiH8xFRUKKNlukIlh0zuDU cXbiXW2Ksbalj2IlDsAj395jqkH8bGSUvT7AlNSKOGVspuCLdN8Ux1dQJp1+foZb5K9g wqgauUPw7R9/6rzPriR6o2uO+KXCUgW0fjPHVdT4OwQcqpdljQSiT7LFSz2CzqceDBYF jhzIKMDKVzkVa3IEi7UgvcB6OHMHs6pExB3tQwTo/oL9J7cSYHpm0KNWpHsRQidcIPKX 2cXjTSsxgXvnNbBWVAqneR5A9C9SL5w7Fn69x8VC5NnARQZRLaMNYGL3C9yQqppMyFbN E+Ig== X-Gm-Message-State: AJIora9BzdLhw0CHh7pHpNYJE7ed5IB/SrznefFG7VA0SLfGoj4YDygV Hhtrc4/PoSzHk/8vAlbnzkYQBQ== X-Google-Smtp-Source: AGRyM1tTdAgY4KPZSG2TLNgC428eedn0ZcqHWQI+CM35U4PQPM8vuUi36BqDkOW7JRkwKXukuMZr/g== X-Received: by 2002:a92:504:0:b0:2d6:5aff:82ad with SMTP id q4-20020a920504000000b002d65aff82admr2153215ile.3.1655191437980; Tue, 14 Jun 2022 00:23:57 -0700 (PDT) Received: from google.com ([2620:15c:183:200:eaa7:1f3f:e74a:2a26]) by smtp.gmail.com with ESMTPSA id f8-20020a02cac8000000b00331d411da60sm4544641jap.75.2022.06.14.00.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 00:23:57 -0700 (PDT) Date: Tue, 14 Jun 2022 01:23:52 -0600 From: Yu Zhao To: Andrew Morton Cc: Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, page-reclaim@google.com, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v12 08/14] mm: multi-gen LRU: support page table walks Message-ID: References: <20220614071650.206064-1-yuzhao@google.com> <20220614071650.206064-9-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614071650.206064-9-yuzhao@google.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655191438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WgsPByWFwvmxTN6GW/uMi6kC/eCqUxKkzQvH+8GjA0Q=; b=IdS3NvgYyU+mxhvUSnzVX0Fwj7oMW/5c85BVTx4C1aKIn4IgXoDrTualQLh0Doj/2Nd26Y 1Q6jyersl3yw1TO8ku8jNdejqg46yG5s0apM3bHir03IHqcINVogJ2ZErigedaLzjYwBxR GpQzQHsk5tLyddBqDYUKCkZFZN0gShc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655191438; a=rsa-sha256; cv=none; b=eGapUz4tmlEM45L4JiVgxWniOKaKdtwU4sEtefidV60bm+xR+PEcZ25BSr22gAxsszcjoA +o0VqzL+priSmyF+DEcw5R+OcJfgKlmP1agiqGDdLBmDc0fP5FF5dVli22yyqoEoTkm5UZ nedy5f9AnZDYKD3rHMK90QkJixS4aqA= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NpIAuWM0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=yuzhao@google.com Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NpIAuWM0; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf31.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=yuzhao@google.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: k1b6hqtt7k9weoikim5wh74id9j39pn4 X-Rspamd-Queue-Id: DEC41200AE X-HE-Tag: 1655191438-812819 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 14, 2022 at 01:16:45AM -0600, Yu Zhao wrote: > +static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk *args, > + unsigned long *vm_start, unsigned long *vm_end) > +{ > + unsigned long start = round_up(*vm_end, size); > + unsigned long end = (start | ~mask) + 1; > + > + VM_WARN_ON_ONCE(mask & size); > + VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); > + > + while (args->vma) { > + if (start >= args->vma->vm_end) { > + args->vma = args->vma->vm_next; > + continue; > + } > + > + if (end && end <= args->vma->vm_start) > + return false; > + > + if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) { > + args->vma = args->vma->vm_next; > + continue; > + } > + > + *vm_start = max(start, args->vma->vm_start); > + *vm_end = min(end - 1, args->vma->vm_end - 1) + 1; > + > + return true; > + } > + > + return false; > +} Andrew, The above function has a conflict with Maple Tree. Please use the following fix-up if you apply MGLRU on top of Maple Tree. Thanks. diff --git a/mm/vmscan.c b/mm/vmscan.c index 69a52aae1e03..05e62948e365 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3749,23 +3749,14 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk { unsigned long start = round_up(*vm_end, size); unsigned long end = (start | ~mask) + 1; + VMA_ITERATOR(vmi, args->mm, start); VM_WARN_ON_ONCE(mask & size); VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); - while (args->vma) { - if (start >= args->vma->vm_end) { - args->vma = args->vma->vm_next; + for_each_vma_range(vmi, args->vma, end) { + if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) continue; - } - - if (end && end <= args->vma->vm_start) - return false; - - if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) { - args->vma = args->vma->vm_next; - continue; - } *vm_start = max(start, args->vma->vm_start); *vm_end = min(end - 1, args->vma->vm_end - 1) + 1;