From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68683C433EF for ; Tue, 14 Jun 2022 07:57:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93C698D0226; Tue, 14 Jun 2022 03:57:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EBD26B00ED; Tue, 14 Jun 2022 03:57:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB048D0226; Tue, 14 Jun 2022 03:57:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6FA196B00E6 for ; Tue, 14 Jun 2022 03:57:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 2A61F121337 for ; Tue, 14 Jun 2022 07:57:09 +0000 (UTC) X-FDA: 79576085778.01.AC3CDD4 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by imf21.hostedemail.com (Postfix) with ESMTP id C40A61C00C9 for ; Tue, 14 Jun 2022 07:53:02 +0000 (UTC) Date: Tue, 14 Jun 2022 15:52:48 +0800 From: Yixun Lan To: tjytimi Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: avoid some repeat when add new range Message-ID: References: <20220609024122.6679-1-tjytimi@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609024122.6679-1-tjytimi@163.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655193184; a=rsa-sha256; cv=none; b=wtQma4TWR6NZM0YhAvHQcZYJNRhT/yw0nXgkT8O/ZcHvT9jm3lB3YCV15zjBgrsfCBlgUj fo+FVb9AMW2/WSNzmAtRu4d2D640dEdmYrU2kT7YO/4OyMMKT2g6d08ZjUlkU9Bxlf9MJi TxZwMJvto0zcAagU48hpbmJuDBflm/k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of dlan@gentoo.org designates 140.211.166.183 as permitted sender) smtp.mailfrom=dlan@gentoo.org; dmarc=pass (policy=none) header.from=gentoo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655193184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UvrxaRhhhLleS2coheY6zUyurZeEXi35BZeBQqc0VWc=; b=N1pKFd00pJsUuS2to7sVUdAohp13jJL3ddh53+Pg5+CgTSP6SxxkddsqRQfM2SidPBl9pZ 5U9Q7ToT++UxBszFhqqhAdQX2GmX9Sog3PUDEl+WxCBD5AXw+4HM5mf2XpFPqUdh57xkZ4 9HapXyc+LAI6h1RWAY5sWWkxv4HI2AM= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C40A61C00C9 X-Stat-Signature: wiw6eb97qgxyfyktnn5e1hfmx1d7hf7k Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of dlan@gentoo.org designates 140.211.166.183 as permitted sender) smtp.mailfrom=dlan@gentoo.org; dmarc=pass (policy=none) header.from=gentoo.org X-HE-Tag: 1655193182-913669 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10:41 Thu 09 Jun , tjytimi wrote: > The worst case is that the new memory range overlaps all existing > regions,which need type->cnt + 1 free area of struct memblock_region. > So if type->cnt + 1 + type->cnt is less than type->max,we can insert > regions directly.And becase of merge operation in the end of function, > tpye->cnt increase slowly for many cases.So this patch can avoid > unnecessary repeat for many cases when add new memory range. > > Signed-off-by: tjytimi Can you fix the author/signed-off tag with your real legal name? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v4.18#n460 > --- > mm/memblock.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index e4f03a6e8..243cd7de5 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -602,6 +602,9 @@ static int __init_memblock memblock_add_range(struct memblock_type *type, > base = obase; > nr_new = 0; > > + if (type->cnt<<1 < type->max - 1) > + insert = true; > + > for_each_memblock_type(idx, type, rgn) { > phys_addr_t rbase = rgn->base; > phys_addr_t rend = rbase + rgn->size; > -- > 2.32.0 > -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55