From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8B7C433EF for ; Tue, 14 Jun 2022 03:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96FB38D0203; Mon, 13 Jun 2022 23:17:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91C848D01EE; Mon, 13 Jun 2022 23:17:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E39C8D0203; Mon, 13 Jun 2022 23:17:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 705978D01EE for ; Mon, 13 Jun 2022 23:17:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44BAC3546E for ; Tue, 14 Jun 2022 03:17:56 +0000 (UTC) X-FDA: 79575382152.26.7B6D0C4 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf02.hostedemail.com (Postfix) with ESMTP id B7FBB8009B for ; Tue, 14 Jun 2022 03:17:55 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id d129so7323794pgc.9 for ; Mon, 13 Jun 2022 20:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=1qN6OyaRDLN8PZ+93yGw5yJBTOUHt5MGOB2eLLMCogI=; b=cMrFBCIPYz7c80i80c0FXtORHnLG3GjW5yZlTVd2mKvLYcPe0tAzISoqrP9Qf8Wp9P Vh+8L1urE9XjyjN7IL/1+2MpLTRg5IgOhE4SM5v7WFYnMjrHfWq2l0MA5S/sMwfUVby+ MthRAqvCngQMPtChLRHFvH1lUi6pCGnOTZ33tgSGP+2+KMPfPCgON4M1TEhaPy4fsK9Z 6pI7amuFqIGdzrI/3jxo7sSNAtoRzXlE9myGq5ybu6n5RkLEFzZlh8Q5QGJIdBR8PFGE FEQFtG2zRLxfEGM4itilu61zxTjT8YQqLw3fDNXFt+nwu+JgzMdctjpOq3RErTCHk//f pHng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=1qN6OyaRDLN8PZ+93yGw5yJBTOUHt5MGOB2eLLMCogI=; b=Ryi6dUUQzrjBUzVSevXfuGmIFDVtMyypkBzYtMzcgwIfmDZx0lzHsgH8oN7MAtWoSp GfvcUx7uQyS1lIjJtjBh79gZupi0DY0pGu6slG6pjmVuMjdKLYZFt826WcRB9UMdmeIB BC4LvfbMT7fxNV2ReHM2xaer/1NPvogSfb7IgkvrzlxT6NO/Vlg3ZifwyM5964RUwhXR YL6YHvG37gDykg91jTEzAOY/iWYQexkD87riVhOs1TNxi8hVrrT2lT558P8AQaiLmdx0 jBq1NTpu7fH5SLC41H1UadeCVOtdyJMBuDBp+nBmaV40e6GQAnwTJmVIL2EUKBkjK8mv NGvA== X-Gm-Message-State: AOAM533TsHlAxHgpiPurtaXeq+fzseVoKbQ/JpiADvXxyFVPGJsXVoI/ 29GNz04EcVAR/L52+Dfs/p2S7g== X-Google-Smtp-Source: ABdhPJybAwFxTDtuR72OKzjrJeDCMIasDLrfdWXowpUEhQqNagPhQ2nRpzBgl2V57Ds6ZcIjEDwFfA== X-Received: by 2002:a05:6a00:1350:b0:51c:26d2:9ce5 with SMTP id k16-20020a056a00135000b0051c26d29ce5mr2493957pfu.69.1655176674581; Mon, 13 Jun 2022 20:17:54 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id g13-20020a170902d1cd00b0016767ff327dsm5868146plb.129.2022.06.13.20.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 20:17:54 -0700 (PDT) Date: Tue, 14 Jun 2022 11:17:51 +0800 From: Muchun Song To: Mike Kravetz Cc: david@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 3/6] mm: hugetlb_vmemmap: introduce the name HVO Message-ID: References: <20220613063512.17540-1-songmuchun@bytedance.com> <20220613063512.17540-4-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655176676; a=rsa-sha256; cv=none; b=5odhALqw0pC1OVKfqDfj4x+/JFBG/nUu+VtSZTCw1Romxo2d7dXrJfaqRP9+9NVe/jCUHP ywgWfov6V+jlg6xBNLLdVZvNB8EHXg9VMbixOciPqSyLE8vEGSniNbBywUc3XXWqz35tzD B0ZPX7eMPe4ox4airZLOGbmMJp/oFRA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=cMrFBCIP; spf=pass (imf02.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655176676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1qN6OyaRDLN8PZ+93yGw5yJBTOUHt5MGOB2eLLMCogI=; b=rYe8RzON6vOanV7HJ5zKxK36veOIKn4ailNcJa67cV9A2hqtTNrVRA7clU7efjVzOIRy1I o22JCyrF9/sNMygmRsYcrEndIX6nbtreOwV5yAwN05cJe1geV5cw8vrxUAz+ID8agOLwMu OnKBLX737w/UU90F3LqMYYhLRwT03BY= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B7FBB8009B X-Stat-Signature: jyi35u3cpknitgt8o9w371y5i3cfof6c Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=cMrFBCIP; spf=pass (imf02.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1655176675-677539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 02:19:45PM -0700, Mike Kravetz wrote: > On Mon, Jun 13, 2022 at 02:35:09PM +0800”, Muchun Song wrote: > > It it inconvenient to mention the feature of optimizing vmemmap pages associated > > with HugeTLB pages when communicating with others since there is no specific or > > abbreviated name for it when it is first introduced. Let us give it a name HVO > > (HugeTLB Vmemmap Optimization) from now. > > > > This commit also updates the document about "hugetlb_free_vmemmap" by the way > > discussed in thread [1]. > > > > Link: https://lore.kernel.org/all/21aae898-d54d-cc4b-a11f-1bb7fddcfffa@redhat.com/ [1] > > Signed-off-by: Muchun Song > > --- > > > diff --git a/Documentation/admin-guide/mm/hugetlbpage.rst b/Documentation/admin-guide/mm/hugetlbpage.rst > > index a90330d0a837..64e0d5c512e7 100644 > > --- a/Documentation/admin-guide/mm/hugetlbpage.rst > > +++ b/Documentation/admin-guide/mm/hugetlbpage.rst > > @@ -164,8 +164,7 @@ default_hugepagesz > > will all result in 256 2M huge pages being allocated. Valid default > > huge page size is architecture dependent. > > hugetlb_free_vmemmap > > - When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set, this enables optimizing > > - unused vmemmap pages associated with each HugeTLB page. > > + When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set, this enables HVO. > > I think we need to define HVO before using it here. Readers may be able > to determine the meaning, but to be sure I would suggest: > Agree. > When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set this enables > HugeTLB Vmemmap Optimization (HVO). > I would use this. Thanks. > Everything else looks good to me. > Reviewed-by: Mike Kravetz Thanks for your review.