From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25B2C433EF for ; Mon, 13 Jun 2022 18:30:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06EEB8D01B6; Mon, 13 Jun 2022 14:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E248D01A1; Mon, 13 Jun 2022 14:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E280E8D01B6; Mon, 13 Jun 2022 14:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D2FB48D01A1 for ; Mon, 13 Jun 2022 14:30:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 98BEFE49 for ; Mon, 13 Jun 2022 18:30:43 +0000 (UTC) X-FDA: 79574053566.02.6F37D20 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf31.hostedemail.com (Postfix) with ESMTP id A257E200BD for ; Mon, 13 Jun 2022 18:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bL3US9PMAaILRk1isUycCjQ1+xOW1BhBiqmFRKRzJTk=; b=JV/59Mkt+B84K2gNKvaE9h9YwE waM22vtujbvcADQoM/J+jtmTp/mDBLFD3BKUUpOrEyFUjODTUBw40+HczJspjAy2y61fSmnfZGgr0 52F9r9cLwFDUDlXVI/kpHXFVVqSVT6KXKRrf3Om/2gIW+aExuewuG0X6Abvobn2/wALA0UnwrNUVW M83hvAT8vvt3GdruP7sU/Sx4jqHsGnHuA7yNgD8mXJ+sRVn40uk0x2LjzZLNHQ2VCCGw2wmmWBO0O gIjSwsD3+ax2TtI8nAyP63BykerwHuyIzWhF5MzfufIECrmpivy1RcoG5cGfLYihwQ13pvjajefip vRelHLrQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0opS-00H4VK-Qq; Mon, 13 Jun 2022 18:30:22 +0000 Date: Mon, 13 Jun 2022 19:30:22 +0100 From: Matthew Wilcox To: Mike Kravetz Cc: linux-man@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Muchun Song , Naoya Horiguchi , Axel Rasmussen , Dave Hansen , Michal Hocko , Andrew Morton Subject: Re: [PATCH] hugetlbfs: zero partial pages during fallocate hole punch Message-ID: References: <20220613180858.15933-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613180858.15933-1-mike.kravetz@oracle.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655145042; a=rsa-sha256; cv=none; b=m837n6s7nvMNTgSGgUnboaGtsG5CUZR426ahhppRvOONq7U00spbDuZ0oiPklSJ8xs0ZM0 WcCRpm17qAAW2TYKHqbGz4+Ex+rHOl0rfRypRrfxcenG2+TT4AGrSvTs4RlIJyExZ9TXba 5vdZCQN8EqPAHoz5hPKxK5U7e1ze5Zc= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="JV/59Mkt"; dmarc=none; spf=none (imf31.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655145042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bL3US9PMAaILRk1isUycCjQ1+xOW1BhBiqmFRKRzJTk=; b=dO6Qa3MeBm3KoUWekluykoGLDq54rqqxpPEUHg0lWgUK5VlUarsknbm/brQ3ox6Bi1DmKv Q+blcVLJNKXY1uHipk84BuHPutsodjeyoHEWFXQj9dzHzUE/bn6liWCxRji3rVAh0sghab uDsD/tXKyviRVEDtm0W/Ikt+W/8IgDw= X-Rspamd-Queue-Id: A257E200BD X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="JV/59Mkt"; dmarc=none; spf=none (imf31.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam06 X-Stat-Signature: eifbcwzqjzucd1173sp38awwo44abdhf X-HE-Tag: 1655145042-113412 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 11:08:58AM -0700, Mike Kravetz wrote: > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index eca1d0fabd7e..b0d0947a7e9b 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -584,41 +584,79 @@ static void hugetlb_vmtruncate(struct inode *inode, loff_t offset) > remove_inode_hugepages(inode, offset, LLONG_MAX); > } > > +static void hugetlbfs_zero_partial_page(struct hstate *h, > + struct address_space *mapping, > + unsigned long start, This should be loff_t. Otherwise we can truncate on 32-bit machines. > + unsigned long end) > +{ > + pgoff_t idx = start >> huge_page_shift(h); > + struct page *page; > + > + page = find_lock_page(mapping, idx); > + if (!page) > + return; > + > + start = start & ~huge_page_mask(h); > + end = end & ~huge_page_mask(h); > + if (!end) > + end = huge_page_size(h); > + > + zero_user_segment(page, (unsigned int)start, (unsigned int)end); > + > + unlock_page(page); > + put_page(page); We haven't started converting hugetlbfs to folios yet, but here's how that would look (which will save us converting it later): folio = filemap_lock_folio(mapping, idx); if (!folio) return; ... folio_zero_segment(folio, start, end); folio_unlock(folio); folio_put(folio); Pretty much a 1-for-1 replacement.