From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6378C43334 for ; Mon, 13 Jun 2022 16:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DABA18D01A3; Mon, 13 Jun 2022 12:16:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5ADC8D01A1; Mon, 13 Jun 2022 12:16:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD3A8D01A3; Mon, 13 Jun 2022 12:16:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A93858D01A1 for ; Mon, 13 Jun 2022 12:16:50 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6BB3020CB3 for ; Mon, 13 Jun 2022 16:16:50 +0000 (UTC) X-FDA: 79573716180.17.4466944 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf02.hostedemail.com (Postfix) with ESMTP id 83315800AA for ; Mon, 13 Jun 2022 16:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655137009; x=1686673009; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Q03VEoc5MNS4PxJVkJNGtQifuU3RXSsSLPUiX8TLnHc=; b=SKcDblFfOWxv4w7QBJA5cmk0QdcuWdoTxFbxw5TJolJsqj+I98EtAQsd N7O9GRkgbo5bwtliKMz7G03WPnE9oZFoSuyC0S0hFa/cS4xBndWLfSIr3 p9ixdeLb43phv20YWGhub5a//1JTqMdnlunSRbcU4V+NKx3257PNw9g96 op9Du1smr/8O74CntyK76vAv4NjSdpQ0Rz2N7h9TGtiM+r4qazGxnE0ml IVCJR2jORxJiumJUJ4r+KCn3ZkNv/0tdmK7EseOBVfSGhtfWccyx70cTw wrEV8XOSQovAz7/RmeeTQQ2AN1g9eW/TJwG9kwMP6IQXi/UOUlNHsRPQx g==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="261371030" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="261371030" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 09:16:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="568098463" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 13 Jun 2022 09:16:08 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 13 Jun 2022 09:16:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 13 Jun 2022 09:16:08 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 13 Jun 2022 09:16:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpEdCQg1llJC1d+dpRSM3OHVoFrzQ/O8FENRDrIKCOVHj0XyYO2WYvzIHPFuybP9AEiMfYDiUbdkrGdBxabXaVRIr4DTGjI/nreUqLm+CooSUAvu5EAawzOL+DCfBv6M/rd4doO+VIPT9opDIGqKC0+QicznJ2qyJ8ReWfFHRE6cYBl82Akj+4Z+EievAF5vKUJd3+kiFpXBOIlZLbgHzltw10kASuPbG+vJfADZJKX73qAXtA2vUTQekNN4NU1y0rOe3506wI6h1ZYcu32ZqlmQUTZ/q3DCTdLkeJEpK6oaTFbG2VM0W9uyPkJl4c90Lt7a6XH1xrpqoShpbCKBeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FaKKrPF5MtbKacJrZJxKpvigdXx5rxsoodWNbzvU2Gs=; b=Yehsx50H4H+ehvGRCgJYKrEHZ90k1vyNCh+tocOaZZ8NipZsGXTdixnF/QQNRPF6WOgvnnKE6dIS+VcGS6P3FD5PMxqdADEuSW3PnDyZ76SOXgTWw4FvlLsPrERB6JXl+6tJDcLlzzx/+UMq4TJ+kcQshP3AgG4tdvI+mG4ZH+CCBSIY3OuTNJ0qjaOneHOK69Etd7JbSZy5PFUkJMXo3FGZuKZP0Nqx/cC3ugvdJl8UcX+pmrTdCoL8YerkC/bETOUgJjAh3PPB0BPRMyxu66a2Yf7YBTxiHkex9u1PSOxfPLcMohcHeapw7wnIZM0/SpXKLZKOh/A63zSro9ud2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB6311.namprd11.prod.outlook.com (2603:10b6:8:a6::21) by MW3PR11MB4762.namprd11.prod.outlook.com (2603:10b6:303:5d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Mon, 13 Jun 2022 16:16:05 +0000 Received: from DM4PR11MB6311.namprd11.prod.outlook.com ([fe80::d4e9:9ae1:29b2:90c]) by DM4PR11MB6311.namprd11.prod.outlook.com ([fe80::d4e9:9ae1:29b2:90c%5]) with mapi id 15.20.5332.020; Mon, 13 Jun 2022 16:16:05 +0000 Date: Mon, 13 Jun 2022 09:16:01 -0700 From: Ira Weiny To: Christophe Leroy CC: "linux-api@vger.kernel.org" , "x86@kernel.org" , "Aneesh Kumar K . V" , "Dave Hansen" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , "Sohil Mehta" Subject: Re: [RFC PATCH 6/6] pkeys: Change mm_pkey_free() to void Message-ID: References: <20220610233533.3649584-1-ira.weiny@intel.com> <20220610233533.3649584-7-ira.weiny@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: SJ0PR13CA0183.namprd13.prod.outlook.com (2603:10b6:a03:2c3::8) To DM4PR11MB6311.namprd11.prod.outlook.com (2603:10b6:8:a6::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fccd6a2-2e3a-4f8f-85c7-08da4d58049a X-MS-TrafficTypeDiagnostic: MW3PR11MB4762:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jzHV700DCwVcve2+B/cjOh19o7+eb4GGsAJRvDDosWPBgs8UH/+c+/Hwv7jP50cVwRmpzT3XjGIHFrgCuUwBVAKsMYcyGxSxrxNN8l6GW4GgJc+4dQBwvvRZa4BNvLIQioMKUNLnzzA2L/jNtMrOz8IwmYoM7Hh/8/RUZaVUL7zQCqLRuR7Y3tyVPK4nRp/khjLrL2uC7lKeaNBMqtknN2xmIxPWVzBvU7GwLcA48ekI9sXW+Cu0cSqX43+hgdEiMctCitxlPfplgq/OetOuR5Y94TmWWu4ZrbgcT3qgk4rvvFPjwOeuILlLk5Q7NJqDk58urmsG1FGkDrQgu20CXF859RaY+LDBH+51qmxS/tqUB29Rec3HIQcKWPtW8HXhcrzGHxSfMdpMB77CTVTvbyb6By5N1LprLEnGUl7RaDPhqEBrt+s9NdlViOWt1wXT+1MIj+R3FvED4pBoIsCALm22FWGZBvn44Mb+hE8bNB7L3JRDUBnHA5/ju73O2i6eWOYG+sUC4taPA8gCaoGCsDWKPG7Aa8XSMFRsoczEZGuMc7zb//8DqJSSP9g6ZlUOD0Q049fsWpefN7DkNc7Qpw6JyZJ7AqInDBB3tm/gMejAauf1sV3+Na/QxPABhHn2Cu0Y8O335RRBdKLznwsvHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6311.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(366004)(26005)(86362001)(6506007)(6916009)(6666004)(6486002)(33716001)(8936002)(2906002)(8676002)(38100700002)(66556008)(66476007)(54906003)(4326008)(66946007)(66574015)(82960400001)(316002)(44832011)(6512007)(9686003)(186003)(83380400001)(508600001)(5660300002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?J5o6WREwYcXVpo0ra4wv4TX7gWep/6nRK6KlvonYFK1zUPSaWh7sBw7Ou6?= =?iso-8859-1?Q?UaR0JHAEO6nAZAOo5U5mlD+CwXHQkXwac92rkiopygUlo8m14oEr/Oja1o?= =?iso-8859-1?Q?QivF9abJbRfG5h3a/tzNHqpdvsNeyVtFo+3eVEpu8ztoOseCPR/h4sMgpW?= =?iso-8859-1?Q?K0G7fzk4xY7WNPvBFNLEmiT0b5UZ7+XDhJv+evF85DaxFnGSBU4I6I1igL?= =?iso-8859-1?Q?wCJABMtO5zPpukwevrPxAEDjcrdlr6IXIjkCTHAoFkkH7awILTfuoq2IdP?= =?iso-8859-1?Q?lFBas2QoydNc3Jx/oQN5aukU0AFvv+qi4tDqRIyWFz/BX/rUHYrOcN74Fk?= =?iso-8859-1?Q?ewIJCP4XX5hq60pZv8BWYYySWmQlZKqACDetr0Xim4LlhPNb81VD1vMs+3?= =?iso-8859-1?Q?bAfj4THUM1dcFfO5DcRH50ucfVvJXjk3fKspOj478pEkEIa944SJnCceAq?= =?iso-8859-1?Q?dK7igC1eNkU5H4s+fhXScwD+Mt9OkqyHY8cEuWkE6cubKou0LtNa19rh+W?= =?iso-8859-1?Q?VNSUdaMuPs73GNuA3Ujy3gzn/fjCmQGfL3fIE9xqhbqv+daWuJ20f4hQxh?= =?iso-8859-1?Q?/XRgjOoavkdrzOxJWOvSTjBtmogoC77EGU9PjfYSBvHocnlCsl0pZwLoDg?= =?iso-8859-1?Q?Sop8fIT02oWWOw2raCW3a7hqdD0EDjam+k6/K+ur77ThQ4qmnV5D8nfGXo?= =?iso-8859-1?Q?EC+4OakN6In69DLosTiJ7bVeyvaD7FzaA+/dHjY3vzvdmqRHFRHFUbDHC9?= =?iso-8859-1?Q?1IAmRi9dCs1XUEbpI7x5U/UCbjWrE2LsGZ2EkRgFP9ApfrwvEb0JWBF5gL?= =?iso-8859-1?Q?5M6SW5H6wGJEdjqXRZ3AGMYSRUs3ZY+J0VRVWkas7l6xYSK8nFvioBIPTX?= =?iso-8859-1?Q?5tHbuIa827/kRY02imoxXyDHSYLfM1kHYlAyKDysUQwgLHhQ7M7M07ejtK?= =?iso-8859-1?Q?tVcpegLm3DXQFc0UDa5CnnhJfrrdZszMWRJYMAisc1Dm5jzSOUXlWCcyGw?= =?iso-8859-1?Q?nfOY3MWnmhRUtAcNVUoCJr0lJItVijO0bkWILPYchGjDsocQEkFMRh0zeH?= =?iso-8859-1?Q?nvFhS+THpTEYZkjor8Tj2XKnWxwGCNJGi8csEN+0OtY4bnairTUCJY/Tvj?= =?iso-8859-1?Q?wIop42kuXjxG6QXDVgHHGfNMPGx1en6dq/Geo7sik/C3vBJilBo1GGLm18?= =?iso-8859-1?Q?+xExeAYyphQPqoMITVfhn41p2m2ColvJvVSfvC3c6O1BNqGRPAatUOHuMs?= =?iso-8859-1?Q?/CqLe14qPsoyTT+xSnSlytgBMqWtBYsQKVFfP5FmRIXnXU0um+2YPAfrS1?= =?iso-8859-1?Q?siYc4fMwTeDc9ycQCY4YwHKWCTQa/Gz6O6eMLEydAQ2+s53eAbLwMniP7m?= =?iso-8859-1?Q?kTHkDRV6eA27qLgJ/Fp1En5PwYdOxNneEgWhbZnSGGKAlsUpXZgz7GIGNp?= =?iso-8859-1?Q?Fy8Kv7Lww2inivyNcESG5BPWnmKMez4Sd8ZhljZgIbTH6GYLGw/NYl0T2O?= =?iso-8859-1?Q?brb5ObjcdC4b8IapgtkRBL1bgK4kGuu7jYAwzbPbVa19fSavjezxBEo1CO?= =?iso-8859-1?Q?YEFOFfynaltueSp0DNZnKy23nMxbWSdU4LrC3HFFz7v2m8UQGukfKAH1KP?= =?iso-8859-1?Q?FrOINgzlsakr2PSl1kjSH9Gxr7IjbF/3bEMcpZU4/vm4PC2L70KPntNgBb?= =?iso-8859-1?Q?I4Gy3eFWjsIw7XP0164TFLstzYGHUCACLorIs+F2DOZOnYMlv+sjm3SVOV?= =?iso-8859-1?Q?bz7YLVdttVxzCcOEpG9PDRrfRa5oKVdfOus2tJP7Hq7DF9g4A29FjYwQKp?= =?iso-8859-1?Q?ZCx4FpI8Bw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8fccd6a2-2e3a-4f8f-85c7-08da4d58049a X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 16:16:05.7292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t8gtuFI0cEQ/shvEQjiniZ0Nd1G0z8PEagSxK+RMc/oQAf2GtOlXxmoxtep+jlmPAq0hC3gTVMAbsBmZYT2ibw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4762 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655137009; a=rsa-sha256; cv=fail; b=PkCkrVxR2cJP72+DopSoeQt7XnOXoX/euLmLJrIEhKRvthclBbgU1zOcB1sO1llvSlJyax 47oFN8n7VVnPk9YEJrWYoZxtqImbghN1QkRmE5SeI51eAQHgjwDvdJyOSG1rd7B/0U0Ngd SvWdeU38DUuWR+OiaZbcR9WoRXQUBuE= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SKcDblFf; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of ira.weiny@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=ira.weiny@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655137009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F2WQwTVzkLeYgaFfingfi9titGvrEdnHBb5+ZTfqU28=; b=2DaByVtLMTqtuCu9tHQGrGJYUV7R+yZaAY8ORQ8iXff9r/UuTVL0M215mTB+JQqJ1houaR 9PxkWK8718DtlGysZAg7xvxIhj9KfD/qs93xronNdJLWI//XKBW8N7wYMDEOOUI3IuLEEV 0rIJwwK9tyv34kuNUUwAaB+hpRuxxnk= X-Rspamd-Queue-Id: 83315800AA X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SKcDblFf; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=none (imf02.hostedemail.com: domain of ira.weiny@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=ira.weiny@intel.com X-Rspamd-Server: rspam06 X-Stat-Signature: 7i89j75cjwfh3i9iejo4b14tu1j7rkef X-HE-Tag: 1655137009-95469 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 09:17:06AM +0000, Christophe Leroy wrote: > > > Le 11/06/2022 à 01:35, ira.weiny@intel.com a écrit : > > From: Ira Weiny > > > > Now that the pkey arch support is no longer checked in mm_pkey_free() > > there is no reason to have it return int. > > Right, I see this is doing what I commented in previous patch. Yes because it was suggested by Sohil I decided to make it a separate patch to make the credit easier. > > diff --git a/mm/mprotect.c b/mm/mprotect.c > > index 41458e729c27..e872bdd2e228 100644 > > --- a/mm/mprotect.c > > +++ b/mm/mprotect.c > > @@ -809,8 +809,10 @@ SYSCALL_DEFINE1(pkey_free, int, pkey) > > return ret; > > > > mmap_write_lock(current->mm); > > - if (mm_pkey_is_allocated(current->mm, pkey)) > > - ret = mm_pkey_free(current->mm, pkey); > > + if (mm_pkey_is_allocated(current->mm, pkey)) { > > + mm_pkey_free(current->mm, pkey); > > + ret = 0; > > + } > > Or you could have ret = 0 by default and do > > if (mm_pkey_is_allocated(current->mm, pkey)) > mm_pkey_free(current->mm, pkey); > else > ret = -EINVAL; Yes that fits the kernel style better. Thanks for the review! Ira > > > mmap_write_unlock(current->mm); > > > > /*