From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3505AC433EF for ; Mon, 13 Jun 2022 13:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B4218D0185; Mon, 13 Jun 2022 09:55:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13E6E8D0171; Mon, 13 Jun 2022 09:55:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF8D68D0185; Mon, 13 Jun 2022 09:55:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DAA268D0171 for ; Mon, 13 Jun 2022 09:55:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9499520E29 for ; Mon, 13 Jun 2022 13:55:11 +0000 (UTC) X-FDA: 79573359222.23.5830D85 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf16.hostedemail.com (Postfix) with ESMTP id 1DCC718009E for ; Mon, 13 Jun 2022 13:55:04 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id w27so7247993edl.7 for ; Mon, 13 Jun 2022 06:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=23KDBDDZ3VkUuxNsEX2Vg6z3P++uxWU/q1ahY548XbY=; b=WGFEBLPvs34hqZorXMFpphv2yLNWJQYYANp9GUstfjUroHh7OzaIXSayDUxBb6AwQu ZWN96SgJakP1KylQptQ2ki5zjTMI8nhEUCXzp+i1OqA8rIZZgd3v2/4cGJvpjnm75a8z pD/mZM7pjW5r49KyvGdXP1czPuJ1FRm7z6XmpQB0uUSkTEZGgrTERmLHbhFRVxciYsAO 27CwrUIC74b7uFY7jRQMoT30nAEc0DBH/qlMh5Zqg/MtLQoLvKnbsCiH+ZBpCrvBENTD SmbEVB2ezT/aQLK7UK0DM9Qw1OaXMb5zVao3q+fabZifar49zS2fYpjNd0gfwssT57aZ jkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=23KDBDDZ3VkUuxNsEX2Vg6z3P++uxWU/q1ahY548XbY=; b=qPwbLvyIrnzkGVCUy5U20VL2JLHZeFCJz0peC6pHYyZHN/K/31JjMbKwuAkD6j/2zb hcPBnXc7QEViOu4XbBQ1hRmNmCUBwdsemPmO3sebXSQ99AaZ0XkprjStFTqSnCZGOfit ky8QaWRYmKXr2w5MpGNiPjaA8UPRibdd57xHWNWe/aYjROewFZWKzDQlzs487j+4A34e nbRfn+4BzlMJuozWPsUjyzioOyzvEwB6LLJf+s0mXuyhx1+ewKodz6EIZjDChkPPh7uM 8mSAepM/jx0in+BTVIllSTvyVRixr1oRAQ6a4cHtY0XCWIL7jThetlv89l9HmNactMGl Ilyg== X-Gm-Message-State: AOAM533s9wVrRHO/LF1Oy7eOwqIprm/HHnfUHZvIl/dMQgxuhx+0zyht EtY38eyCkb3NUGUDF1vS2JJ1LEVJDbrzQgJA X-Google-Smtp-Source: ABdhPJxA5x8JCBmPoxnRAJLCpQ2Ve1KOnbsHBwhlXNeb0c0xEh3qeODUBU0JaHYb/BM+3eJ9d0OafA== X-Received: by 2002:a05:651c:210f:b0:255:847d:391d with SMTP id a15-20020a05651c210f00b00255847d391dmr24739381ljq.354.1655124966313; Mon, 13 Jun 2022 05:56:06 -0700 (PDT) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id 1-20020a2eb941000000b00258df665017sm1001443ljs.3.2022.06.13.05.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 05:56:05 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 13 Jun 2022 14:56:03 +0200 To: Baoquan He , "Matthew Wilcox (Oracle)" Cc: Uladzislau Rezki , "Matthew Wilcox (Oracle)" , Kees Cook , linux-mm@kvack.org, Zorro Lang , linux-xfs@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/3] usercopy: Handle vm_map_ram() areas Message-ID: References: <20220612213227.3881769-1-willy@infradead.org> <20220612213227.3881769-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655128505; a=rsa-sha256; cv=none; b=UbL/RL3QNOlQmEe+ApGZfTCnyL7L+h27/BU1dKQ16QDRg5ZCep64HSQt/hnSIcJ5rPYhXI vXlvpHlhe1n2zrQr2UjWKCNaTTJp8kUmRUekMprY9YGcK7+QC8ed1xJHQUa5W7K8Gdd05V 3SGBI+SV73oNbCyk0I99odzaidFqB0k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WGFEBLPv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655128505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=23KDBDDZ3VkUuxNsEX2Vg6z3P++uxWU/q1ahY548XbY=; b=0jo+/Mt25TA/MEw4EFd6VIFTwd9q2xEV9ie+EP8Iz/VaSlD9rsKV/JuVDCjHGyoXwMGjSn tXuFo67/guaEViB1W7sa+/t2cGkUuVnvAjjCg8ebUOm3DwDtoBr3vDVhZ4a6/l/CUQMi/W 9C6l8EDn1wOxd3CgiQqhbCtXb6GJx5A= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WGFEBLPv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspam-User: X-Rspamd-Queue-Id: 1DCC718009E X-Rspamd-Server: rspam09 X-Stat-Signature: dwmpa9c1a1pkwzjbx3tbnbof3rh7puz6 X-HE-Tag: 1655128504-9172 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On 06/13/22 at 12:00pm, Uladzislau Rezki wrote: > > > vmalloc does not allocate a vm_struct for vm_map_ram() areas. That causes > > > us to deny usercopies from those areas. This affects XFS which uses > > > vm_map_ram() for its directories. > > > > > > Fix this by calling find_vmap_area() instead of find_vm_area(). > > > > > > Fixes: 0aef499f3172 ("mm/usercopy: Detect vmalloc overruns") > > > Signed-off-by: Matthew Wilcox (Oracle) > > > --- > > > include/linux/vmalloc.h | 1 + > > > mm/usercopy.c | 8 +++++--- > > > mm/vmalloc.c | 2 +- > > > 3 files changed, 7 insertions(+), 4 deletions(-) > > > > > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > > > index b159c2789961..096d48aa3437 100644 > > > --- a/include/linux/vmalloc.h > > > +++ b/include/linux/vmalloc.h > > > @@ -215,6 +215,7 @@ extern struct vm_struct *__get_vm_area_caller(unsigned long size, > > > void free_vm_area(struct vm_struct *area); > > > extern struct vm_struct *remove_vm_area(const void *addr); > > > extern struct vm_struct *find_vm_area(const void *addr); > > > +struct vmap_area *find_vmap_area(unsigned long addr); > > Make it "extern" since it becomes globally visible? > > extern is not suggested any more to add for function declaration in > header file, and removing it doesn't impact thing. > OK, thanks for the hint: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki