From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B94C43334 for ; Mon, 13 Jun 2022 10:00:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA7908D0177; Mon, 13 Jun 2022 06:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C57788D0171; Mon, 13 Jun 2022 06:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1EA68D0177; Mon, 13 Jun 2022 06:00:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A2E178D0171 for ; Mon, 13 Jun 2022 06:00:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6189C20EC1 for ; Mon, 13 Jun 2022 10:00:40 +0000 (UTC) X-FDA: 79572768240.16.817E1D4 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf11.hostedemail.com (Postfix) with ESMTP id 788964008B for ; Mon, 13 Jun 2022 10:00:39 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id e4so5620055ljl.1 for ; Mon, 13 Jun 2022 03:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n3cgN2CZeUATuDX6tGeZqbEe4qx2pH+uniVRgLnOiSY=; b=P5QwT1m2oOSDkfS4z7jk4qILTPWqpBqCxOLSXm8VM22ATVKCcgtpjpI1CXiAfuBV1G AlbNG614FbjXH53G6+QPu3P5o6AtLUv2na+plKkl+tm4i8zzYeJbhfevorVTKmdcNg/S JJzCdOax1zNaWUAsvddV70dd5CVkC2N0y0W4wvTZ4vuKsFVRYxl5QD6ldzp+WO5TYuAZ d+HaUOifBkE6SweFqRVxRFIMtwInHe0Aqv78Qzr1d8BgVpbHOAZLVJmwM8P9jsOd6BI4 9cKeJffCZUMN+kK5biVnvBlDAynClJqxMXvPfHqKFtbuJNL3mzpq+32VI8I/DH7bEWaS 7BIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n3cgN2CZeUATuDX6tGeZqbEe4qx2pH+uniVRgLnOiSY=; b=EAYG9kInggzkRk55RpS9CjHuEkr4UeEQL3Z0QQLRFj4vvQcTv6d/Tgk2XulkhWNPx5 slVAOuU2WnafLMs3kvvwywyJSieBWOVLmo5cMWieRrwjss6mYrtEX85l8+EjGwxXUjah sY2kkVtCtqkIyEm8WVUBLNrZFLejQ4AnCpNI0d1jSObSYeFYRxeI1Lfq1Ex98uB2l+XZ pP4MVD9pSKCwPoFz2vqBSYajlRQxcpEt9h8eHcGBaCns5sw34BzAEFk1om5j9Igi4FfI kl7G5O/yWKCUDtFIIL18x0a7b4ZdrIHWapJyY9Zs6BBJteF54DSMlm/uTELkPnZT3c4v Zf5w== X-Gm-Message-State: AOAM530C//wRV3s5+V9ta9k751zdqotlOs3SeZkv+RrvQsBqY7GTfqbQ F13Ho1fWUWJlO0VLE/MxM9w= X-Google-Smtp-Source: ABdhPJwUifOWExCNu4th+FzG3q0cyioLwDRfT3eb/rRC1EWeAkgo2bbuWuoKAHBS8/KswS3KEQDRNA== X-Received: by 2002:a2e:9283:0:b0:253:e175:dd84 with SMTP id d3-20020a2e9283000000b00253e175dd84mr61977086ljh.221.1655114438114; Mon, 13 Jun 2022 03:00:38 -0700 (PDT) Received: from pc638.lan ([155.137.26.201]) by smtp.gmail.com with ESMTPSA id o20-20020ac24e94000000b0047255d210e7sm929510lfr.22.2022.06.13.03.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 03:00:37 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 13 Jun 2022 12:00:35 +0200 To: "Matthew Wilcox (Oracle)" Cc: Kees Cook , linux-mm@kvack.org, Uladzislau Rezki , Zorro Lang , linux-xfs@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/3] usercopy: Handle vm_map_ram() areas Message-ID: References: <20220612213227.3881769-1-willy@infradead.org> <20220612213227.3881769-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220612213227.3881769-2-willy@infradead.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655114439; a=rsa-sha256; cv=none; b=MHhyO6UOFonq3itLmEndkJt4KApMr6OE4lGgJ/5NmZNRfSDjN/uvxVUU4PmPugoLk6yVxO Od807BLIz/4VGlsc01JbgRS77hL4uWSgmQzSTY7SkUtb8eSbIEHVJKrk1Gj67h7ndW7X79 4FaTnqGNOOWaNIhKYXM46JFIPagzDwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655114439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n3cgN2CZeUATuDX6tGeZqbEe4qx2pH+uniVRgLnOiSY=; b=l4lKapb5Nm431pwTCPVD5tzvofY9T5deH4zNro8uyVzCiJxtjpNbgbs3EurCjZMz+MKdrT ITMwsfprSXfVrJoGdurcIUnGo0k8Ff3QM4e8BZqeLZuLykymu0HZIDiFu6YaUkKGbTkdwW Q4cr0um0KvDfapRhJiYl1DYDWcXLCOA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P5QwT1m2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P5QwT1m2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Stat-Signature: t5574o3954f8sntc1anxiwp1hdqbxrbf X-Rspamd-Queue-Id: 788964008B X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1655114439-14647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > vmalloc does not allocate a vm_struct for vm_map_ram() areas. That causes > us to deny usercopies from those areas. This affects XFS which uses > vm_map_ram() for its directories. > > Fix this by calling find_vmap_area() instead of find_vm_area(). > > Fixes: 0aef499f3172 ("mm/usercopy: Detect vmalloc overruns") > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/vmalloc.h | 1 + > mm/usercopy.c | 8 +++++--- > mm/vmalloc.c | 2 +- > 3 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index b159c2789961..096d48aa3437 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -215,6 +215,7 @@ extern struct vm_struct *__get_vm_area_caller(unsigned long size, > void free_vm_area(struct vm_struct *area); > extern struct vm_struct *remove_vm_area(const void *addr); > extern struct vm_struct *find_vm_area(const void *addr); > +struct vmap_area *find_vmap_area(unsigned long addr); Make it "extern" since it becomes globally visible? -- Uladzislau Rezki