From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17DBAC433EF for ; Mon, 13 Jun 2022 07:15:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8730B6B0207; Mon, 13 Jun 2022 03:15:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8215D6B0209; Mon, 13 Jun 2022 03:15:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8C86B025F; Mon, 13 Jun 2022 03:15:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 60A4B6B0207 for ; Mon, 13 Jun 2022 03:15:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 321C720E33 for ; Mon, 13 Jun 2022 07:15:08 +0000 (UTC) X-FDA: 79572351096.27.B0D2660 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf11.hostedemail.com (Postfix) with ESMTP id E668B40081 for ; Mon, 13 Jun 2022 07:15:06 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id l4so3725787pgh.13 for ; Mon, 13 Jun 2022 00:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ryeH9bTEtbNft6a8+l0Ww/QD0tPIB9O2GIzjchd0JQ8=; b=7Z2m+UanT7leluCE0awhNxUgN/zvt+QgLX41xEJAkZ+hZl9VI2EHpDcYFUppZ9BKoY 50fge9XUhht5/9Jy98ZmwWcEyX6y0D12e8O+OcFKcGMtINA54VotW1Re/vgDyk53Ukdm IHxc1+r+vMC9HH0wgZhf2TJdBx5q2rbxsUSIztrzJbjkJ804j6UTeS5RqqRNrRkuRW6M zyXgQD365z1Sc+96lW/fEZVdEBCWAefn+rXwdENfblHqcGEtDQrRctODB4Opn2iWL40a 99tK75i+ilgO4NFf/w7KwY3VOplAn0WgtizKYpUhR3effzvDCve7a3XIeOS6hX6DqZzx pZMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ryeH9bTEtbNft6a8+l0Ww/QD0tPIB9O2GIzjchd0JQ8=; b=SnJeMcZQY2VT6OlyrEpEyQe7qX/0r1GD6V2e5XHLSsJis/D7Bqay67MjnmN3Yb94jR y0s0ASf/ZvFZIqMdkUAyhW5wS9zTIVFehfXKVFvEvNjt67N2SnSJl/g57tRkGc/rrLVD jaKDJM9v7ReOKRg2rZHMESCgu51rA3l1WDlxKuNoFf+N2pq9TfTzjFdQ4rnPIVMehGCC UJHot7cQ8AdlwOfI8nDLWKvxa/351L7W0zVUgG9lqUc2vRxTLJPSmx1xIojHGeKYNHnR kLLtl3XTevC95FWXhBkmQGPx+PSBkwRyfeR5gHf6/1q8rRsaT6uf1jECFhTcReKkj4ZG zHXQ== X-Gm-Message-State: AOAM533DxZVfBCsjaJ7/oA4XiRG10ZZdf96qYUio6YWusmO33nDLP5ay oC1RDulf8Gj8Kc/sOA5Lnhr0+A== X-Google-Smtp-Source: ABdhPJzHmwvUgcBKOSqyUg5vAuPr66x5IQQXFrWOSIsM17SUv8GbRUJd/cQ3bPRDaT8Mt+cFaz4YcQ== X-Received: by 2002:a63:4853:0:b0:3fa:dc6:7ac2 with SMTP id x19-20020a634853000000b003fa0dc67ac2mr50831303pgk.298.1655104505694; Mon, 13 Jun 2022 00:15:05 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id s2-20020a17090302c200b00168d9630b49sm2205628plk.307.2022.06.13.00.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 00:15:05 -0700 (PDT) Date: Mon, 13 Jun 2022 15:15:02 +0800 From: Muchun Song To: Waiman Long Cc: Catalin Marinas , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/kmemleak: Use _irq lock/unlock variants in kmemleak_scan/_clear() Message-ID: References: <20220612183301.981616-1-longman@redhat.com> <20220612183301.981616-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220612183301.981616-2-longman@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655104507; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ryeH9bTEtbNft6a8+l0Ww/QD0tPIB9O2GIzjchd0JQ8=; b=fgwyBz0PKRlD20hHu+Hj8yZrvrXwhTqohkfSoI+Ot6pTJpdJO5O3/jOgNR4qh+vSOfmbCS jUhgQ/+V1fdXEEVC3f67GjshG8XAYQQqu2ADSjN80HgmiDy7oH3VUv612Spbpj5gBvLbtL SPIX0XtNK1EZCvE8ybm2g30BateUTxY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=7Z2m+Uan; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655104507; a=rsa-sha256; cv=none; b=k4EaK0MFp8+YIrcZldNTRG096bZsEZmiw4GLRVcDAH+c+hWnEGa80dVaAVkFWscqB4VTZv jIccdHuOsDTHEbFXX49309hbqbdAHHygsi7XN8rJHBAenUDiJI2rI4olZK5JAe996BS9SE 7eBupRwWLq/iDVHUQ3P86O1RboHxiQ4= X-Stat-Signature: 3cgbp7awa3muyksmhep5cbwnswifai5s X-Rspamd-Queue-Id: E668B40081 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=7Z2m+Uan; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf11.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1655104506-824654 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000812, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 12, 2022 at 02:32:59PM -0400, Waiman Long wrote: > The kmemleak_scan() function is called only from the kmemleak scan > thread or from write to the kmemleak debugfs file. Both are in task > context and so we can directly use the simpler _irq() lock/unlock calls > instead of the more complex _irqsave/_irqrestore variants. > > Similarly, kmemleak_clear() is called only from write to the kmemleak > debugfs file. The same change can be applied. > > Signed-off-by: Waiman Long Reviewed-by: Muchun Song Thanks.