From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2C1C43334 for ; Mon, 13 Jun 2022 03:21:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 583B38D0146; Sun, 12 Jun 2022 23:21:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 530378D0142; Sun, 12 Jun 2022 23:21:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F84D8D0146; Sun, 12 Jun 2022 23:21:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 307F88D0142 for ; Sun, 12 Jun 2022 23:21:42 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 077F220D11 for ; Mon, 13 Jun 2022 03:21:42 +0000 (UTC) X-FDA: 79571762844.31.19E3FFF Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf02.hostedemail.com (Postfix) with ESMTP id A1231800AA for ; Mon, 13 Jun 2022 03:21:41 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id gd1so4489063pjb.2 for ; Sun, 12 Jun 2022 20:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qbAkkO2zSW3z0Q8/BVx6T9JB6N1UA+DX5z/rLPoFpPg=; b=1NGXFsXFPUAUMfe9N4JthX1ALkYAWYMsOuYDyQtcQeW8WNFwZlcHItd6XrM+lng3UI Rt8zNF+zxAVQWenqcclBqxhu/Xxcn8j6sBXL0Vs/E0KHyZDDP8ejdsufZhWWAEQx8IUF aPs9uCjcBNIjeaM3oRwnjC7VxRpdjBRyJDmBA3koSCVptEqjkDJAp/clVapRzZK7ivQt vvIiT7jbLJuwAp1rHkKsK8q/MFc8GsBuxLrD/3Rh6x7b8DZ/wsoFLkc7jS2kZdxRtLkQ JbuYUgDS79x7n4D6hVdrAFjYjrBaho7I6QHY9iGc3X+OP24M9FH+2CgJEl9gSFtl/hNL 54jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qbAkkO2zSW3z0Q8/BVx6T9JB6N1UA+DX5z/rLPoFpPg=; b=0t8c7b2t5Rs7TMPxdkC3evEW00glr1g/Nz9l7esp8uCFcq4oLNRtT/LeJ5UMrLI6o/ 5GGG/F7bMYvjl5f21fZT3sUt7Bf89hDrnu5gzr/EXKF0toof0zeOifjiVkV2A1Rrcn6n Ux1U+nafOySDlbKmCl8pkyD3/COdd8ewGs7/oNBMc5ut08axSeQQZ2QCDD2NYHf7z/jE GYhQoL+zJNkHzcDncPoqXo2gg6czrhjivrbv5f5Fu9q/v3KRoc6EYB4YQDmDybLkYRUl aONR+Zp4d4qnmBr9Krq59vyInOwSgRfVnZy1laQes4KJ7SXrz5bc2DAaihL7+gE1YSeB RrrQ== X-Gm-Message-State: AOAM533Tvav65Aooo1v4bUEQ8Hgm896j7d7F5bUP7pqI2odrK0+9amUv NA/FmX+k8GcAIeY3+in/NBtPwA== X-Google-Smtp-Source: ABdhPJzqH8tH9ELakOc22/fn6gukK9gQTVOUDUaR4Qen3wkF/IolOLy916cLAPA6O/e/2Leo1Zot5w== X-Received: by 2002:a17:902:f612:b0:14c:e978:f99e with SMTP id n18-20020a170902f61200b0014ce978f99emr56667491plg.23.1655090500604; Sun, 12 Jun 2022 20:21:40 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id i3-20020a62c103000000b0051008603b66sm3967995pfg.219.2022.06.12.20.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jun 2022 20:21:40 -0700 (PDT) Date: Mon, 13 Jun 2022 11:21:37 +0800 From: Muchun Song To: Daniel Vetter Cc: LKML , DRI Development , Daniel Vetter , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/slab: delete cache_alloc_debugcheck_before() Message-ID: References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> <20220605152539.3196045-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220605152539.3196045-2-daniel.vetter@ffwll.ch> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655090501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qbAkkO2zSW3z0Q8/BVx6T9JB6N1UA+DX5z/rLPoFpPg=; b=F3YTpU2eYi3xOQ1aVFY6k1hXEWdNvb5Rij1L/cTC+36crrYoH7Xgit/n0Qhe9580O7rfu3 zYPyKRJkQRTAdYwepPd8xDcI8+uawvcm8xFprd539zEENYVpxxS73oFmS5UCuc3Ho/wl38 WrZ7sNF/MQKjAFUv1rUzm3io28m37wc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655090501; a=rsa-sha256; cv=none; b=lmafXXDIxT0ePeXrbPTMsut2dnnIPHOAhPsa19NND0QmEsX5jfZCfN7vr3JRsmvJ1Z7szF yKXmbmQPCmmJXOM1KSXP43oWymyWFBT+YAP3pCWRzpq2uwYDOt3bl/ddKEaBjZ8NNfYAHz uEMAN8t6p0ntf4QwJv6FyD5Bl0KTt+o= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=1NGXFsXF; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=1NGXFsXF; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf02.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam03 X-Stat-Signature: uctnbawgg74jb4ywr3ad8yk4tufh5ath X-Rspamd-Queue-Id: A1231800AA X-HE-Tag: 1655090501-994942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 05, 2022 at 05:25:38PM +0200, Daniel Vetter wrote: > It only does a might_sleep_if(GFP_RECLAIM) check, which is already > covered by the might_alloc() in slab_pre_alloc_hook(). And all callers > of cache_alloc_debugcheck_before() call that beforehand already. > > Signed-off-by: Daniel Vetter Nice cleanup. Reviewed-by: Muchun Song Thanks.