From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3907BC433EF for ; Sat, 11 Jun 2022 09:46:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D7526B0146; Sat, 11 Jun 2022 05:46:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B82C6B0147; Sat, 11 Jun 2022 05:46:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09D0E8D0115; Sat, 11 Jun 2022 05:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EFDE16B0146 for ; Sat, 11 Jun 2022 05:46:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id B49D712182B for ; Sat, 11 Jun 2022 09:46:18 +0000 (UTC) X-FDA: 79565474436.20.38609EA Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 34FBAC008C for ; Sat, 11 Jun 2022 09:46:18 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A703FB83277; Sat, 11 Jun 2022 09:46:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06F74C34116; Sat, 11 Jun 2022 09:46:13 +0000 (UTC) Date: Sat, 11 Jun 2022 10:46:10 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v3 3/3] mm: kmemleak: check physical address when scan Message-ID: References: <20220609124950.1694394-1-patrick.wang.shcn@gmail.com> <20220609124950.1694394-4-patrick.wang.shcn@gmail.com> <957f5626-2c89-f53a-2156-bbde2bb545f2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <957f5626-2c89-f53a-2156-bbde2bb545f2@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654940778; a=rsa-sha256; cv=none; b=exUj32hPVXyJgf2ICN3Jg50vM/c1eI6iwYM4Blp1cVsRqOMV0pEwK5pofE+PvRuTYfGo+J JSs15RzFXrx6qQmVfU7gOBicRugxLAMMg5bfiRSiPmludqfK6Nw8jGgIUmt84U8xg6BNes c9CVbqmXlvFJb3XdQBhuDM8wv7Y1yCo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf22.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654940778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I7VWFHfWtHBXsaPRZpO2aG3D+nYpH7lyc3A9bMpoI30=; b=Sysmp3NUldMnaFGk3eCZlVhRZ0hIEXl8MUQURyNL6ww0zegonVJpn0NCc3PGrn2F+jL4BR HVseRM05BL+YlFI9CYyZHvNiKWT9tOT6dX1mFoGRC1YnJJB1SIJPVYqDeeC7y2Uo9uW1PT I6gix1Iq5ebYkeD2wmerAG+yB3bkeuc= X-Stat-Signature: aiij4ruz5zwx9je3zhwnc1rqssyfsih1 X-Rspam-User: X-Rspamd-Queue-Id: 34FBAC008C X-Rspamd-Server: rspam07 Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf22.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-HE-Tag: 1654940778-796572 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 11, 2022 at 11:46:27AM +0800, Patrick Wang wrote: > I've received an auto build test WARNING from kernel test robot: > > mm/kmemleak.c: In function 'scan_object': > >> arch/powerpc/include/asm/page.h:215:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > 215 | #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) + VIRT_PHYS_OFFSET)) > | ^ > mm/kmemleak.c:1403:19: note: in expansion of macro '__va' > 1403 | __va((void *)object->pointer) : > | ^~~~ Ah, yes, arm32 has the same issue with phys_addr_t defined as u64 in some configurations while long is 32-bit. > So I will replace __va((void *)object->pointer) > to __va((phys_addr_t)object->pointer) for fixing this warning, It makes sense. -- Catalin