From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF54C43334 for ; Sat, 11 Jun 2022 03:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 638258D0105; Fri, 10 Jun 2022 23:50:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CA898D00F7; Fri, 10 Jun 2022 23:50:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4390E8D0105; Fri, 10 Jun 2022 23:50:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2FEE38D00F7 for ; Fri, 10 Jun 2022 23:50:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 00DDF61755 for ; Sat, 11 Jun 2022 03:50:20 +0000 (UTC) X-FDA: 79564577442.03.0711A71 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 9E93D160074 for ; Sat, 11 Jun 2022 03:50:20 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id hv24-20020a17090ae41800b001e33eebdb5dso4763479pjb.0 for ; Fri, 10 Jun 2022 20:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FBKlFdK4PX2cFyTdjAl6VU9HARFofyR9t9zwGts6b7U=; b=pEkMsE98bnoHn3Kb7FwscLB2ArAgu1loIHLwd+dvPKR62K/thYl91V0nTPMor4JF2D Rw2pGHKz4EoUyQlCR/VObEfdxX55yHnj2/EiWuUgEapX5S8Envl3tSNiH70S5FHfIagM k9GJBXEKlMLW75F+HD7N/kTfjiTx6cUSe3CN8WOWAVja5SQcI8CAE+YQLhgwEc2mmxHm +ZpwiTNSXtJde9FXkMco8DoZ3U9KEZ5UA2bafkwxV43pvHc1SnazGbujsLqiiHRePfe7 pdWjAqskPHSwcG3mmaljvdxSRzyAIh/Iec6mi2WhEeA+C1zjkoMH/0FFaSR0cjLdiTvr vj9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FBKlFdK4PX2cFyTdjAl6VU9HARFofyR9t9zwGts6b7U=; b=pbeYkY1HDHJ/bIGnb+lP0h9Iqn5jsH9UZhY6RAmx6Fnq7yMw2hK7pPQjbziJ8ZYA2w ObjMwFE3ZRDLRfWG8cmNYyI6TIwbP4Jo5W8o/VldWNkjtjKgNRCipnTFjqoQz7HidzsK wwNP+fZ8/cUxzjY+eEGoadAhj7y49HUD2rrFlc/WP8roIIEoiydnz6yZHZaQKrP82oz9 dZb3q7Uftc75MMkO83kO1PdCOTz2MNpqhtUo8CU6KOzgkOP5//4MhgjqDEoo6liI1HSS Ig/r4EyBVDrC0Z+u5zYXYheG7n0JE40ACTg9ggBYNN8MuMMM+XZgND+0a/cdCXQvq0Qg 1oTw== X-Gm-Message-State: AOAM5300TWh/Zr37/ZDth0ojJSy2leW1/DUUGc5tYCuHvJN3vJYv8VMW gryorJxEFwIMqcqSQ1wb/w4= X-Google-Smtp-Source: ABdhPJxtlzxs3+O913NXNcri66h1VaR4TYdkSkiD6iwm5eGBZc68W/DT9TWoN0emd1hIUj6j+jP3Pw== X-Received: by 2002:a17:903:2cf:b0:151:a932:f1f0 with SMTP id s15-20020a17090302cf00b00151a932f1f0mr48762665plk.130.1654919419758; Fri, 10 Jun 2022 20:50:19 -0700 (PDT) Received: from hyeyoo ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id x195-20020a627ccc000000b005185407eda5sm368133pfc.44.2022.06.10.20.50.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 20:50:18 -0700 (PDT) Date: Sat, 11 Jun 2022 12:50:08 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Jiapeng Chong Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] mm, slab: fix bad alignments Message-ID: References: <20220609040132.89192-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609040132.89192-1-jiapeng.chong@linux.alibaba.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654919420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FBKlFdK4PX2cFyTdjAl6VU9HARFofyR9t9zwGts6b7U=; b=oEVAsYLBjCcxLPIU2MkZYKybnVS+EfwzfZSRN9363ApZBZ0U6iT8qu3j01j438LiWhRfiW TXNWYh+n7aNN6q8RoxU31mDwz5S0vVdFaAbKY1+o32w7dHRRvErMjWz1ZIWeTcLfcGEhUe a6rkce1lgAfBeyi3/KMSCkMcKoIEbUM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654919420; a=rsa-sha256; cv=none; b=3kghYNSgC6HX6IShpJaZRxFB8tmW6RkXqxV1f6AblgRZEl49IyAXk5aijNiI6GPSxdxcFQ lXHGEewDJffRUm4gRqfvLrlTX0n32dtrFS1rhVjzE4a2vSgkhDqcYBsw0ZrDzpl4S1TZjR RLvEWZCoTt6pWESO2iGMicZljLQIzVU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pEkMsE98; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pEkMsE98; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: z7skcrt9j9pjdxsbro6fajmsnixpao17 X-Rspamd-Queue-Id: 9E93D160074 X-HE-Tag: 1654919420-476001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 12:01:32PM +0800, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > mm/slab.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 47151fb2b2d2..c359c0f2c897 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ > } > /* ___cache_alloc_node can fall back to other nodes */ > ptr = ____cache_alloc_node(cachep, flags, nodeid); > - out: > +out: > local_irq_restore(save_flags); > ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller); > init = slab_want_init_on_alloc(flags, cachep); > @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags) > if (!objp) > objp = ____cache_alloc_node(cache, flags, numa_mem_id()); > > - out: > +out: > return objp; > } > #else > -- > 2.20.1.7.g153144c Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon