From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AA8C43334 for ; Fri, 10 Jun 2022 23:08:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9036A8D00ED; Fri, 10 Jun 2022 19:08:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2678D00E2; Fri, 10 Jun 2022 19:08:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A0E98D00ED; Fri, 10 Jun 2022 19:08:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6CB168D00E2 for ; Fri, 10 Jun 2022 19:08:25 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 46F7C20582 for ; Fri, 10 Jun 2022 23:08:25 +0000 (UTC) X-FDA: 79563866970.04.FE414FA Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf24.hostedemail.com (Postfix) with ESMTP id B28AA18006F for ; Fri, 10 Jun 2022 23:08:24 +0000 (UTC) Date: Fri, 10 Jun 2022 16:08:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1654902503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i7qscO1Vtb3X66YSDizljaZgEO4PdhU7TjZ1ZnrPRUo=; b=ZtiKgrfdV4L1XyviDb233nRIQBlSe9wmuFm6YDm+4CalI0EPaZbRXv2lNJK3+HtxrWskCh YbefZi4UBEK0dEtaQ2fz8mermVf8mItetmiXscBb/PV/Q5UbH1NdG5UOTU1s0nHZ7yiSJM Q1KDlojAGVtO+bOpJoAR/0KBVopsi20= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 02/11] mm: rename unlock_page_lruvec{_irq, _irqrestore} to lruvec_unlock{_irq, _irqrestore} Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-3-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530074919.46352-3-songmuchun@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654902505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7qscO1Vtb3X66YSDizljaZgEO4PdhU7TjZ1ZnrPRUo=; b=NSza20B/UVJwgTIoguEXoAApe/7O912vEuMboTju4r40tABFCkYmLlX1ykOrLeFAMOIldp bAqdgG4GkCgAmOiDkbkhQGmA2B5PR5ihse8Du7rNSMSGCC8V51QNNQ4JhHszbSLSv0Xk/N 9AQ6XGtXSMwwkjc2ZShp1ZRMwgZiE6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654902505; a=rsa-sha256; cv=none; b=np0eoVy0lArGDD7mjpN27abXDVcNEK1NaqaTWYZGs4CJEBUi/RrFWt1B9CrxX78g8lMqFr BInF84pb/vVzLKm6Dxmmeo4eeoVx1p1fw+S+dofDlQ9kGvDo6rBKCDRMWvs8wJL1+5vv64 ZsOdfNC2Pco5d8uU6WNsgSX6OZO8jCc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZtiKgrfd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZtiKgrfd; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: dzixruwbdnkm5s4wrtz7yhj14mz8e7bq X-Rspamd-Queue-Id: B28AA18006F X-HE-Tag: 1654902504-927922 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 30, 2022 at 03:49:10PM +0800, Muchun Song wrote: > It is weird to use folio_lruvec_lock() variants and unlock_page_lruvec() variants > together, e.g. locking folio and unlocking page. So rename > unlock_page_lruvec{_irq, _irqrestore} to lruvec_unlock{_irq, _irqrestore}. > > Signed-off-by: Muchun Song Looks nice! Acked-by: Roman Gushchin