From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BB3C433EF for ; Fri, 10 Jun 2022 14:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 290DE8D00B1; Fri, 10 Jun 2022 10:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 240EA8D009C; Fri, 10 Jun 2022 10:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E2E98D00B1; Fri, 10 Jun 2022 10:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F1C058D009C for ; Fri, 10 Jun 2022 10:07:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6A2D470 for ; Fri, 10 Jun 2022 14:07:41 +0000 (UTC) X-FDA: 79562504322.19.D141701 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 1A387140080 for ; Fri, 10 Jun 2022 14:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654870060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oNWs5ba0CLyEfWmFHDLU3/iqRFtVDYZm9ObGN+wkIio=; b=HdvcvG+1w1CHVIQXQp/R8oFBb1GMHHFINg0iBILGsJmN4qGd7EbiQM2DpXfFV2jZbEf8bO xsG2Gczkm6zcqkD72X38/5Bc/Lxd/Uu1B8D6MSZ1C9H5jEKw2+GiXk5Iivoo5gKEDGt074 h239yBvjGZTDGqC4KVPGH/E9FK8XxA4= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-330-l2889ojGOTqvt5CMLPe6Lw-1; Fri, 10 Jun 2022 10:07:39 -0400 X-MC-Unique: l2889ojGOTqvt5CMLPe6Lw-1 Received: by mail-il1-f199.google.com with SMTP id w7-20020a056e021c8700b002d3bc8e95cbso19659944ill.3 for ; Fri, 10 Jun 2022 07:07:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oNWs5ba0CLyEfWmFHDLU3/iqRFtVDYZm9ObGN+wkIio=; b=nrGSMloRkH+HFzXneB4Sfj6p71r6crSStyvvg6GdOt0cY9myZExZvnt31Ya/cNn+oq 5h4yBnlPF1xR6wxZsal1HSXbM2bb7qyWEsiWEXR1+Ps2xUDNVZzSdGSF9FfeOakIZBqO Sb4VTMoWlMPz9pwlD6P9ujBwREZy8VrhYwRa/S69Kc1gjgAUQqOWpNGgiKXOFudTLOqC Q1CRTnRiBt/XILAFyi1PYhTgGnzbd/SRvwqEqpEz0ugVhjl1CZkSyB9q73uvpepQ7E70 HHfKMREnzqLEfPpW9dQCqPq7+KeBDPX1AuMKvIUgY1+FVRV2n/2cnqGX51N/ODsK9x36 ywfw== X-Gm-Message-State: AOAM5326K3h7D/EzhbyRPCoBNXTluPdoeyDMStVn1jkk3ukFwkcizfUT ZtFwkfacINxTuncwPTdaP5+80Vjcyl4QOqjbobZDKT7pd1vYAHAKXEJ26ymFSe6pUtfeaB+YcGg TSAWCu3a8H0k= X-Received: by 2002:a05:6602:2c4e:b0:657:4115:d9e4 with SMTP id x14-20020a0566022c4e00b006574115d9e4mr21355238iov.91.1654870058564; Fri, 10 Jun 2022 07:07:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMFFunRERzGiq8cz3wTUgp7F/czzSi8M9ZBzNlgWaxFjk7nMaRfaCnEPN6A2pA3Dj+kWcZEQ== X-Received: by 2002:a05:6602:2c4e:b0:657:4115:d9e4 with SMTP id x14-20020a0566022c4e00b006574115d9e4mr21355223iov.91.1654870058281; Fri, 10 Jun 2022 07:07:38 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id t14-20020a5e990e000000b006695b8bb8d3sm6147359ioj.12.2022.06.10.07.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 07:07:37 -0700 (PDT) Date: Fri, 10 Jun 2022 10:07:36 -0400 From: Peter Xu To: Alejandro Colomar Cc: David Hildenbrand , Mike Kravetz , linux-man@vger.kernel.org, linux-mm@kvack.org, Axel Rasmussen , "G. Branden Robinson" Subject: Re: [PATCH v3] madvise.2: Clarify addr/length and update hugetlb support Message-ID: References: <20220608234517.117295-1-mike.kravetz@oracle.com> <3cf768b3-4d09-de13-7975-ebb74a68752e@oracle.com> <05301a1a-6020-aa52-d539-c2e0ba147181@redhat.com> <12971f94-d329-5db2-c1d9-3fdad23f3840@gmail.com> MIME-Version: 1.0 In-Reply-To: <12971f94-d329-5db2-c1d9-3fdad23f3840@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654870061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oNWs5ba0CLyEfWmFHDLU3/iqRFtVDYZm9ObGN+wkIio=; b=P5o9WDqY+91rJB0KHFm2gzbM8x7J8K6EVOQSRwx0GRbEd0O/vAZJATLY6hzQdvKoI41EBt +1v1boegp65B0NeiYH1wFR+temOCRa8MHzQH+YfCXJcZbebfGpEP8UZGLamM7ExAXhkSVZ 5cxo5VNVvWL+fAQszREM42+JBlnnCUE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654870061; a=rsa-sha256; cv=none; b=V8EDxVye4qnDy4I7I/yUw/z1Z98uyGIl4+5c8i+oTM08fxhy4rgmQzyFJt7s8zGjc5bUq/ V0WRf9y4i+hHYdGEOJpzowwMNEDrboncBZh4m7MvkSBiSBh2k9uJZyaAhEPGyDs8AP0GoZ 8T05F5b6zDoYoHmsnlShm8RfKidIzMI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HdvcvG+1; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HdvcvG+1; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf23.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: pc5tii6k5fuk5179u4a3x1rtjhy7jdcb X-Rspamd-Queue-Id: 1A387140080 X-HE-Tag: 1654870060-689500 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 10, 2022 at 11:38:53AM +0200, Alejandro Colomar wrote: > It's not perfect, and currently it doesn't detect semantic newline problems, > I think, but I guess it could be improved in the future. Semantic newlines can be challenging as IIUC it's not deterministic? I mean, I had a feeling that some paragraph could have multiple valid ways to do the layout and newlines without violating the rule. IMHO that could be a challenging part for contributors. (Or maybe the rule was deterministic but I didn't really fully digest it..) But the tool (even without the newline detections) looks promising and helpful. Thanks, -- Peter Xu