From: Peter Xu <peterx@redhat.com>
To: Alejandro Colomar <alx.manpages@gmail.com>
Cc: David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-man@vger.kernel.org, linux-mm@kvack.org,
Axel Rasmussen <axelrasmussen@google.com>,
"G. Branden Robinson" <g.branden.robinson@gmail.com>
Subject: Re: [PATCH v3] madvise.2: Clarify addr/length and update hugetlb support
Date: Fri, 10 Jun 2022 10:07:36 -0400 [thread overview]
Message-ID: <YqNQKMNXMvxH8+aE@xz-m1.local> (raw)
In-Reply-To: <12971f94-d329-5db2-c1d9-3fdad23f3840@gmail.com>
On Fri, Jun 10, 2022 at 11:38:53AM +0200, Alejandro Colomar wrote:
> It's not perfect, and currently it doesn't detect semantic newline problems,
> I think, but I guess it could be improved in the future.
Semantic newlines can be challenging as IIUC it's not deterministic?
I mean, I had a feeling that some paragraph could have multiple valid ways
to do the layout and newlines without violating the rule. IMHO that could
be a challenging part for contributors.
(Or maybe the rule was deterministic but I didn't really fully digest it..)
But the tool (even without the newline detections) looks promising and
helpful.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-06-10 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 23:45 Mike Kravetz
2022-06-09 13:24 ` Alejandro Colomar
2022-06-09 18:48 ` Mike Kravetz
2022-06-09 20:13 ` Peter Xu
2022-06-10 9:01 ` David Hildenbrand
2022-06-10 9:38 ` Alejandro Colomar
2022-06-10 14:07 ` Peter Xu [this message]
2022-06-10 14:41 ` Alejandro Colomar
2022-08-15 20:41 ` Alejandro Colomar
2022-08-15 20:46 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqNQKMNXMvxH8+aE@xz-m1.local \
--to=peterx@redhat.com \
--cc=alx.manpages@gmail.com \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=g.branden.robinson@gmail.com \
--cc=linux-man@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox