From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A93C43334 for ; Fri, 10 Jun 2022 05:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59B068D0075; Fri, 10 Jun 2022 01:18:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5244D8D0064; Fri, 10 Jun 2022 01:18:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4C08D0075; Fri, 10 Jun 2022 01:18:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 277AB8D0064 for ; Fri, 10 Jun 2022 01:18:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id EA71C601EA for ; Fri, 10 Jun 2022 05:18:58 +0000 (UTC) X-FDA: 79561171956.11.40EB0C4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 7EF6C40080 for ; Fri, 10 Jun 2022 05:18:58 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BFB161E24; Fri, 10 Jun 2022 05:18:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C60CC34114; Fri, 10 Jun 2022 05:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1654838336; bh=2yFCZugsiNQZN0gkgMSO/PLnnK4cDobzksJyDLjp9Ts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rh1PySG6mRmieZPY8cY0A1hPrIcbkuP807V49e98ihkLxbZ06HxYRwIuVMf+wTLDn X/yCYKI3C60vy05a003Jfa/l8d0up/cE/3SCBy/NuCOYNPxYpirlNBYrpXNy/Wd9yS jlJr0CyMDaP1q3f/tt8/VcfJ3YUsM+y3ifSXc9V4= Date: Fri, 10 Jun 2022 07:18:49 +0200 From: Greg Kroah-Hartman To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 07/12] driver/char: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-8-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609221702.347522-8-morbo@google.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654838338; a=rsa-sha256; cv=none; b=cWQtuvzXuTGdPMkuM1Nr4NckE/WHBQ0XNXOQSaXXXCQgn7fw2xOugpPcAgAAjnVxipCLHG H+sKmL5930csJ8di20EunaZMqrjckAXO9SnEQQFaaMb79j8VTaaC/Ah/vnaEv3xbKLNfEW yY/fvh+j5a5ghRUlLYEAFhXbF2PFosE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=rh1PySG6; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654838338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hZjftfcs3gxRhG+SWH2x4eAEsg/jSHdldl+R3UD0hQ4=; b=RMBR/Q/7XOQIp1NFiwjKBEezWQG9j1Ji7g/XFVwWEp0juPYCN7cocdEdSGAqbML9kyTqrF YThWs/09iPP5hkB/c0eSA82rbWjP0JRLGAKDE91dsD+SlU+doFBVCNaOqvcrVB26EAg1Dk mIp6IK+Q7NV1TsoDNk+h4qsl7xtYtaE= X-Stat-Signature: hukd77dwait4sqabg8tramyn4kifjw45 X-Rspamd-Queue-Id: 7EF6C40080 X-Rspam-User: X-Rspamd-Server: rspam10 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=rh1PySG6; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-HE-Tag: 1654838338-765923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 10:16:26PM +0000, Bill Wendling wrote: > From: Bill Wendling Why isn't that matching your From: line in the email? > > When compiling with -Wformat, clang emits the following warnings: Is that ever a default build option for the kernel? > > drivers/char/mem.c:775:16: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > NULL, devlist[minor].name); > ^~~~~~~~~~~~~~~~~~~ > > Use a string literal for the format string. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Bill Wendling > --- > drivers/char/mem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/mem.c b/drivers/char/mem.c > index 84ca98ed1dad..32d821ba9e4d 100644 > --- a/drivers/char/mem.c > +++ b/drivers/char/mem.c > @@ -772,7 +772,7 @@ static int __init chr_dev_init(void) > continue; > > device_create(mem_class, NULL, MKDEV(MEM_MAJOR, minor), > - NULL, devlist[minor].name); > + NULL, "%s", devlist[minor].name); Please explain how this static string can ever be user controlled. thanks, greg k-h