From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C80C433EF for ; Fri, 10 Jun 2022 08:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DCAD6B0087; Fri, 10 Jun 2022 04:11:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C626B008A; Fri, 10 Jun 2022 04:11:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47ADC6B0092; Fri, 10 Jun 2022 04:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 386846B0087 for ; Fri, 10 Jun 2022 04:11:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0253E6043D for ; Fri, 10 Jun 2022 08:11:13 +0000 (UTC) X-FDA: 79561606068.17.AD13CB0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id E7A1C4006B for ; Fri, 10 Jun 2022 08:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w8J2KWjgjx9J/jKYFe8GjW3jNW9wYeGtv0q5FHV/ys4=; b=GB5aPyYFM6PkAx1k8v49cM2BwJ WcHcAb9jUq2QalpM0aIhDr3+BATD+8EYM+eWrdcimaNJm2xzuBjssr8WpUOHCt60n94XAWc3FLON0 Ea9J0QBamM6uWTM+4HzYRBxWYDjskhw+JmLncWTsnFKFqxOWIxsmL4IFLm4L1tdnFjZSI0pPplO8o 9sJxX0TlKZO3aKYVSMxNIiHKcE1/kS+w9R9M0LWGRUAImkmbZyNxVDSII1uFSuj5x0bXfi1yfXOOK c3DmI+O3f6cqKS1/lbJzaDxCojVk8Q1W7xF3ZeNStt9QC+dLwogmOOIHoLpghg/0Ij+XccRx5toAG ilnXeRzQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzZin-006gfR-MQ; Fri, 10 Jun 2022 08:10:21 +0000 Date: Fri, 10 Jun 2022 01:10:21 -0700 From: Christoph Hellwig To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 04/12] blk-cgroup: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-5-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609221702.347522-5-morbo@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654848673; a=rsa-sha256; cv=none; b=2y7hfs+DsIiVd7fawdYJKHzM/e8n8XVTlk79cX0x5znGKAwvG+NZB+Duty0PIrmPYwXUUm paqTXV1i8DTOEpS2C0YCQZkyHkq7ks9H+QD8nJI5HtYLZvhoGm+x8Rjmd1DLX85KlB+8lh 9XKPpyK+jrrXWDaQGT5kPkDtoW50cXA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GB5aPyYF; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654848673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w8J2KWjgjx9J/jKYFe8GjW3jNW9wYeGtv0q5FHV/ys4=; b=VARoK2MbnGFd2FS27QhJ97OqmF+rM7Vma5VT/go0oXKooBcHLvt24oJJ8xy9HE06m7mTf0 AGzOCRXnzuqXzRLpge9Wakw+yze6Cp39x+jr/3vZLoniNMUg+3YEmWqc25JugpDxeNx12d GslDhIwN0y3mmzrDvDJ3vYllp7+ArSI= X-Stat-Signature: e7oa7efhnjqzragkk71zeppnnngwgqd6 X-Rspamd-Queue-Id: E7A1C4006B X-Rspam-User: X-Rspamd-Server: rspam10 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GB5aPyYF; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1654848672-854367 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 10:16:23PM +0000, Bill Wendling wrote: > vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); > - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); > + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name); Please avoid the overly long line. But given that bdi names aren't user input this warning seems to shoot from the hip a bit.