From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A74CCA486 for ; Fri, 10 Jun 2022 08:18:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B59B6B0099; Fri, 10 Jun 2022 04:18:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 764746B009C; Fri, 10 Jun 2022 04:18:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62D7D6B009D; Fri, 10 Jun 2022 04:18:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 526D96B0099 for ; Fri, 10 Jun 2022 04:18:45 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2B8BF35963 for ; Fri, 10 Jun 2022 08:18:45 +0000 (UTC) X-FDA: 79561625010.01.F5888B4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id D29F7140071 for ; Fri, 10 Jun 2022 08:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FsGmRpWL6F/atJFd7eU0CvsgBB4vqNspDhxxgQCHQwA=; b=EGmIeLAaUQFdkeWTBbXWZ4azDV yptGshIlMmxL3ZCgQxfQv4CR/vsruZXnCovEYvYpzGSIHAtMlVlucC0AJ/YCu+E+RG0jM2t+lGC5r ScQ8HTtNbTESUML4NAngb6nwJHvy9/igL+TC8szz2cUhPsfQUVLAqADpafFiBBEXj9hWwBOjD4hyM j05CnEHmUcsJQGsdt+de5bCUodiKtGLEJaLmkmLMVQRZi4t/LDv78XAl2PaDbbsTch5UhOtpllBkD XHpLcZPlw3HZ21nFpFrah2Mn+1WJxXxijuRTeVB+4PK/lXs64JVgqOXv8WYF/BB7ElPFUwGl5Vg+3 FsH14CUw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzZqs-006iyq-HA; Fri, 10 Jun 2022 08:18:42 +0000 Date: Fri, 10 Jun 2022 01:18:42 -0700 From: Christoph Hellwig To: Uladzislau Rezki Cc: Christoph Hellwig , Andrew Morton , Linux Memory Management List , LKML , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 2/5] mm/vmalloc: Extend __alloc_vmap_area() with extra arguments Message-ID: References: <20220607093449.3100-1-urezki@gmail.com> <20220607093449.3100-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654849124; a=rsa-sha256; cv=none; b=bziJX2D32iLxpoh1myzKBnrmSCd3R9habb8nIuUC7qLLpZgtxHSzg4hpx76HfiGGR8vGMF k/R9iV7D/wz1WXMU6QsgW9JTmf7BkZn8ok78IM4UshXOvt7UUap+OdEMZAnBLrXEsqoXf5 A9Wewn28GzOupjqsB28stiha+ue9y04= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EGmIeLAa; spf=none (imf26.hostedemail.com: domain of BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654849124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FsGmRpWL6F/atJFd7eU0CvsgBB4vqNspDhxxgQCHQwA=; b=m74rKWPaT9TgAgkKB0O9mGcd4BzwRpsEvB6G/AtmGUC3g31g5a8Fgl5JR/FdjgDrL4qcNx YtzkuaeD855kMgh2y0dIDb7QWBVDqINMLOV2LEUmwjIi3E1dCKO+N2AhjaEdRBP2dyE3P9 LHwoVhSlx3+lM3k4FzSUPO0JmQcywp8= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D29F7140071 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=EGmIeLAa; spf=none (imf26.hostedemail.com: domain of BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+94fc6ddf5831759bbd9d+6865+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Stat-Signature: owhxnejnrebhnowpdrpza6hqh7ki5fxe X-HE-Tag: 1654849124-717743 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 07, 2022 at 03:02:42PM +0200, Uladzislau Rezki wrote: > I wrote about it in the cover latter. It is a preparation work for > making vmalloc per-cpu. Then: a) state this in the actual patch commit log. Those need to be standalone and sufficiently describe what the patch is doing. b) do that in the actual series that makes use of them. In fact for these kinds of changes the prep patch really seems like a bad idea to start with and it would be much easier to follow if the changes were done in the main patch.