From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83BCCCCA47E for ; Thu, 9 Jun 2022 20:13:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82BC46B00E3; Thu, 9 Jun 2022 16:13:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DB956B00E4; Thu, 9 Jun 2022 16:13:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655496B00E5; Thu, 9 Jun 2022 16:13:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 532E46B00E3 for ; Thu, 9 Jun 2022 16:13:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 1E6F212074B for ; Thu, 9 Jun 2022 20:13:31 +0000 (UTC) X-FDA: 79559797422.26.D5B73F1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 60BA3140066 for ; Thu, 9 Jun 2022 20:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654805609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sfkcy2khFjdseK3OUXScUbNizZN2+TrVIqo7A7uaLgA=; b=ZYX8veX1TbGzL2XzHRP1rgJ38oGV2keeXR9nZgOzVgBe6pZ6EETk1CCYil56B7Un/5FVBI r71yDkp2nv8UbovZMSiVVDDbZg0XRmTHhKYLj97ZEEFZvLbYnwlPLCzhrB5nwqm+xvsaO6 C+6YKazr+LGnnVv/yT2ocelHrNVACdI= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-542-ykWKGsONMje4PzAvIY3faA-1; Thu, 09 Jun 2022 16:13:28 -0400 X-MC-Unique: ykWKGsONMje4PzAvIY3faA-1 Received: by mail-il1-f199.google.com with SMTP id y18-20020a927d12000000b002d3dd2a5d53so17641889ilc.0 for ; Thu, 09 Jun 2022 13:13:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Sfkcy2khFjdseK3OUXScUbNizZN2+TrVIqo7A7uaLgA=; b=ZcSfYM7Cf7K12XMUxZC55672Ojskr64vwIKx5SuNIiSTS2/C9HlFFlspMtJC1j2ekt ZSeMWr8MJdE0Ch3i+l7RsnTx/3S7kw6pi6+xM1CP9T2IEGMkql3nx4YOvB97pUPI6NHG tujWeyAUVdmdE1V2GYoe5Zd9WxTzON55ePfP252QPkaHNJrZ1pb3To7u2RwH3m7mZF/G B5kj0CcHNdIhnG7d168eDmcyWJ6nz9F8St8+RySmYBR6VN+PAIrRPEU9yeWmrbrQnS50 s94A23HuZKvcxATYWfgqoICXVYz3MfpRtkJw5dROndkzlGcf1HJ6gDVafZOXprPB/F7c bcGQ== X-Gm-Message-State: AOAM533ECWB5d3dT1014Bw5+o/4UghUzOJ+nnnc5ARH9XcVmOuz3ngyb N03S6GsyAlwgj9Sddyr9o3tRqiSbEhXwoDTgicbnvJK+vErQSL17CchWwDAL3QmeROGSJZgQvrT 3wsQkgkF/+DA= X-Received: by 2002:a05:6602:3994:b0:665:3ede:c149 with SMTP id bw20-20020a056602399400b006653edec149mr19671631iob.72.1654805608016; Thu, 09 Jun 2022 13:13:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx75hnzQeKoMt1Bnyi15VyNz8IpcULfT2bJ2XJAWWPinynk57gqIGGVxNT8+bXCESVdkX2Fg== X-Received: by 2002:a05:6602:3994:b0:665:3ede:c149 with SMTP id bw20-20020a056602399400b006653edec149mr19671621iob.72.1654805607780; Thu, 09 Jun 2022 13:13:27 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id cp5-20020a056638480500b0032ea3ba170dsm9939802jab.86.2022.06.09.13.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 13:13:27 -0700 (PDT) Date: Thu, 9 Jun 2022 16:13:25 -0400 From: Peter Xu To: Mike Kravetz , Alejandro Colomar Cc: Alejandro Colomar , linux-man@vger.kernel.org, linux-mm@kvack.org, Michael Kerrisk , David Hildenbrand , Axel Rasmussen Subject: Re: [PATCH v3] madvise.2: Clarify addr/length and update hugetlb support Message-ID: References: <20220608234517.117295-1-mike.kravetz@oracle.com> <3cf768b3-4d09-de13-7975-ebb74a68752e@oracle.com> MIME-Version: 1.0 In-Reply-To: <3cf768b3-4d09-de13-7975-ebb74a68752e@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654805610; a=rsa-sha256; cv=none; b=mARbEiDTsBoo0b8yKRBwt/O9aCHVFXAbOykI+upEwRSmgmUoMinHEnaLwWBt6ufy4u5evi pRAARuAoigDEuYZ2SqvUbqipk9KAWl2WEG9UDEIDfRTxWFwZ5kJLypcjW68twnDdVpYXjB YROZbSZhbAqRund7DmDWAfrES1zOVVs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZYX8veX1; spf=none (imf26.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654805610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sfkcy2khFjdseK3OUXScUbNizZN2+TrVIqo7A7uaLgA=; b=7uu23Tnv5StyrxKSQhVdTFmUuPyQoDEtEoWtiHKbphEDzdsVyBsOD2prgvORIkbtZ3HaPb 2MKgWQVWKsVKtBirFBoUp2TJdPyP42HNsDRmrNkZLHikVDvg97MX558KtjCeIaaBbbChPV W2YEGALz76c8P/Ay5at+f/2c3qRm7Wk= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 60BA3140066 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZYX8veX1; spf=none (imf26.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: y47s6cbe4o4ig5wiuwh79ah11mzznbf7 X-HE-Tag: 1654805610-702111 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 11:48:06AM -0700, Mike Kravetz wrote: > On 6/9/22 06:24, Alejandro Colomar wrote: > > Hi Mike, > > > > On 6/9/22 01:45, Mike Kravetz wrote: > >> Clarify that madvise only works on full pages, and remove references > >> to 'bytes'. > >> > >> Update MADV_DONTNEED and MADV_REMOVE sections to remove notes that > >> HugeTLB mappings are not supported.  Indicate the releases when they > >> were first supported as well as alignment restrictions. > >> > >> Signed-off-by: Mike Kravetz > >> Acked-by: Peter Xu > > > > Please check some comments below. > > > > Thanks, > > > > Thank you! > > And, my apologies for not looking at formatting requirements. > Will send a v4 shortly. Alex, Do you think we could add some of the semantic newline requirement into CONTRIBUTING file explicitly? Although there's a pointer to man7 man-pages but the semantic newlines rules seem to be easily overlooked. IMHO there can even be examples as you quoted in the link on "UNIX For Beginners": https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/man7/man-pages.7?h=alx/main&id=6ff6f43d68164f99a8c3fb66f4525d145571310c Maybe that'll ease both the maintainers and the contributors? Thanks, -- Peter Xu