From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF09C433EF for ; Thu, 9 Jun 2022 18:16:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195308D0036; Thu, 9 Jun 2022 14:16:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 145D38D0034; Thu, 9 Jun 2022 14:16:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00D0B8D0036; Thu, 9 Jun 2022 14:16:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E14098D0034 for ; Thu, 9 Jun 2022 14:16:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B446F32776 for ; Thu, 9 Jun 2022 18:16:11 +0000 (UTC) X-FDA: 79559501742.19.370FC01 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id E52F04005C for ; Thu, 9 Jun 2022 18:16:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F042DCE3092; Thu, 9 Jun 2022 18:16:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7CC4C34114; Thu, 9 Jun 2022 18:16:04 +0000 (UTC) Date: Thu, 9 Jun 2022 19:16:01 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v3 3/3] mm: kmemleak: check physical address when scan Message-ID: References: <20220609124950.1694394-1-patrick.wang.shcn@gmail.com> <20220609124950.1694394-4-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609124950.1694394-4-patrick.wang.shcn@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654798571; a=rsa-sha256; cv=none; b=XZzNjGF1r/VQU/ZzBh4rY/NWz4FMJ49Z8Bn53WqjYhRU0C4gQzmikkA8zIYID+hMKz2Aa2 6EaztPRv0wTZDFY/MYmlvDftoEOBPwNFULD4kGJet7G/9YKRusj9c+E2KRi7macQ0fwEwE w0pXO1RZ2/BZduUAMBmleyPPWZXn5AY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654798571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=81mJ5zteH9QajiguCF0ErkVpq5QJpHLN6IVQaINPgsw=; b=FgaJq8pTEn+DfvwSWIIyUy5cXI62dkPs9iwygiNq2CwK09STj8ObovKJv/wlVYnXz7NMZO 9SBJuZGrVEJIYgSISfiokMwzEpu9xTqBBMBSUmCrsEQg06up+HHZu5uCROowDc3+dCSTtn hkxjQr/uqsy0Xnk+Nff7vjiBEs2ARL8= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E52F04005C X-Stat-Signature: ifktysx9dp1q47ycagphtajgzrgt9fes X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-HE-Tag: 1654798570-135266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 08:49:50PM +0800, Patrick Wang wrote: > Check the physical address of objects for its boundary > when scan instead of in kmemleak_*_phys(). > > Fixes: 23c2d497de21 ("mm: kmemleak: take a full lowmem check in kmemleak_*_phys()") > Suggested-by: Catalin Marinas > Signed-off-by: Patrick Wang Reviewed-by: Catalin Marinas The fixed commit above was cc stable, so we'll probably need all these three patches in stable. But I'd keep them a bit in -next for testing first (and I see Andrew already picked them up; we might as well merge them in 5.20 and send them to -stable after, it's not some critical feature). Thanks for the series. I don't think you need to respin unless others of comments. -- Catalin