From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E151BC43334 for ; Thu, 9 Jun 2022 18:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 404BB8D0033; Thu, 9 Jun 2022 14:10:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B44C6B00D4; Thu, 9 Jun 2022 14:10:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A23E8D0033; Thu, 9 Jun 2022 14:10:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1C6C86B00D3 for ; Thu, 9 Jun 2022 14:10:28 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E4CF1342C7 for ; Thu, 9 Jun 2022 18:10:27 +0000 (UTC) X-FDA: 79559487294.12.5EF5223 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 246922005F for ; Thu, 9 Jun 2022 18:10:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 466F861D0B; Thu, 9 Jun 2022 18:10:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B0F9C34114; Thu, 9 Jun 2022 18:10:24 +0000 (UTC) Date: Thu, 9 Jun 2022 19:10:20 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical address for objects allocated with PA Message-ID: References: <20220609124950.1694394-1-patrick.wang.shcn@gmail.com> <20220609124950.1694394-3-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609124950.1694394-3-patrick.wang.shcn@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654798227; a=rsa-sha256; cv=none; b=YKmhbT3O/FsUugwzwJ5cYW6DjX7y3DW1L8mmbB4TQt6f3DdbQ9Uf8w+2nedR8JznAS4qI0 J6qQCrsai4P+lt1JjRr3GJoT+nAAxs30FeryGd1MsyxwfIh0Gvxg1amnF0nL2kQkB6kdFh OE1FgH6CJDR6TBWYFbXt1LUHRprG+jo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654798227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WFYaWu9ejWaJdHMWjMKmFr2CK7MnnDNtsGAjsc7U/c=; b=1SX1c7kDM1jYyti6cvCTugR0yi+dMM8E0t60F3cTCNO3sCqd4F1ez7QPMbGk4Lr2VA+inA 7QL4mSYmZ44wrnLMDpma9Vw+lVRw1jbn9Ry+r7haMBX9QUwIw8Y1okcLBmpei++Y4PoGn/ 4Q8i9lzTId74Luk79bj0RrZAveWYmVw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf13.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf13.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Stat-Signature: snywg5gex5t1a4eyf3w9w9fosszw3b5c X-Rspamd-Queue-Id: 246922005F X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1654798226-731917 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 08:49:49PM +0800, Patrick Wang wrote: > Add object_phys_tree_root to store the objects allocated with > physical address. Distinguish it from object_tree_root by > OBJECT_PHYS flag or function argument. The physical address > is stored directly in those objects. And remove the unused > kmemleak_not_leak_phys() function. > > Suggested-by: Catalin Marinas > Signed-off-by: Patrick Wang > --- > Documentation/dev-tools/kmemleak.rst | 1 - > include/linux/kmemleak.h | 4 - > mm/kmemleak.c | 145 +++++++++++++++++---------- > 3 files changed, 91 insertions(+), 59 deletions(-) > > diff --git a/Documentation/dev-tools/kmemleak.rst b/Documentation/dev-tools/kmemleak.rst > index 1c935f41cd3a..5483fd39ef29 100644 > --- a/Documentation/dev-tools/kmemleak.rst > +++ b/Documentation/dev-tools/kmemleak.rst > @@ -174,7 +174,6 @@ mapping: > > - ``kmemleak_alloc_phys`` > - ``kmemleak_free_part_phys`` > -- ``kmemleak_not_leak_phys`` > - ``kmemleak_ignore_phys`` Same comment - only if you respin, move the kmemleak_not_leak_phys() removal to a separate patch. Otherwise: Reviewed-by: Catalin Marinas