linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Patrick Wang <patrick.wang.shcn@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, yee.lee@mediatek.com
Subject: Re: [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical address for objects allocated with PA
Date: Thu, 9 Jun 2022 19:10:20 +0100	[thread overview]
Message-ID: <YqI3jE/4ndkmPVMc@arm.com> (raw)
In-Reply-To: <20220609124950.1694394-3-patrick.wang.shcn@gmail.com>

On Thu, Jun 09, 2022 at 08:49:49PM +0800, Patrick Wang wrote:
> Add object_phys_tree_root to store the objects allocated with
> physical address. Distinguish it from object_tree_root by
> OBJECT_PHYS flag or function argument. The physical address
> is stored directly in those objects. And remove the unused
> kmemleak_not_leak_phys() function.
> 
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Patrick Wang <patrick.wang.shcn@gmail.com>
> ---
>  Documentation/dev-tools/kmemleak.rst |   1 -
>  include/linux/kmemleak.h             |   4 -
>  mm/kmemleak.c                        | 145 +++++++++++++++++----------
>  3 files changed, 91 insertions(+), 59 deletions(-)
> 
> diff --git a/Documentation/dev-tools/kmemleak.rst b/Documentation/dev-tools/kmemleak.rst
> index 1c935f41cd3a..5483fd39ef29 100644
> --- a/Documentation/dev-tools/kmemleak.rst
> +++ b/Documentation/dev-tools/kmemleak.rst
> @@ -174,7 +174,6 @@ mapping:
>  
>  - ``kmemleak_alloc_phys``
>  - ``kmemleak_free_part_phys``
> -- ``kmemleak_not_leak_phys``
>  - ``kmemleak_ignore_phys``

Same comment - only if you respin, move the kmemleak_not_leak_phys()
removal to a separate patch. Otherwise:

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>


  reply	other threads:[~2022-06-09 18:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 12:49 [PATCH v3 0/3] mm: kmemleak: store objects allocated with physical address separately and check when scan Patrick Wang
2022-06-09 12:49 ` [PATCH v3 1/3] mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical address Patrick Wang
2022-06-09 18:06   ` Catalin Marinas
2022-06-09 12:49 ` [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical address for objects allocated with PA Patrick Wang
2022-06-09 18:10   ` Catalin Marinas [this message]
2022-06-09 12:49 ` [PATCH v3 3/3] mm: kmemleak: check physical address when scan Patrick Wang
2022-06-09 18:16   ` Catalin Marinas
2022-06-11  3:46     ` Patrick Wang
2022-06-11  9:46       ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqI3jE/4ndkmPVMc@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=patrick.wang.shcn@gmail.com \
    --cc=yee.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox