From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC6DC433EF for ; Thu, 9 Jun 2022 12:19:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7C608D000B; Thu, 9 Jun 2022 08:19:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2C668D0006; Thu, 9 Jun 2022 08:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1C018D000B; Thu, 9 Jun 2022 08:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C26FD8D0006 for ; Thu, 9 Jun 2022 08:19:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 974A921027 for ; Thu, 9 Jun 2022 12:19:22 +0000 (UTC) X-FDA: 79558602564.30.D64D4AA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id CD05840071 for ; Thu, 9 Jun 2022 12:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1Py1XbeQYoV2WaLT1b7PoYSfrJY33ukYR++1ZCekWrA=; b=d5SJnp5L55UkGo1Z+IupQH6lgu 0gkbpMt2/QZ4OvDi8xybTKth8gEqRWU3azU0NGb1gQMBIoYHblgP9l8SkGX1G9+uUvRgki1kHPZmD 6XVTPqS9TRmXEXTB/cP7I5WpebsIfo0D8yDIjbhDPKbkwDEcrpdXEzyFK5LOOhF4TDAvwAbVriqgq 2nfUW9+XjyizpJOLyVruQBK7PFEZw9ImhShAnMgiQJWk5tPYJ67cio1VNzFHTkPrq4mh2yoNjhjIf m1aQOc+E/U/brKoYAysMB07FpTjrAY185m9Q3ofZoZeouVvl/NHMBmjpwYXYi1QBrv3vTQjT0dhZG FSY7wkRg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzH7i-00DXRv-7v; Thu, 09 Jun 2022 12:18:50 +0000 Date: Thu, 9 Jun 2022 13:18:50 +0100 From: Matthew Wilcox To: Baolin Wang Cc: kernel test robot , 0day robot , LKML , linux-csky@vger.kernel.org, openrisc@lists.librecores.org, linux-arch@vger.kernel.org, lkp@lists.01.org, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [mm] 9b12e49e9b: BUG:Bad_page_state_in_process Message-ID: References: <20220608143819.GA31193@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654777162; a=rsa-sha256; cv=none; b=Q8E0Kcb1wATy7XnjkvAOuX5LVzPLQeaOyQZ6FlH+Sh/TjWvcu15shx/5v2OeWtT07BPcxI wiMx7QDOQErz04xM6kgI3+WI6KnGK5X6gVkFPMUvVyUJwEoZPxJtVIwUM57xCLS4coY/6U Aw43zv9cclbebIZD6EVe9XPjrpoMoe0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d5SJnp5L; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654777162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Py1XbeQYoV2WaLT1b7PoYSfrJY33ukYR++1ZCekWrA=; b=QawIOk9c8l0oPZpHp2amdQy4pAuYPGrXKUWflpaTfgqkahkeiEs+7I5otixMu5vyOsAb80 9J75ENUh3kk4eKP1GNZ8TOiT9MKlYIuer0uOUXa3oe5YCzQWmD4GO1zREF/helmakeceX3 /a66Hb3odja/YK75QczEMDLuyUXH39Y= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CD05840071 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=d5SJnp5L; dmarc=none; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: ru3zn1fjc7b56qkebfwtsyxqwyngbn3z X-HE-Tag: 1654777161-665350 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 12:42:16PM +0800, Baolin Wang wrote: > diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c > index 6cccf52e156a..cae74e972426 100644 > --- a/arch/x86/mm/pgtable.c > +++ b/arch/x86/mm/pgtable.c > @@ -858,6 +858,7 @@ int pmd_free_pte_page(pmd_t *pmd, unsigned long addr) > /* INVLPG to clear all paging-structure caches */ > flush_tlb_kernel_range(addr, addr + PAGE_SIZE-1); > > + pgtable_clear_and_dec(virt_to_page(pte)); > free_page((unsigned long)pte); > > return 1; If you're going to call virt_to_page() here, you may as well cache the result and call __free_page(page) to avoid calling virt_to_page() twice.