From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02C6FC433EF for ; Thu, 9 Jun 2022 10:15:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3476B009E; Thu, 9 Jun 2022 06:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65BB96B009F; Thu, 9 Jun 2022 06:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FC748D0001; Thu, 9 Jun 2022 06:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3CA456B009E for ; Thu, 9 Jun 2022 06:15:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 0993F60F5E for ; Thu, 9 Jun 2022 10:15:24 +0000 (UTC) X-FDA: 79558290168.16.506A8F5 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf30.hostedemail.com (Postfix) with ESMTP id E3BB580067 for ; Thu, 9 Jun 2022 10:15:22 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id q12-20020a17090a304c00b001e2d4fb0eb4so26244199pjl.4 for ; Thu, 09 Jun 2022 03:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ufJl6VIloac58LmFJOTIIuW4aL5dursujGi4quOZJbo=; b=FPueMYm4/4TPKnGa+7C+y/GXKMYfJu6ySLsinY2ZCgrg8+ahFW54U2f+NTWeg+UPMf PihxWT6aRHx5VHWmsQa23ZD3YqyGp2jEXZwFJRXC/bu08Gx4LA9VhbMFl9JvW5PnuFzw 52nupEclf109zIKJ7NJ837fivrbytrq03avp1CbY3AG7JO1PvnnnSY1EUzC/D82X8c/I x3Yo7vupRVvhfnG3s7pBht+sp7oJ3uCT6Fy2mWJw0kmDFSRrKGgqdf1MRvD13EGc4Nqi /LTKUZ3/JFyEp9xGzfnwLjyRpF1we4mkYGxW8C1qVKc/aN9vJCtC5chbGLdQsM5VQkMZ 6GcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ufJl6VIloac58LmFJOTIIuW4aL5dursujGi4quOZJbo=; b=CqL/rZ7nPhvBCbnReW6DNJLNaiAaJ3FtncSHDikSISM+gH+2e5Kw89Ols+V+bp4jnV khR3S2OKqxDh3Ns97y/gV/XhjCjz5LU+sqQcMoqFrfvEieFiaBCHTiXbSScbuRcBFtaS RC5Q/4OSnKZYt3SM41JuY8hWKYXYzU2G9/EkEsXlIPhh+Hc5HpSFYQmgXo36d2qfQoTg d8/7RF5Ty1Xahd3/NJ/IleIc5P9t9DwItVqepN6xtYRS+RX3RINX8MNdl6CSnbI1ldG4 bhR28VWrtDcM70FEoq9vNNUvgMoudNFOYPZlTuJdnfzewM/G8VgD8e0p4ho9qnIUu079 6sdQ== X-Gm-Message-State: AOAM532I5q20O0MrrC4R+EhoIC+Qq8ksn24icb2Lf0xFS1f7bRkogn8S 6Dyq5YlN2b2EptkUcUADandvcQ== X-Google-Smtp-Source: ABdhPJwtXMiI03JSAH/v54Ng0739h8q3umyvW1cZffBfxkhwLE90SKyBifS8Zo6kLL7EHL8HzBmMDQ== X-Received: by 2002:a17:90b:4f8d:b0:1e8:38f5:e199 with SMTP id qe13-20020a17090b4f8d00b001e838f5e199mr2751665pjb.64.1654769721623; Thu, 09 Jun 2022 03:15:21 -0700 (PDT) Received: from localhost ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id v12-20020a170902b7cc00b00163f2fe1e64sm16490156plz.255.2022.06.09.03.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jun 2022 03:15:21 -0700 (PDT) Date: Thu, 9 Jun 2022 18:15:16 +0800 From: Muchun Song To: Michal Hocko Cc: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, vbabka@suse.cz, mgorman@techsingularity.net, peterz@infradead.org, dhowells@redhat.com, willy@infradead.org, Liam.Howlett@oracle.com, kemi.wang@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: sysctl: fix missing numa_stat when !CONFIG_HUGETLB_PAGE Message-ID: References: <20220609040342.2703-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654769723; a=rsa-sha256; cv=none; b=DyjCgj19HyY32P6Dc2Cv+vjLcU/ZKRSCfJz7q+ANTZtMmCXcHC0SjtFkjp5jH3jFslN+ba Zg8mlxZrEbmmzxyWBAm3O1s5qG+KMx2FDg48BT1XImQkizZLDBm3vk7dfvXdHKJAeR31Iu 2TSui2Tla6Pw0PDyxqtSabwT3db7xOY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FPueMYm4; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654769723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ufJl6VIloac58LmFJOTIIuW4aL5dursujGi4quOZJbo=; b=p6FqNozGYUmGAvd9LkdoJhcfMU4hle0ofvtuaCm9+Ebr8ig2rSrRHfTH6TwE0Lf+nZfglm W4S6o3JXeqGI41NwgSTn62pBEoCqjc/yiSnaFKtMx2S42zWoykCtZWY2gv3+bZEdoa0obc R+RaJI1BOhZA7pgvHoHyE3laAJIKyow= X-Rspamd-Queue-Id: E3BB580067 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FPueMYm4; spf=pass (imf30.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: qawt8etxnot5nhm3jbatee363spwp964 X-HE-Tag: 1654769722-554285 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 09, 2022 at 10:45:56AM +0200, Michal Hocko wrote: > On Thu 09-06-22 12:03:42, Muchun Song wrote: > > "numa_stat" should not be included in the scope of CONFIG_HUGETLB_PAGE, > > if CONFIG_HUGETLB_PAGE is not configured even if CONFIG_NUMA is configured, > > "numa_stat" is missed form /proc. Remove it out of CONFIG_HUGETLB_PAGE > > and move numa_stat sysctl handling to mm/vmstat.c. > > > > Fixes: 4518085e127d ("mm, sysctl: make NUMA stats configurable") > > Signed-off-by: Muchun Song > > Cc: > > It really looks like numa_stat is misplaced but I am wondering why the > fix cannot be as simple as > Your changes LGTM. I think I have overdone it. I really should seprate this into two separate patches, one is bug fix (just like your changes), another is simplify the code further. I'll rework this patch. Thanks.