From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6F1C433EF for ; Thu, 9 Jun 2022 09:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A74496B009A; Thu, 9 Jun 2022 05:54:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A24246B009B; Thu, 9 Jun 2022 05:54:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C56B8D0001; Thu, 9 Jun 2022 05:54:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 78E796B009A for ; Thu, 9 Jun 2022 05:54:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 5216C60EE7 for ; Thu, 9 Jun 2022 09:54:18 +0000 (UTC) X-FDA: 79558236996.29.BB86B07 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id E249B100063 for ; Thu, 9 Jun 2022 09:54:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C28FB61CDA; Thu, 9 Jun 2022 09:54:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2D4C3411B; Thu, 9 Jun 2022 09:54:14 +0000 (UTC) Date: Thu, 9 Jun 2022 10:54:11 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v2 1/4] mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical address Message-ID: References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> <20220603035415.1243913-2-patrick.wang.shcn@gmail.com> <8fc24ba3-1467-b845-a70e-7ed77750e6cd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fc24ba3-1467-b845-a70e-7ed77750e6cd@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654768458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZhzOVUao5w9DMEnzkkUCheIUF8AFcs8EVh0y97t4Z14=; b=cva50Gw+YjPuUwTGoEc445FfpTfPzIxJm2LngGgDGl+11V8euAo7BpI4kJMANapG+ZdAGs cUqhu7c6ocX8bXQx+R6a1nq2TdQOWWh9lax00XbHglpW7lSfVsnJ357IN9TJ9Jb9yz8Dq/ 2HD81yTNXzg+Nv4VaFZR6d7gnUZYEes= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654768458; a=rsa-sha256; cv=none; b=55txNiqJ7ASNQS5ymno3INwHtnDJ/EHvfXrH/tHd8VB1kQX8dfFYP+XQc9Dxim/nNkz4Vr tCp3PRDhLByHX8eBEjWZtUACiFCTcvzCR18sGHsNIq7GlrCZJLwDpNktqa9UKiGCNvWKRt tl4RiPQVuaoNow9xiwgx8Hd8Fh/iTtU= X-Stat-Signature: kkt3eeyckhbrusmq5355m1wa699rix4s X-Rspamd-Queue-Id: E249B100063 Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1654768457-573227 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 07, 2022 at 10:32:26PM +0800, Patrick Wang wrote: > The leak check could be taken on physical objects. Conversion > of block address from virtual to physical before lookup should > make this work (this is useless currently). I think we'd better > know about this. Yes, we could add this, but since all the phys objects are currently 'gray', it won't make any difference, other than an extra lookup in the phys tree. -- Catalin