From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5532C43334 for ; Thu, 9 Jun 2022 09:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEA5E6B0095; Thu, 9 Jun 2022 05:18:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D72CC6B0096; Thu, 9 Jun 2022 05:18:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEB9C6B0098; Thu, 9 Jun 2022 05:18:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AAD646B0095 for ; Thu, 9 Jun 2022 05:18:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6A38A350A4 for ; Thu, 9 Jun 2022 09:18:47 +0000 (UTC) X-FDA: 79558147494.30.91457D9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id F087240075 for ; Thu, 9 Jun 2022 09:18:40 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 897FE21DD8; Thu, 9 Jun 2022 09:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1654766319; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HayFit8bzwaDzpMDwYah/6SiOyQ4+BuRvDiuto6PjDE=; b=J3GHj6NgeZC2l6CCYS42pH1ur4gz/kZ8MjGwuv4MbjKYXuPXxJ+9p2sVq8TpFihaL3ga3L OiWYpUIDPFjIZgZ9CnMwU2mlrRW3/WMDJfS2SqBYd9qIWY6OST8injns6Do0hW5LlP8Sp/ haVizaclvKA0L+81Pw2138qaN9TGJvI= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 351742C142; Thu, 9 Jun 2022 09:18:39 +0000 (UTC) Date: Thu, 9 Jun 2022 11:18:38 +0200 From: Michal Hocko To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, christian.koenig@amd.com, alexander.deucher@amd.com, daniel@ffwll.ch, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, hughd@google.com, andrey.grodzovsky@amd.com Subject: Re: [PATCH 03/13] mm: shmem: provide oom badness for shmem files Message-ID: References: <20220531100007.174649-1-christian.koenig@amd.com> <20220531100007.174649-4-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220531100007.174649-4-christian.koenig@amd.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654766321; a=rsa-sha256; cv=none; b=bsx0B+hp9ZTAeERCpladoSH1Vn5AELsMH3/P7Nl96qrD6MLx+pfzOE3BUIAQ+tzfRw6AaD +d195m4tggCQ6P+YnwLYTMxqVlEGxVRpnZHg+9JJbn4nMkKtj2GLDoFQ9L7vporQehebpr 8vutGUUQVO1HDNBWeELX4AkLRhG+oio= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=J3GHj6Ng; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654766321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HayFit8bzwaDzpMDwYah/6SiOyQ4+BuRvDiuto6PjDE=; b=Bxq7WPX4eAkLvQ6zot71F/pps9tjYgWeWINnOz287iitadmyKSlB1VJ0RFyAKOV7MkYZTf 6cd85Lubc5PITwpD+YMguW/Xji20SqRZRtu7efrMV9WduJOU5G/2E1m8cNDZrB1aw1lFmZ 6fR/4bgQJB24FviImYoGMfR84/YsdWw= X-Rspamd-Queue-Id: F087240075 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=J3GHj6Ng; spf=pass (imf27.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 8ogkq3pp4x9n8gyqi8833wsynhh9u97w X-HE-Tag: 1654766320-650752 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 31-05-22 11:59:57, Christian König wrote: > This gives the OOM killer an additional hint which processes are > referencing shmem files with potentially no other accounting for them. > > Signed-off-by: Christian König > --- > mm/shmem.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 4b2fea33158e..a4ad92a16968 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2179,6 +2179,11 @@ unsigned long shmem_get_unmapped_area(struct file *file, > return inflated_addr; > } > > +static long shmem_oom_badness(struct file *file) > +{ > + return i_size_read(file_inode(file)) >> PAGE_SHIFT; > +} This doesn't really represent the in memory size of the file, does it? Also the memcg oom handling could be considerably skewed if the file was shared between more memcgs. -- Michal Hocko SUSE Labs