From: Michal Hocko <mhocko@suse.com>
To: cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, oleksandr@natalenko.name,
willy@infradead.org, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-doc@vger.kernel.org, xu xin <xu.xin16@zte.com.cn>
Subject: Re: [PATCH] mm/ksm: provide global_force to see maximum potential merging
Date: Thu, 9 Jun 2022 11:36:15 +0200 [thread overview]
Message-ID: <YqG/Dyj62aDK/3Jr@dhcp22.suse.cz> (raw)
In-Reply-To: <20220609055658.703472-1-xu.xin16@zte.com.cn>
On Thu 09-06-22 05:56:58, cgel.zte@gmail.com wrote:
> From: xu xin <xu.xin16@zte.com.cn>
>
> Up to now, KSM is apparently useful to save memory not just for VM but for
> normal applications. But upper application developers might not know much
> about KSM or whether they should use madvise(xxx, MERGEABLE) while there
> indeed exist a lot of same pages in their apps. Some application developers
> urgently need the kernel to provide an interface of KSM debugging mode to
> see the maximum potential merging of the whole system, so the patch is.
I disagree with this. As already discussed in previous proposals of KSM
related interfaces KSM is a nice tool but it shouldn't be used without
understanding of all the consequences.
Maybe we should be more verbose about how to use KSM properly and also
describe best practices but I do not think that enable-for-all in any
form is a good interface.
Nack to the interface.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2022-06-09 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 5:56 cgel.zte
2022-06-09 9:36 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqG/Dyj62aDK/3Jr@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgel.zte@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksandr@natalenko.name \
--cc=willy@infradead.org \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox