From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2187C433EF for ; Wed, 8 Jun 2022 07:23:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47DD56B0072; Wed, 8 Jun 2022 03:23:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D096B0073; Wed, 8 Jun 2022 03:23:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31BE06B0074; Wed, 8 Jun 2022 03:23:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 226406B0072 for ; Wed, 8 Jun 2022 03:23:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DFBF43512D for ; Wed, 8 Jun 2022 07:23:02 +0000 (UTC) X-FDA: 79554227004.22.DEEEDA5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 7AF361A0012 for ; Wed, 8 Jun 2022 07:23:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654672982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o1idPqOloA86p2fVQONMUWnq8T0JoB50Wldq7zBiLdw=; b=LrpMik8yv5sQsh5rVDGRfzT47y6hXfikrAHqL7w1exnxQdv3aP7I09VCPGJruwDNLn/NA5 v6fV5P8AlVvci4j9/gwD8lF9mYbGTOCWimmSuvLuqW2cGQtIqItSN65gQs1Mf21VHSSyZ9 eXsd+cjaRglIAM1mbGfLTMcE7iUFOR8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-uObRR-dCP9i-_Pw1WR2-Dw-1; Wed, 08 Jun 2022 03:22:58 -0400 X-MC-Unique: uObRR-dCP9i-_Pw1WR2-Dw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B5F480B712; Wed, 8 Jun 2022 07:22:58 +0000 (UTC) Received: from localhost (ovpn-12-81.pek2.redhat.com [10.72.12.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 339C11121314; Wed, 8 Jun 2022 07:22:56 +0000 (UTC) Date: Wed, 8 Jun 2022 15:22:53 +0800 From: Baoquan He To: Kefeng Wang Cc: catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, arnd@arndb.de, anshuman.khandual@arm.com Subject: Re: [PATCH v5 2/6] mm: ioremap: Use more sensibly name in ioremap_prot() Message-ID: References: <20220607125027.44946-1-wangkefeng.wang@huawei.com> <20220607125027.44946-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LrpMik8y; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf19.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=bhe@redhat.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7AF361A0012 X-Stat-Signature: 8t6zq6ztr7br7tfms9hnjsh3jg6kdjxd X-HE-Tag: 1654672982-167004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/08/22 at 12:16pm, Baoquan He wrote: > On 06/07/22 at 08:50pm, Kefeng Wang wrote: > > Use more meaningful and sensibly naming phys_addr > > instead addr in ioremap_prot(). > > > > Suggested-by: Andrew Morton > > Reviewed-by: Anshuman Khandual > > Signed-off-by: Kefeng Wang > > --- > > include/asm-generic/io.h | 3 ++- > > mm/ioremap.c | 14 ++++++++------ > > 2 files changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > > index 7ce93aaf69f8..b76379628a02 100644 > > --- a/include/asm-generic/io.h > > +++ b/include/asm-generic/io.h > > @@ -964,7 +964,8 @@ static inline void iounmap(volatile void __iomem *addr) > > #elif defined(CONFIG_GENERIC_IOREMAP) > > #include > > > > -void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot); > > +void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, > > + unsigned long prot); > > void iounmap(volatile void __iomem *addr); > > > > static inline void __iomem *ioremap(phys_addr_t addr, size_t size) > > diff --git a/mm/ioremap.c b/mm/ioremap.c > > index 5fe598ecd9b7..2d754b48d230 100644 > > --- a/mm/ioremap.c > > +++ b/mm/ioremap.c > > @@ -11,20 +11,21 @@ > > #include > > #include > > > > -void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot) > > +void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size, > > + unsigned long prot) > > { > > unsigned long offset, vaddr; > > phys_addr_t last_addr; > > struct vm_struct *area; > > > > /* Disallow wrap-around or zero size */ > > - last_addr = addr + size - 1; > > - if (!size || last_addr < addr) > > + last_addr = phys_addr + size - 1; > > + if (!size || last_addr < phys_addr) > > return NULL; > > > > /* Page-align mappings */ > > - offset = addr & (~PAGE_MASK); > > - addr -= offset; > > + offset = phys_addr & (~PAGE_MASK); > ~~~ use offset_in_page() instead? Sorry, this patch only does s/addr/phys_addr/, please ignore this comment. > > Other than this nitpick, this looks good to me. > > Reviewed-by: Baoquan He > > > + phys_addr -= offset; > > size = PAGE_ALIGN(size + offset); > > > > area = get_vm_area_caller(size, VM_IOREMAP, > > @@ -33,7 +34,8 @@ void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot) > > return NULL; > > vaddr = (unsigned long)area->addr; > > > > - if (ioremap_page_range(vaddr, vaddr + size, addr, __pgprot(prot))) { > > + if (ioremap_page_range(vaddr, vaddr + size, phys_addr, > > + __pgprot(prot))) { > > free_vm_area(area); > > return NULL; > > } > > -- > > 2.35.3 > > > > >