From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEAFC433EF for ; Wed, 8 Jun 2022 03:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E89C06B0071; Tue, 7 Jun 2022 23:51:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E384F6B0072; Tue, 7 Jun 2022 23:51:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFF846B0073; Tue, 7 Jun 2022 23:51:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BE82F6B0071 for ; Tue, 7 Jun 2022 23:51:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9905660889 for ; Wed, 8 Jun 2022 03:51:34 +0000 (UTC) X-FDA: 79553694108.23.61E8E47 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf15.hostedemail.com (Postfix) with ESMTP id 3A657A0005 for ; Wed, 8 Jun 2022 03:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654660293; x=1686196293; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xIcozfLdj0wmlKDo/KeNlOUgX9nLL33V5khVHg6L5cw=; b=FLjY6Bcqmn+VUAFnwZH3w3kGmHNvSP9JEMXE75+gIq3rhMS1mmGzLUNy 3iXaxOBadA+zTOUZTPLWuEmcM6KYZXZtfqwoi5zKBotS/N5VPOHnCE76V 0P4UUeKviiFIITVeaG4zmMtQVwU2oP3GhCs7Ki1wONpg+evSrJS9axyvc 19vBiA1E/kQHy0pbk3eJ81+Ikd7VwTCPsdGvxFIuE3t6YYIYGl3KcBB6u yeoicKc3k/QUfZN551siLuVsKAqEk2o1PaoVdsblyOo2qZJ02TS1BwpYU wQTeGdaJaOVND+njKVC30LHJvC+obGxOxM0qLV8l/ODtglzomEUeHukfw g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="276822122" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="276822122" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 20:51:28 -0700 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="636530713" Received: from rli9-dbox.sh.intel.com (HELO rli9-dbox) ([10.239.159.142]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 20:51:26 -0700 Date: Wed, 8 Jun 2022 11:49:53 +0800 From: Philip Li To: Andrew Morton Cc: kernel test robot , Shiyang Ruan , kbuild-all@lists.01.org, Linux Memory Management List , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [kbuild-all] Re: [linux-next:master 728/1207] fs/xfs/xfs_file.c:1266:31: sparse: sparse: incorrect type in return expression (different base types) Message-ID: References: <202206071511.FI7WLdZo-lkp@intel.com> <20220607160546.2a0a826d29bec858ca402720@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607160546.2a0a826d29bec858ca402720@linux-foundation.org> X-Stat-Signature: m5b5sztnxeu8dxa1efd6s7w3rymhda65 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FLjY6Bcq; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of philip.li@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=philip.li@intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3A657A0005 X-HE-Tag: 1654660292-253151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 07, 2022 at 04:05:46PM -0700, Andrew Morton wrote: > On Tue, 7 Jun 2022 15:09:18 +0800 kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 73d0e32571a0786151eb72634f1a4c5891166176 > > commit: d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c [728/1207] xfs: support CoW in fsdax mode > > config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220607/202206071511.FI7WLdZo-lkp@intel.com/config) > > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 > > reproduce: > > # apt-get install sparse > > # sparse version: v0.6.4-18-g56afb504-dirty > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/xfs/ > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > > > sparse warnings: (new ones prefixed by >>) > > >> fs/xfs/xfs_file.c:1266:31: sparse: sparse: incorrect type in return expression (different base types) @@ expected int @@ got restricted vm_fault_t @@ > > fs/xfs/xfs_file.c:1266:31: sparse: expected int > > fs/xfs/xfs_file.c:1266:31: sparse: got restricted vm_fault_t > > >> fs/xfs/xfs_file.c:1260:1: sparse: sparse: symbol 'xfs_dax_fault' was not declared. Should it be static? > > >> fs/xfs/xfs_file.c:1314:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted vm_fault_t [usertype] ret @@ got int @@ > > fs/xfs/xfs_file.c:1314:21: sparse: expected restricted vm_fault_t [usertype] ret > > fs/xfs/xfs_file.c:1314:21: sparse: got int > > > > Please review and possibly fold the followup patch. > > Well yes, the followup patch > (https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/xfs-support-cow-in-fsdax-mode-fix.patch) > will most definitely be folded. Sorry, currently we disable the auto patch, this sentence "Please review and possibly fold the followup patch" is misleading. We will not have follow up patch before we can have human to do a check. > > Can you suggest how this can be communicated to the robot in order to > suppress this notification? A Fixes: won't work, as neither of these > patches have yet been promoted to a "stable" state. Their hashes will > change. Got it, we also think the Fixes tag in the proposed patch brings confusion if the "bad" commit is in development state. So far, we haven't exposed a way to feedback the "Fixes: won't work", but we will work on some level of mail based communication in 2nd half this year, which can simplify the communication like this. Anyway, we now disable the auto patch to avoid bring confusion and sometimes wrong patch without human check. > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org